From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F802C47247 for ; Tue, 5 May 2020 15:03:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30ED22078C for ; Tue, 5 May 2020 15:03:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729812AbgEEPDL (ORCPT ); Tue, 5 May 2020 11:03:11 -0400 Received: from foss.arm.com ([217.140.110.172]:42624 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729808AbgEEPDK (ORCPT ); Tue, 5 May 2020 11:03:10 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EC3901FB; Tue, 5 May 2020 08:03:09 -0700 (PDT) Received: from [10.37.8.251] (unknown [10.37.8.251]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C824E3F68F; Tue, 5 May 2020 08:03:08 -0700 (PDT) Subject: Re: [PATCH v2 0/4] kselftest: Extend vDSO tests To: Arnd Bergmann Cc: "linux-kernel@vger.kernel.org" , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan , Thomas Gleixner , Andy Lutomirski References: <20200429112834.24908-1-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: Date: Tue, 5 May 2020 16:04:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi Arnd, On 5/5/20 3:50 PM, Arnd Bergmann wrote: > On Wed, Apr 29, 2020 at 1:34 PM Vincenzo Frascino > wrote: >> >> This series extends the kselftests for the vDSO library making sure: that >> they compile correctly on non x86 platforms, that they can be cross >> compiled and introducing new tests that verify the correctness of the >> library. >> >> The so extended vDSO kselftests have been verified on all the platforms >> supported by the unified vDSO library [1]. >> >> The only new patch that this series introduces is the first one, patch 2 and >> patch 3 have already been reviewed in past as part of other series [2] [3]. >> >> [1] https://lore.kernel.org/lkml/20190621095252.32307-1-vincenzo.frascino@arm.com >> [2] https://lore.kernel.org/lkml/20190621095252.32307-26-vincenzo.frascino@arm.com >> [3] https://lore.kernel.org/lkml/20190523112116.19233-4-vincenzo.frascino@arm.com > > Hi Vincenzo, > > Not sure if you are aware of the recent bug report about clock_gettime64() > returning invalid times on some arm32 kernels: > https://github.com/raspberrypi/linux/issues/3579 > No, I was not aware of the problem. There has been no mention on the arm list (unless I missed it). I can try to have a look at it as soon as I get some time. > Regardless of when that gets fixed or by whom, I wonder if kselftest should > also check for consistency, i.e. call both the vdso and the syscall version of > clock_gettime() and clock_gettime64() and check that the results are always > in sequence. > The test #4 partially does that: it calls syscall-vdso-syscall and verifies that the sequencing is correct. I reused the x86 code for that. I could extend it to clock_gettime64() and make sure it builds on all the platforms. > Arnd > -- Regards, Vincenzo