Re: [PATCH v4 1/2] KVM: guest_memfd: add generic population via write

[Nikita Kalyazin <kalyazin@amazon.com>]

On 28/08/2025 21:01, David Hildenbrand wrote:
> On 28.08.25 17:31, Kalyazin, Nikita wrote:
>> write syscall populates guest_memfd with user-supplied data in a generic
>> way, ie no vendor-specific preparation is performed.  This is supposed
>> to be used in non-CoCo setups where guest memory is not
>> hardware-encrypted.
>>
>> The following behaviour is implemented:
>>   - only page-aligned count and offset are allowed
>>   - if the memory is already allocated, the call will successfully
>>     populate it
>>   - if the memory is not allocated, the call will both allocate and
>>     populate
>>   - if the memory is already populated, the call will not repopulate it
>>
>> Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
>> ---
> 
> Just nothing that checkpatch complains about
> 
> a) Usage of "unsigned" instead of "unsigned int"

Hi David,


I copied the prototypes straight from the fs.h...  In any case, will fix 
in the next version.

> 
> b) The From doesn't completely match the SOB: "Kalyazin, Nikita" vs
> "Nikita Kalyazin"

It's about .com vs .co.uk, I think.  Will have to use "From:" apparently.


Thanks,
Nikita

> 
> -- 
> Cheers
> 
> David / dhildenb
>