From: Muhammad Usama Anjum <Usama.Anjum@collabora.com>
To: Greg Thelen <gthelen@google.com>, Shuah Khan <shuah@kernel.org>,
Mina Almasry <almasrymina@google.com>
Cc: Usama.Anjum@collabora.com, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: make kselftest-clean remove libynl outputs
Date: Sun, 6 Oct 2024 22:41:22 +0500 [thread overview]
Message-ID: <bc607fd0-41c8-4603-9f50-4d912dbec6e5@collabora.com> (raw)
In-Reply-To: <20241005215600.852260-1-gthelen@google.com>
On 10/6/24 2:56 AM, Greg Thelen wrote:
> Starting with 6.12 commit 85585b4bc8d8 ("selftests: add ncdevmem, netcat
> for devmem TCP") kselftest-all creates additional outputs that
> kselftest-clean does not cleanup:
> $ make defconfig
> $ make kselftest-all
> $ make kselftest-clean
> $ git clean -ndxf | grep tools/net
> Would remove tools/net/ynl/lib/__pycache__/
> Would remove tools/net/ynl/lib/ynl.a
> Would remove tools/net/ynl/lib/ynl.d
> Would remove tools/net/ynl/lib/ynl.o
>
> Make kselftest-clean remove the newly added net/ynl outputs.
>
> Fixes: 85585b4bc8d8 ("selftests: add ncdevmem, netcat for devmem TCP")
> Signed-off-by: Greg Thelen <gthelen@google.com>
> ---
> tools/testing/selftests/net/ynl.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/selftests/net/ynl.mk b/tools/testing/selftests/net/ynl.mk
> index 59cb26cf3f73..1ef24119def0 100644
> --- a/tools/testing/selftests/net/ynl.mk
> +++ b/tools/testing/selftests/net/ynl.mk
> @@ -19,3 +19,7 @@ $(YNL_OUTPUTS): CFLAGS += \
> $(OUTPUT)/libynl.a:
> $(Q)$(MAKE) -C $(top_srcdir)/tools/net/ynl GENS="$(YNL_GENS)" libynl.a
> $(Q)cp $(top_srcdir)/tools/net/ynl/libynl.a $(OUTPUT)/libynl.a
> +
> +EXTRA_CLEAN += \
> + $(top_srcdir)/tools/net/ynl/lib/__pycache__ \
> + $(top_srcdir)/tools/net/ynl/lib/*.[ado]
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
--
BR,
Muhammad Usama Anjum
next prev parent reply other threads:[~2024-10-06 17:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 21:56 [PATCH] selftests: make kselftest-clean remove libynl outputs Greg Thelen
2024-10-06 17:41 ` Muhammad Usama Anjum [this message]
2024-10-08 5:05 ` Guenter Roeck
2024-10-08 17:10 ` patchwork-bot+netdevbpf
2024-10-08 17:37 ` Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc607fd0-41c8-4603-9f50-4d912dbec6e5@collabora.com \
--to=usama.anjum@collabora.com \
--cc=almasrymina@google.com \
--cc=gthelen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox