From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7852C83002 for ; Tue, 28 Apr 2020 00:17:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 747B72078C for ; Tue, 28 Apr 2020 00:17:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588033063; bh=RvIxbz6xV8TKE7G+MxbFyTQV5ilrjLjm+DZT86ra/fs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=GAm2d1Y0mXSK1YVLqB1z6hbpwV2T9L4DVMaB4ue9MEfYJbQee9kaXJA3Ww/pk8ve3 lTPkLc1kp6szXG0LgbF4CrxLEeAOedg28FTdypWv40GUEN5h6f6cReaTK2ft0ar1dN NSaXuWdprGad2bVuh4qVgDJZPiB0DW1O7dYTE1JQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726333AbgD1ARn (ORCPT ); Mon, 27 Apr 2020 20:17:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:55360 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726204AbgD1ARn (ORCPT ); Mon, 27 Apr 2020 20:17:43 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A20DB2072A; Tue, 28 Apr 2020 00:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588033062; bh=RvIxbz6xV8TKE7G+MxbFyTQV5ilrjLjm+DZT86ra/fs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=otOtwt713Z4AldxEewg5HRKiJKciN128nsMQ+bq0PGpC5D7ZU1ZqpF+3YO+/efMIb 4JSS6JEk3VORZoRjGMcoCcSQa20amQXXy9q1o5E4kMz/Hi+SkSFK247KCsmnKx3iMH zASZDdB6wlpUYYkigoji7kgG+ImikasglcTVgkFI= Subject: Re: [PATCH] selftests: introduce gen_tar Makefile target To: Stefano Brivio , Veronika Kabatova Cc: linux-kselftest@vger.kernel.org, shuah References: <20200427192141.2926018-1-vkabatov@redhat.com> <20200427212405.2747394d@redhat.com> From: shuah Message-ID: Date: Mon, 27 Apr 2020 18:17:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200427212405.2747394d@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi Veronika, On 4/27/20 1:24 PM, Stefano Brivio wrote: > On Mon, 27 Apr 2020 21:21:41 +0200 > Veronika Kabatova wrote: > >> The gen_kselftest_tar.sh always packages *all* selftests and doesn't >> pass along any variables to `make install` to influence what should be >> built. This can result in an early error on the command line ("Unknown >> tarball format TARGETS=XXX"), or unexpected test failures as the >> tarball contains tests people wanted to skip on purpose. >> >> Since the makefile already contains all the logic, we can add a target >> for packaging. Keep the default .gz target the script uses, and actually >> extend the supported formats by using tar's autodetection. >> >> To not break current workflows, keep the gen_kselftest_tar.sh script as >> it is, with an added suggestion to use the makefile target instead. >> >> Signed-off-by: Veronika Kabatova > > Reviewed-by: Stefano Brivio > I don't see this in my Inbox. Please include everybody get_maintainers script tells you to do. You can add the Reviewed-by: Stefano Brivio to the patch when you resend it. thanks, -- Shuah