From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02D12ECAAA1 for ; Fri, 9 Sep 2022 13:50:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230355AbiIINuo (ORCPT ); Fri, 9 Sep 2022 09:50:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231366AbiIINul (ORCPT ); Fri, 9 Sep 2022 09:50:41 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 558B64DB11; Fri, 9 Sep 2022 06:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662731408; x=1694267408; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Q7qJIucIZ1FP/A6YhsrnSAedQ0f+a9S5E9nD3L97gk8=; b=GcN+Ew7UQMDt4EoNsOKyJx1pMLDnZlLjjBwqhV9Eqdb4WZ+JSw1PIwiL KlQh+fCz66Zcjaq1VdJ6uQLNiiR+5DjCj9eIYTJMZJWtgQrOosl+hRDj+ ySNOatnH5xO/WJ24oFrez0dyppE3elT1+cXQ8bRMkdfyXiC8hboY45CbA ym7kM/Q/5Budl8jt5bcJJzY062BEjRTmz+7y307WNrZhTy86ARSnDTmSb AvAzlAfV3ARsoPIkXUh62bqos/7NfjuBjokEfcvrYLI+44hphkDeWLLgZ QwXT5kEtutzJMV+kH3euVS2BXyaFTDC/OzCCCt9iaRUrlADTE5AMWvmR+ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10464"; a="298815111" X-IronPort-AV: E=Sophos;i="5.93,303,1654585200"; d="scan'208";a="298815111" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 06:49:58 -0700 X-IronPort-AV: E=Sophos;i="5.93,303,1654585200"; d="scan'208";a="615273507" Received: from omeier-mobl1.ger.corp.intel.com (HELO [10.209.54.138]) ([10.209.54.138]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 06:49:57 -0700 Message-ID: Date: Fri, 9 Sep 2022 06:49:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v12 2/3] selftests: tdx: Test TDX attestation GetReport support Content-Language: en-US To: Sathyanarayanan Kuppuswamy , Wander Lairson Costa Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Shuah Khan , "H . Peter Anvin" , Greg Kroah-Hartman , "Kirill A . Shutemov" , Tony Luck , Andi Kleen , Kai Huang , Isaku Yamahata , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org References: <20220908002723.923241-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220908002723.923241-3-sathyanarayanan.kuppuswamy@linux.intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 9/8/22 18:55, Sathyanarayanan Kuppuswamy wrote: > +#ifdef DEBUG > +#define pr_debug(...) printf(__VA_ARGS__) > +#else > +#define pr_debug(...) _no_printf(__VA_ARGS__) > +#endif If you're going this way, please put this in common selftest code. Don't force every single test to duplicate it. But, seriously, this is all insanity. Fixing the whole "oh, but DEBUG might not be defined" thing is not exactly rocket science. Just do this in your test header or .c file: #ifndef DEBUG #define DEBUG 0 #endif Then you can do: if (DEBUG) foo(); all day long. Or, not. I honestly don't think this is worth even mucking with in the first place.