From: Dave Hansen <dave.hansen@intel.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Sandipan Das <sandipan@linux.ibm.com>,
Ram Pai <linuxram@us.ibm.com>,
Thiago Jung Bauermann <bauerman@linux.ibm.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/vm/keys: fix a broken reference at protection_keys.c
Date: Mon, 4 May 2020 07:10:51 -0700 [thread overview]
Message-ID: <bd55a74d-1305-9e23-94cd-37e59c11dfcd@intel.com> (raw)
In-Reply-To: <d478a2fc5d204691d0cac6e2b416f0e07a26d3d9.1588585390.git.mchehab+huawei@kernel.org>
On 5/4/20 2:44 AM, Mauro Carvalho Chehab wrote:
> Changeset 1eecbcdca2bd ("docs: move protection-keys.rst to the core-api book")
> from Jun 7, 2019 converted protection-keys.txt file to ReST.
>
> A recent change at protection_keys.c partially reverted such
> changeset, causing it to point to a non-existing file:
>
> - * Tests x86 Memory Protection Keys (see Documentation/core-api/protection-keys.rst)
> + * Tests Memory Protection Keys (see Documentation/vm/protection-keys.txt)
>
> It sounds to me that the changeset that introduced such change
> 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
> could also have other side effects, as it sounds that it was not
> generated against uptream code, but, instead, against a version
> older than Jun 7, 2019.
>
> Fixes: 4645e3563673 ("selftests/vm/pkeys: rename all references to pkru to a generic name")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thanks for finding this! The patch set which moved protection-keys.txt
out of x86 code probably just missed this when it got rebased. It
originated well before June 2019, iirc.
Acked-by: Dave Hansen <dave.hansen@intel.com>
next prev parent reply other threads:[~2020-05-04 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 9:44 [PATCH] selftests/vm/keys: fix a broken reference at protection_keys.c Mauro Carvalho Chehab
2020-05-04 14:10 ` Dave Hansen [this message]
2020-05-04 14:38 ` Sandipan Das
2020-05-08 15:54 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd55a74d-1305-9e23-94cd-37e59c11dfcd@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bauerman@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=mchehab+huawei@kernel.org \
--cc=sandipan@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox