From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 315D3C49361 for ; Thu, 17 Jun 2021 11:24:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EF9E613DF for ; Thu, 17 Jun 2021 11:24:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232585AbhFQL0I (ORCPT ); Thu, 17 Jun 2021 07:26:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48024 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232583AbhFQL0H (ORCPT ); Thu, 17 Jun 2021 07:26:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623929039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QeoOEjtdTbZHikE6qVHZkIHtsqJ8oL1MWdn59al3yJU=; b=XGKmgrD9SdsvuqXyHckDF65SGfXEPwJ125BX1n4lHcOoaqG+LyEyDrWbkLn15O25hTs+zA Ry8WKDAN1u0N5G+qRGtigyVkIpIurf4wTcON/NDHRjhUTJsjV/Wd09MaJHz8Xs8t78z+6k 97yHwykTT+NYLqjmiqSSqwIHnutLnc0= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-16-BJjf2sYqPcKx5qcWEXMgww-1; Thu, 17 Jun 2021 07:23:58 -0400 X-MC-Unique: BJjf2sYqPcKx5qcWEXMgww-1 Received: by mail-ed1-f71.google.com with SMTP id g13-20020a056402090db02903935a4cb74fso1330718edz.1 for ; Thu, 17 Jun 2021 04:23:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QeoOEjtdTbZHikE6qVHZkIHtsqJ8oL1MWdn59al3yJU=; b=dkg5QpkrIfjU4oIBolsMEbB4gcimrD14Dw5PM+wLbHQ5lVFtzX6F0RfwdM9+xCAOcD IfTrKH61m5L7iMxNvuryE0J1W0ZBV6HLgeAlQT7AptVK+1UGq8MXaV/gZ569FoWTPCaH oyY+zM1YhKhwjOjUhzOoHSccxui/PO3DDpatV9tr7jLB/dvWscJ1XCd6MjHMku5bp/VR LbPdJ/r72RJD0tx+A7hBZScNIkkbTzdNGQOc7iwo8xDW8MszJiq6nHSVgV9y55ubHClN sJCYPbmxZFBlJytxbUt5qxIQwgcaZJmv9aKTPIEvf4ckjykkYB7eAaUjF20EcgjQgkze N2sA== X-Gm-Message-State: AOAM530ZmPnt0apzRGjWi1Gxl12ndRlF3ggu4rJ3Wqkkc7aoM7iLmfXg XbO/fSyzNEumIoOKbrPWH7sCAXPDjelzxEu3d76srebXk/VULmJUaGn4P6vXz53u4TKDqLmRGln OzUjsLk5gf/x/7L1pt3+r5XZMlA1J X-Received: by 2002:a05:6402:268f:: with SMTP id w15mr5799066edd.228.1623928793194; Thu, 17 Jun 2021 04:19:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzc8lc8kbfFsQbKsVnuEADgPqEmYVAvmC/1IvjtxjrXOO4gKYpFUgt0NPkDolV15GoZuo9rTg== X-Received: by 2002:a05:6402:268f:: with SMTP id w15mr5799027edd.228.1623928793011; Thu, 17 Jun 2021 04:19:53 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id e18sm3537900ejh.64.2021.06.17.04.19.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jun 2021 04:19:52 -0700 (PDT) Subject: Re: [PATCH v10 3/5] KVM: stats: Add documentation for binary statistics interface To: Greg KH , Jing Zhang Cc: KVM , KVMARM , LinuxMIPS , KVMPPC , LinuxS390 , Linuxkselftest , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , Emanuele Giuseppe Esposito , David Matlack , Ricardo Koller , Krish Sadhukhan , Fuad Tabba References: <20210617044146.2667540-1-jingzhangos@google.com> <20210617044146.2667540-4-jingzhangos@google.com> From: Paolo Bonzini Message-ID: Date: Thu, 17 Jun 2021 13:19:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 17/06/21 08:07, Greg KH wrote: >> The statistics data itself could be read out by userspace telemetry >> periodically without any extra parsing or setup effort. > Do you have a pointer to userspace code that can do such a thing that > others can use? We do not like adding apis to the kernel without at > least seeing the user of those apis, especially for complex things like > this. > > Ideally you would include some library code in the kernel tree itself > that everyone can use for this for their own programs. You have > provided a test which is great, but how do we know it works for "real" > usages? I am pretty sure that Google is using this internally, but we are also going to work on QEMU and Libvirt support for this. As for the rest, thanks for the review---I'll let Jing act on it and only add my own remarks in a couple places. Paolo