From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5475C31A057 for ; Tue, 23 Sep 2025 10:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758623320; cv=none; b=bHQn6B+gNeydlzUwY/DVg17zUfkvkLIPbRW+fSoZnJqCO0edx1d/he2qKlDnk/sUgo5m40mrwbQD0uTRcdjegfePe37YrrxnI6Nah5PFKpc/G1dGGreTd+EVZo2psirhU3NJNVAGgEhl9Kcvw+/ntrf6KeZ6gkeDlBRgZ3/PXLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758623320; c=relaxed/simple; bh=qNsWtsZJmHIUb0a54dq/Zk97f1zSUhZRzo0hHxDMUiI=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=exBfnpYDS6LlfGVl1z2nfobupoGv4OlOkbikUyNd3nb3F9GEMkiOlG634iXWYKcDeGixfbvaUEBZq6ybJObqdl5DnKcBb/ny22pxNyrizi6OSX+uvrWnv2c6i27gqth6EnJV9BFAF7ny+Zq+TCBCs47GN2Hp6hk46B+IXXpgobA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IpumrUwR; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IpumrUwR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758623317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Seufh+9IrU9b2MywM8OU6QN1JILtHD4ZNUvycpU3ucM=; b=IpumrUwRT9AL6+WHKEhyAu2B7PRWuD6rGcZamC5W0ldj2ipU3hFXKdEsBVYkQf6/tw4Hun pD+pt3rOkAVvYHEINHLQAjzkGN6r2O1ycqiUHcHesYAJSshscGwj3iGgIfhWPVDA/1ofXO JceGc74qdJSsWzEvzfXbg8hDacAqoco= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-674-kZmjNMG-Nvq2EjMjEeRBSg-1; Tue, 23 Sep 2025 06:28:36 -0400 X-MC-Unique: kZmjNMG-Nvq2EjMjEeRBSg-1 X-Mimecast-MFC-AGG-ID: kZmjNMG-Nvq2EjMjEeRBSg_1758623315 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45f2a1660fcso44846695e9.1 for ; Tue, 23 Sep 2025 03:28:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758623315; x=1759228115; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Seufh+9IrU9b2MywM8OU6QN1JILtHD4ZNUvycpU3ucM=; b=u39PwyXvckIMbpxSLgvZ1o5Qh9E7TYWwK0lWXho07iDDeZrZwhr1MwWNG1ZsEnbqTw DecmGpAOhjap5rBxaYZ12fNQiUTQosSya79cfOnzROcwj09IsK/9eWStAmemWW+qlkAm fxM+E8vxnVLVjrFjcTqe0d++kwfJSoQPmzNPwgAtXCUn704hQqvkrPtCY+oLYquQPw8W RjmLKUHeVk4I7/1Ym2E9JFGu1U2SlXxmGJl8DBgoPFDY54MrSH9V+JnpjQoDLAg8nIjK cFuFMRgKMIWG2rWeAJNe79o0+eYQkkZNIPpjBaUdCL1MzOWWT4Y74F2cZI3aDv+Xy0WP gJgw== X-Forwarded-Encrypted: i=1; AJvYcCVrI02tgWr2WsFwYeerAH81ohG/Gzzjumsu6Jpy3gZvVxNYiISRGkfvNK39dPuRaXtCxnr+tXbCASwuHjTi6sM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywby5IJ+gg+Un86MndV3NxCqNEwByvo4OV9Q2k0at+O3bgNBBnt YTBEvNdE3ZifF1x7I1YJ/3xDGV6gTHEKWT/6dBCqgcwkF4YwE28YcYc80Xjr1TAdXYrNmh4bHSD IgF1Ld9/UqQ7SG+4WVfSC1kHkBfJ87HWuyxXUq0KfSOu7tLYjFHgraNXbhfIfRF194jt/5A== X-Gm-Gg: ASbGncuHA1vcn1tzY4FtRJ6tAspDdS5mmBqzif4SioinseG5aZlYX98woXeAswCE05k fjBfTogvVWUfXoqAa/0U4hAkyv2JeUHSzoSOaGFs9pX2IxApnU8cnONd8aDWjquNHtWKIPVirGM mo4uW3fy8vvzFBLqzOY2oiWLNoazTyc8kz7Pg12BOponUV5hnp9fLyoE6IgGTSZBH1OJ1SyeLKz +3hY02E0BAAv2J1ozMrI7FjG0xpgXd1hU9gf6YmZjTw8bUZTVIcnoeE4nFbD0L9LlgY7MrnfyrE BOUK3S4/rBBOCX6k79rxPLI/i/5f/M7i/VsdbjTa9K9l1RwyDYnDj8m1U8wrI4vlaAj7pS+el/U qYQ2IzWlrMLQb X-Received: by 2002:a05:600c:b8d:b0:459:d8c2:80b2 with SMTP id 5b1f17b1804b1-46e1d97d863mr18326985e9.7.1758623314760; Tue, 23 Sep 2025 03:28:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHE3y5Q9pntwixp7o35wbEMBOVoDHu4y0TA3ICCB6qjtMzYYpwTI3p/PfMW2g4Dp4vpzjkTQg== X-Received: by 2002:a05:600c:b8d:b0:459:d8c2:80b2 with SMTP id 5b1f17b1804b1-46e1d97d863mr18326795e9.7.1758623314348; Tue, 23 Sep 2025 03:28:34 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2712:7e10:4d59:d956:544f:d65c? ([2a0d:3344:2712:7e10:4d59:d956:544f:d65c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-464f0d8a2bfsm247445715e9.2.2025.09.23.03.28.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Sep 2025 03:28:33 -0700 (PDT) Message-ID: Date: Tue, 23 Sep 2025 12:28:31 +0200 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 net-next 11/14] tcp: accecn: fallback outgoing half link to non-AccECN To: chia-yu.chang@nokia-bell-labs.com, edumazet@google.com, linux-doc@vger.kernel.org, corbet@lwn.net, horms@kernel.org, dsahern@kernel.org, kuniyu@amazon.com, bpf@vger.kernel.org, netdev@vger.kernel.org, dave.taht@gmail.com, jhs@mojatatu.com, kuba@kernel.org, stephen@networkplumber.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net, liuhangbin@gmail.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, ij@kernel.org, ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com, g.white@cablelabs.com, ingemar.s.johansson@ericsson.com, mirja.kuehlewind@ericsson.com, cheshire@apple.com, rs.ietf@gmx.at, Jason_Livingood@comcast.com, vidhi_goel@apple.com References: <20250918162133.111922-1-chia-yu.chang@nokia-bell-labs.com> <20250918162133.111922-12-chia-yu.chang@nokia-bell-labs.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250918162133.111922-12-chia-yu.chang@nokia-bell-labs.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/18/25 6:21 PM, chia-yu.chang@nokia-bell-labs.com wrote: > diff --git a/include/net/tcp_ecn.h b/include/net/tcp_ecn.h > index 2256d2efa5ec..8317c3f279c9 100644 > --- a/include/net/tcp_ecn.h > +++ b/include/net/tcp_ecn.h > @@ -169,7 +169,10 @@ static inline void tcp_accecn_third_ack(struct sock *sk, > switch (ace) { > case 0x0: > /* Invalid value */ > - tcp_accecn_fail_mode_set(tp, TCP_ACCECN_ACE_FAIL_RECV); > + if (!TCP_SKB_CB(skb)->sacked) { > + tcp_accecn_fail_mode_set(tp, TCP_ACCECN_ACE_FAIL_RECV | > + TCP_ACCECN_OPT_FAIL_RECV); > + } Minor nit: brackets are not needed above. /P