From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Khalid Masum <khalid.masum.92@gmail.com>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>, Jonathan Corbet <corbet@lwn.net>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: Kunit: Use full path to .kunitconfig
Date: Wed, 28 Sep 2022 19:51:09 +0700 [thread overview]
Message-ID: <be928578-6453-5cf1-32da-322aebe2cee5@gmail.com> (raw)
In-Reply-To: <20220928040058.37422-1-khalid.masum.92@gmail.com>
On 9/28/22 11:00, Khalid Masum wrote:
> The numbered list contains full path to every files that need to be
> modified or created in order to implement misc-example kunit test.
> Except for .kunitconfig. Which might make a newcommer confused about
> where the file exists. Since there are multiple .kunitconfig files.
>
> Fix this by using the full path to .kunitconfig.
>
Better say:
```
The fourth list item on writing test cases instructs adding Kconfig
fragments to .kunitconfig, which should have been full path to the file
(.kunit/.kunitconfig).
```
> -4. Add the following lines to ``.kunitconfig``:
> +4. Add the following lines to ``.kunit/.kunitconfig``:
>
> .. code-block:: none
>
I think "Add the following lines" should be changed to something more
descriptive in regards to what these lines are about (which in this
case should be "Add following configuration fragments").
Thanks.
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2022-09-28 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 4:00 [PATCH] Documentation: Kunit: Use full path to .kunitconfig Khalid Masum
2022-09-28 5:07 ` David Gow
2022-09-28 12:51 ` Bagas Sanjaya [this message]
2022-09-29 8:35 ` Khalid Masum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be928578-6453-5cf1-32da-322aebe2cee5@gmail.com \
--to=bagasdotme@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=khalid.masum.92@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox