Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Antonio Quartulli <antonio@openvpn.net>,
	netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Donald Hunter <donald.hunter@gmail.com>,
	Shuah Khan <shuah@kernel.org>,
	sd@queasysnail.net, ryazanov.s.a@gmail.com,
	Andrew Lunn <andrew+netdev@lunn.ch>
Cc: Simon Horman <horms@kernel.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Xiao Liang <shaw.leon@gmail.com>,
	steffen.klassert@secunet.com, antony.antony@secunet.com,
	willemdebruijn.kernel@gmail.com, David Ahern <dsahern@kernel.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH net-next v25 00/23] Introducing OpenVPN Data Channel Offload
Date: Tue, 8 Apr 2025 08:34:27 +0200	[thread overview]
Message-ID: <bff01a88-1e5d-4855-b7d9-1b1ac4bed650@kernel.org> (raw)
In-Reply-To: <20250407-b4-ovpn-v25-0-a04eae86e016@openvpn.net>

On 07. 04. 25, 21:46, Antonio Quartulli wrote:
> Notable changes since v24:
> * disable TCP disconnections of attached sockets (tcp_disconnect()
>    returns -EBUSY) - similarly to kTLS.
> * used rcu_replace_pointer instead of rcu_dereference_protected+rcu_assign_pointer
> * dropped useless skb->ignore_df = 1
> * dropped unneded EXPORT_SYMBOL_GPL(udpv6_prot)
> * dropped obsolete comment for ovpn_crypto_key_slots_swap()
> * dropped calls to kfree() in ovpn_aead_encrypt/decrypt() (release is
>    performed in ovpn_encrypt/decrypt_post())
> * dropped NULL check before calling kfree() in
>    ovpn_encrypt/decrypt_done()
> * converted seq_num from atomic64_t to atomic_t (IV exhaustion is now
>    detected in case of wrap around)
> * call consume_skb() on skb when dropping keepalive message (it is not a
>    failure)
> * made REMOTE_PORT mandatory when REMOTE_IPV4/6 is specified in
>    peer_new/set call
> * ensured ovpn_nl_key_swap_notify() is called only once, even when
>    parsing a batch of received packets concurrently
> 
> Please note that some patches were already reviewed/tested by a few
> people. These patches have retained the tags as they have hardly been
> touched.
> 
> The latest code can also be found at:
> 
> https://github.com/OpenVPN/ovpn-net-next

Given:
 > +#define OVPN_FAMILY_NAME	"ovpn"
and
 > ctx->ovpn_dco_id = genl_ctrl_resolve(ctx->nl_sock, OVPN_FAMILY_NAME);

Is there also an openvpn branch understanding the new (in-kernel) 
naming? I.e. something like s/ovpn-dco-v2/ovpn/?

As with 2.6.10, I see:
$ grep -iE 'offl|dco' log
2025-04-08 08:24:59 us=718854 Note: Kernel support for ovpn-dco missing, 
disabling data channel offload.
2025-04-08 08:24:59 us=719060 OpenVPN 2.6.10 x86_64-suse-linux-gnu [SSL 
(OpenSSL)] [LZO] [LZ4] [EPOLL] [PKCS11] [MH/PKTINFO] [AEAD] [DCO]
2025-04-08 08:24:59 us=719110 DCO version: N/A

thanks,
-- 
js
suse labs


  parent reply	other threads:[~2025-04-08  6:34 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 19:46 [PATCH net-next v25 00/23] Introducing OpenVPN Data Channel Offload Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 01/23] net: introduce OpenVPN Data Channel Offload (ovpn) Antonio Quartulli
2025-04-10 17:51   ` ALOK TIWARI
2025-04-11  8:47     ` Antonio Quartulli
2025-04-11  2:54   ` Jakub Kicinski
2025-04-11  8:04     ` Antonio Quartulli
2025-04-11 13:50       ` Sabrina Dubroca
2025-04-11 21:18         ` Jakub Kicinski
2025-04-14 13:39           ` Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 02/23] ovpn: add basic netlink support Antonio Quartulli
2025-04-10 18:26   ` ALOK TIWARI
2025-04-11  2:58   ` Jakub Kicinski
2025-04-11  8:06     ` Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 03/23] ovpn: add basic interface creation/destruction/management routines Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 04/23] ovpn: keep carrier always on for MP interfaces Antonio Quartulli
2025-04-11  3:03   ` Jakub Kicinski
2025-04-11  8:38     ` Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 05/23] ovpn: introduce the ovpn_peer object Antonio Quartulli
2025-04-10 18:49   ` ALOK TIWARI
2025-04-07 19:46 ` [PATCH net-next v25 06/23] ovpn: introduce the ovpn_socket object Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 07/23] ovpn: implement basic TX path (UDP) Antonio Quartulli
2025-04-11  3:07   ` Jakub Kicinski
2025-04-11  8:46     ` Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 08/23] ovpn: implement basic RX " Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 09/23] ovpn: implement packet processing Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 10/23] ovpn: store tunnel and transport statistics Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 11/23] ovpn: implement TCP transport Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 12/23] skb: implement skb_send_sock_locked_with_flags() Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 13/23] ovpn: add support for MSG_NOSIGNAL in tcp_sendmsg Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 14/23] ovpn: implement multi-peer support Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 15/23] ovpn: implement peer lookup logic Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 16/23] ovpn: implement keepalive mechanism Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 17/23] ovpn: add support for updating local or remote UDP endpoint Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 18/23] ovpn: implement peer add/get/dump/delete via netlink Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 19/23] ovpn: implement key add/get/del/swap " Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 20/23] ovpn: kill key and notify userspace in case of IV exhaustion Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 21/23] ovpn: notify userspace when a peer is deleted Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 22/23] ovpn: add basic ethtool support Antonio Quartulli
2025-04-07 19:46 ` [PATCH net-next v25 23/23] testing/selftests: add test tool and scripts for ovpn module Antonio Quartulli
2025-04-08  6:34 ` Jiri Slaby [this message]
2025-04-08  7:37   ` [PATCH net-next v25 00/23] Introducing OpenVPN Data Channel Offload Antonio Quartulli
2025-04-10 14:03 ` Sabrina Dubroca
2025-04-10 14:16   ` Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bff01a88-1e5d-4855-b7d9-1b1ac4bed650@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=antonio@openvpn.net \
    --cc=antony.antony@secunet.com \
    --cc=donald.hunter@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ryazanov.s.a@gmail.com \
    --cc=sd@queasysnail.net \
    --cc=shaw.leon@gmail.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=steffen.klassert@secunet.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox