From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EAF5679FC for ; Mon, 22 Jan 2024 17:38:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705945134; cv=none; b=P4ewRPDcakpW/l6TNz6zP3J7BgAoknrRGRGv0jzFnqKvskEbEx47t758t/ZYAZKguxZApRt/XpO9tvF4DdaeB2IT5DBHw9KbMcprxyM+hoFy3Q3QgreWv3sd1iEHGEePvH8vK6L8NaplaP7h/EmQpjTAquIvssXDDnRbGAUEVO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705945134; c=relaxed/simple; bh=1agfQj91jKPuM03IvQvPn7FRroTkYhBE3Eyvb0JlhPs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jcgSZji4Bhk78I3XNDqoSAfp16AcZA9B0OUCQWrzocagwq7fUTvj4WHZRIaCl2QstsJ4v6w1MsFBaW43u3vc+SNnTs0DVMWqvuw/Z21LX1K2DdWn6stEcONnTX87nTLkv0kfFHOAM3NsKR+Gs0fg44+sO9ZC24Sm1GRANoqnJcI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZBoQERao; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZBoQERao" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-5cdf90e5cdeso510058a12.1 for ; Mon, 22 Jan 2024 09:38:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1705945133; x=1706549933; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XtjcrQsxe6bJ8QdGg7J5xA0F4dr3vWlDQohelUrXlB4=; b=ZBoQERaoSnk/Z9mTyIkwFGcoQwwGQQF1Fq7Yu4Ojofn9iy0XPuMROQqBdAfCGayqwV x85KBP5HVzHzFN85Feevls5DNb2lnpiWCPPP6ixSNfXozvgXUXfRwxjDNLPBpxvMfxH4 EJI24VFRApsGmcb5zZrx0FtgJMQTMJFEN/R0E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705945133; x=1706549933; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XtjcrQsxe6bJ8QdGg7J5xA0F4dr3vWlDQohelUrXlB4=; b=d5jROoTNGFGIGox6XHxAYYoH6n5FjGormFwt67UbvjidBTDxEHwvItu4mytnMkSEnJ zzfZtPQOekPsOw3Cnd9juRiEsk+XVTXtpazj870DsNMqBguBzJ8lC6V3MxGiNTy02uFn CMptjXFYSXhVxN2sK/t41pae4SIdCNR+VNikCVAWPrEBtKrnsdDDAHObZy7QQhv0qrSL aKv3CYXAC8iNGJQi7yGrHpLLmZPlX/MPZypqd/bWR+DHK/upBCwr5sKR5NEIbwW8iQkx g1zAoC7TXTj5yTnammoOYrKxUvpo4IPZEhysA8Ufj32xZKQYpGg8Bm/rqFhfoxJf6SjV jr7g== X-Gm-Message-State: AOJu0YwCFo+uJofDhbs7FCSuS/E4LylArDvxXAhp6u9q6TodURY1jTHB EezlbQ7rDdkLNuMpoXDM+A4mBRpcq8VKlE6YxawcKGNDCZsPHKJymsnMTJrdqK0= X-Google-Smtp-Source: AGHT+IGKsyRXEY3tO1H9OuYiUwsfj+vq0ROdCS8ekfKfxcvrR4RqapGfHOijT8aFHG7x9DfCyz47wA== X-Received: by 2002:a05:6a20:439f:b0:19a:efad:f1c3 with SMTP id i31-20020a056a20439f00b0019aefadf1c3mr12427542pzl.4.1705945132828; Mon, 22 Jan 2024 09:38:52 -0800 (PST) Received: from [128.240.1.152] ([206.170.126.10]) by smtp.gmail.com with ESMTPSA id kq9-20020a056a004b0900b006db85b12036sm9837515pfb.137.2024.01.22.09.38.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 09:38:52 -0800 (PST) Message-ID: Date: Mon, 22 Jan 2024 10:38:49 -0700 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/3] kselftests: lib.mk: Add TEST_GEN_MODS_DIR variable Content-Language: en-US To: Marcos Paulo de Souza , Shuah Khan , Jonathan Corbet , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Shuah Khan Cc: linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, live-patching@vger.kernel.org References: <20240112-send-lp-kselftests-v6-0-79f3e9a46717@suse.com> <20240112-send-lp-kselftests-v6-1-79f3e9a46717@suse.com> <5aceb855-2862-4d53-b27b-50e2956e099b@linuxfoundation.org> From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/22/24 10:37, Marcos Paulo de Souza wrote: > On Mon, 2024-01-22 at 10:15 -0700, Shuah Khan wrote: >> On 1/12/24 10:43, Marcos Paulo de Souza wrote: >>> Add TEST_GEN_MODS_DIR variable for kselftests. It can point to >>> a directory containing kernel modules that will be used by >>> selftest scripts. >>> >>> The modules are built as external modules for the running kernel. >>> As a result they are always binary compatible and the same tests >>> can be used for older or newer kernels. >>> >>> The build requires "kernel-devel" package to be installed. >>> For example, in the upstream sources, the rpm devel package >>> is produced by "make rpm-pkg" >>> >>> The modules can be built independently by >>> >>>    make -C tools/testing/selftests/livepatch/ >>> >>> or they will be automatically built before running the tests via >>> >>>    make -C tools/testing/selftests/livepatch/ run_tests >>> >>> Note that they are _not_ built when running the standalone >>> tests by calling, for example, ./test-state.sh. >>> >>> Along with TEST_GEN_MODS_DIR, it was necessary to create a new >>> install >>> rule. INSTALL_MODS_RULE is needed because INSTALL_SINGLE_RULE would >>> copy the entire TEST_GEN_MODS_DIR directory to the destination, >>> even >>> the files created by Kbuild to compile the modules. The new install >>> rule copies only the .ko files, as we would expect the gen_tar to >>> work. >>> >>> Reviewed-by: Joe Lawrence >>> Reviewed-by: Petr Mladek >>> Signed-off-by: Marcos Paulo de Souza >>> --- >>>   Documentation/dev-tools/kselftest.rst |  4 ++++ >>>   tools/testing/selftests/lib.mk        | 26 +++++++++++++++++++++- >>> ---- >> >> >> Hi Marcos, >> >> I would like the doc patch and lib.mk patch separate. If lib.mk needs >> changes >> we don't have to touch the doc patch. > > Hi Shuah, > on patch 2/3 you also said that you would like to have the > documentation changes split in the future, and that you picked the > changes into a testing branch. Does it also applies to this patch? > No need to do anything now. I just applied the series to linux-kselftest next thanks, -- Shuah