From: Shuah Khan <skhan@linuxfoundation.org>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Kees Cook" <kees@kernel.org>,
"Andy Lutomirski" <luto@amacapital.net>,
"Will Drewry" <wad@chromium.org>, "Shuah Khan" <shuah@kernel.org>,
"Sun Jian" <sun.jian.kdev@gmail.com>,
"Jakub Kicinski" <kuba@kernel.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] selftests: harness: Restore order of test functions
Date: Mon, 27 Apr 2026 11:46:46 -0600 [thread overview]
Message-ID: <c182a8fd-5eb3-4189-a552-884d4d94c626@linuxfoundation.org> (raw)
In-Reply-To: <20260422-kselftests-harness-order-v2-1-93ea980ea3ac@linutronix.de>
On 4/22/26 06:32, Thomas Weißschuh wrote:
> The recent addition of explicit constructor orders for fixture tests
> broke the ordering of those relative to non-fixture tests and the
> reverse-constructor-order detection.
>
> Restore the ordering of the test functions relative to each other by
> using the same explicit test order for all test registrations and
> __constructor_order_first().
>
> Rename the constant, as it is not specific to TEST_F() anymore.
>
> Fixes: 6be268151426 ("selftests/harness: order TEST_F and XFAIL_ADD constructors")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> Reviewed-by: Kees Cook <kees@kernel.org>
> ---
> Changes in v2:
> - Pick up review tag from Kees.
> - Add missing closing brace in FIXTURE_VARIANT_ADD().
> - Link to v1: https://patch.msgid.link/20260420-kselftests-harness-order-v1-1-b3c603782ce8@linutronix.de
> ---
Applied to linux-kselftest fixes for Linux 7.1-rc2
thanks,
-- Shuah
prev parent reply other threads:[~2026-04-27 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:32 [PATCH v2] selftests: harness: Restore order of test functions Thomas Weißschuh
2026-04-27 17:46 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c182a8fd-5eb3-4189-a552-884d4d94c626@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=shuah@kernel.org \
--cc=sun.jian.kdev@gmail.com \
--cc=thomas.weissschuh@linutronix.de \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox