From: Shuah Khan <skhan@linuxfoundation.org>
To: Reinette Chatre <reinette.chatre@intel.com>,
Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
fenghua.yu@intel.com, shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
ilpo.jarvinen@linux.intel.com, tony.luck@intel.com,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v8 0/2] selftests/resctrl: SNC kernel support discovery
Date: Tue, 14 Jan 2025 16:25:19 -0700 [thread overview]
Message-ID: <c1fd1a9a-ead7-4203-af55-5eeddef76f2d@linuxfoundation.org> (raw)
In-Reply-To: <9223d698-d16a-43c8-95c1-9839b81c2c23@intel.com>
On 1/14/25 15:30, Reinette Chatre wrote:
> Hi Shuah,
>
> On 12/19/24 10:35 AM, Reinette Chatre wrote:
>> Hi Shuah,
>>
>> On 12/16/24 7:18 AM, Maciej Wieczor-Retman wrote:
>>>
>>> Sub-Numa Clustering (SNC) allows splitting CPU cores, caches and memory
>>> into multiple NUMA nodes. When enabled, NUMA-aware applications can
>>> achieve better performance on bigger server platforms.
>>>
>>> SNC support was merged into the kernel [1]. With SNC enabled
>>> and kernel support in place all the tests will function normally (aside
>>> from effective cache size). There might be a problem when SNC is enabled
>>> but the system is still using an older kernel version without SNC
>>> support. Currently the only message displayed in that situation is a
>>> guess that SNC might be enabled and is causing issues. That message also
>>> is displayed whenever the test fails on an Intel platform.
>>>
>>> Add a mechanism to discover kernel support for SNC which will add more
>>> meaning and certainty to the error message.
>>>
>>> Add runtime SNC mode detection and verify how reliable that information
>>> is.
>>>
>>> Series was tested on Ice Lake server platforms with SNC disabled, SNC-2
>>> and SNC-4. The tests were also ran with and without kernel support for
>>> SNC.
>>>
>>> Series applies cleanly on kselftest/next.
>>>
>>
>> Could you please consider this series for inclusion?
>>
>> Thank you very much.
>>
>> Reinette
>>
>
> (bumping visibility of request made close to holidays)
>
> This series still applies cleanly to kselftest/next. Could you please
> consider it for inclusion?
>
> Thank you very much.
>
> Reinette
>
Thank you for bumping it up to top of my Inbox.
I will apply these for 6.14-rc1 now.
thanks,
-- Shuah
next prev parent reply other threads:[~2025-01-14 23:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 15:18 [PATCH v8 0/2] selftests/resctrl: SNC kernel support discovery Maciej Wieczor-Retman
2024-12-16 15:18 ` [PATCH v8 1/2] selftests/resctrl: Adjust effective L3 cache size with SNC enabled Maciej Wieczor-Retman
2024-12-16 21:43 ` Reinette Chatre
2024-12-16 15:18 ` [PATCH v8 2/2] selftests/resctrl: Discover SNC kernel support and adjust messages Maciej Wieczor-Retman
2024-12-19 18:35 ` [PATCH v8 0/2] selftests/resctrl: SNC kernel support discovery Reinette Chatre
2025-01-14 22:30 ` Reinette Chatre
2025-01-14 23:25 ` Shuah Khan [this message]
2025-01-14 23:28 ` Reinette Chatre
2025-01-14 23:58 ` Shuah Khan
2025-01-15 8:48 ` Maciej Wieczor-Retman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1fd1a9a-ead7-4203-af55-5eeddef76f2d@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox