From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.22 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794237666; b=P4zvnwYl8u8na03qC5EBevDQewRSNKfffJq3UrbLNhVECVrjg1jNt1zzAtte56wpcW5t AsaECUt8EfVAwp/r11/boKJG4ifXwQgIf+yGqVd6gfr1IXf4ejUsIhS3uL3vNHa3/SlS2 Z8Ja3Tj5RpjKfU/lZjYXiy70cSJzr3uTTneDhZuaKN5WNrzgZlrtKdZAtUvrfl8/TUm7s ZChMlvuPiFd+6KV/RFloTz/xpWLUHjM0IVUo4UzVUbnLVamEF0HoWAKQA9RAI1F2kUpIs eBKltP9Ly0J96+davc5nO+ajidjPR1OVq2FTZ9zQlmUj/OBtm2tuQGTKM335jk+0R7A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794237666; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=OEaMkvm58VQCFxWgZiNZttKo9RWAkrg2Jpi3EFl1TRY=; b=5mTSoFeYvCR6Z4kx79JvScm2uBAX7AUuxkwog3+Ck+9YKYMl9fxDzoUJZr5qqvo3ZuQ9 xa/J03QEPSC++LGgqrGcmcwLUL90AEpvKMWyTnM0qxG4Yo/NfazIsOPoT2BM8rXS7w6Ce 4rhgyKigUpiy40NgTeXtJjJvnw0toJjtPSZkNFH1VWPGzZPqEAbMTq38nQUX26rcC+zfU oSP+QClUGu0FjngiirFVGFwfyAGMJCHqPM7ZNcx6HlvoSF4jXLmDjdi+9qh66XDv+u3TX or1ZHXP1miwnWZPyT9RzIXsGXR1XN1yZ9THYaWmufZIfDHqu8ZIwWRyyfd2S5yqfgWQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=hzKzNuuk; arc=none smtp.remote-ip=91.218.175.22 Received: from mta0.migadu.com (out-22.mta0.migadu.com [91.218.175.22]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02C22606A338 for ; Mon, 9 Nov 2026 15:21:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 02C22606A338 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=hzKzNuuk X-Envelope-To: linux-kselftest@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=kKN1FrR88/XC1lM8GArCouvp/sFgokTYp7hs6x2CE6E=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794237661; v=1; x=1794842461; b=hzKzNuukR/bLfPSEESlfqIPRohJP6/oZvgw4/qj4TEKohZ4CqfAypR4+ThZoVCV2HrveS0kV IVm+EbUqTbnyTGkmYSjsTpbiwcR9ysoXMp8gOk0ovaRCKzbmqLLDSIGJtcNzZK3BL8YXhGLcw6u ruyRT6LdZJqOU4b+4KnrUMRc= X-Envelope-To: linux-kselftest@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 14f7012e0815e2fe; Mon, 09 Nov 2026 15:21:01 +0000 X-Mizu-Trace-ID: 14f7012e0815e2fe X-Migadu-Flow: FLOW_OUT Message-ID: Date: Mon, 9 Nov 2026 23:20:53 +0800 X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] cpuset: settle isolation state when CPUs are given back to parent To: Ridong Chen , Waiman Long , Tejun Heo , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Shuah Khan Cc: Chen Ridong , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Sashiko , Guopeng Zhang , Ridong Chen References: <20261107120100.3587595-1-ridong.chen@linux.dev> <20261107120100.3587595-4-ridong.chen@linux.dev> Content-Language: en-US From: Guopeng Zhang In-Reply-To: <20261107120100.3587595-4-ridong.chen@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 在 2026/11/7 20:00, Ridong Chen 写道: > From: Ridong Chen > > partition_xcpus_del() only updates isolated_cpus when the partition that > gives back the CPUs has a different state than its parent. CPUs that were > further distributed to descendant isolated partitions are not taken into > account, so isolated_cpus_release() has to be called afterwards in > several places to walk up the ancestors and fix isolated_cpus. > > Make partition_xcpus_del() always set the isolation state of the given > back CPUs to the state of the parent that receives them. As the > effective_xcpus of a partition covers the CPUs distributed to its > descendants, the isolation state of those CPUs is settled at the same > time. Boot-time isolated CPUs are still preserved by isolated_cpu_update(). > > compute_partition_effective_cpumask() invalidates a child partition > without going through partition_xcpus_del(), so do the same there: the > CPUs of the invalidated child take the isolation state of its parent. > > As the parent may be shrunk and its effective_xcpus not updated yet, > only do so for the CPUs the parent still owns. This is to keep the > isolation state correct for now, the in-place invalidation here will be > removed later in the partition rework. > > isolated_cpus_update() assumes the old and new states are different, > which no longer holds now that partition_xcpus_del() proceeds regardless > of the states. Drop its @old_prs argument and the WARN_ON_ONCE() so that > it simply sets the isolation state of the given CPUs, and use it > everywhere. The state check in partition_xcpus_add() is dropped as well, > as setting the state is a no-op when the states are the same. > > isolated_cpus_release() is no longer needed and is removed. > Hi Ridong, Would it be worth briefly mentioning in the commit message that this patch also fixes the issue described here? https://lore.kernel.org/all/20261105130344.664336-4-guopeng.zhang@linux.dev/ Thanks, Guopeng