From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 255322EE5E6 for ; Thu, 24 Jul 2025 20:29:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753388972; cv=none; b=swC0qX7Z9CYagZOtwM2jF7ZfhEGpujal+85iGIBfTr8AsAGdEgFu+4zscXN6vAvf/TMxk5V8Rv1vXq8KNaH85bLxfbaWRvfbReL9DPcXbR8c4D46wAxE+orTR2DPrgaJfoNg8tts5eFtwOGDXq8lSbtfBT/uYZqPc++T0CBGs0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753388972; c=relaxed/simple; bh=DzXVhulZGvTKq7BsPcMgg1dzeOqUZTXVxR/3MGaFMqs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=alv2qRheMFDynr4tgw5hYgJC+R0lfAFq36L57K8qozNGxOA2HIpWSFV4kEgFPeu9sZ4fZ7aUG4UsD9lx+f12pC6O4GadMELTdPGzZSW/2b9hFOxnTTqm9zD4zGFHoFqCaSTBbKQxTMVme0MayZfaULgjQqAaZnBd2O9TjNZB7nE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hTFd/QVp; arc=none smtp.client-ip=209.85.166.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hTFd/QVp" Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-3e2ab85e0b4so11253555ab.1 for ; Thu, 24 Jul 2025 13:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1753388970; x=1753993770; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+b9HQMUZxMpzyZdyEB0HK8P1uTOBEw1dpmm2/mfBx+Y=; b=hTFd/QVps/fK5UniKInwOayEt8b4D/HXqMHR5Uv2Ha7fGNmNGBvoA0SFuM91uefqNk 5BypDdsiFmmUjhB1n+vgpktxeGUjrt4Il368xVFbRt4lg/fyqsXmlB33fg6PYlW9qX2j mW10noLCXEYHg/nMUNHV3FWfVx51+HFq7XRrA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753388970; x=1753993770; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+b9HQMUZxMpzyZdyEB0HK8P1uTOBEw1dpmm2/mfBx+Y=; b=ivUEwQy1Q1reSwL/mMtAvs5+07NGhTbw2yiUpqCd4h3baq3bpaBnGi8JmwvJ5ydcqu eyHE453E0ttpT8XSZsRx7vj8v+aQDtdQ0USv8oVcwuBAMoa4KF3D8S2TFBSillKWtgsg dUCfUXRQdwMlnpbgs422Z9SO298FMuRR+YE1kL+ZyLoWbWuVUBREhSMjY2y+1NLfXPfB /NcJh6bGjQ7KPEHq9kM7bdIKEm/TH/MiyZFZmwwBvvhC8QNTWTeA+tiGFPnJcS9BmVLh 8wzQLryfUjyZM9soecP9IxVaEsa14nBnrUu/cS8foFvbhe89vim5pmq192tV6JbUzj5W uSGg== X-Forwarded-Encrypted: i=1; AJvYcCWWmsWaRt+WELFJ5vrr9ytCPkbVtQKSYgNvvNGSnqOn6lENP0ZSkThEKsLcNvXs8psZSDNVRz49aSImQToN7qA=@vger.kernel.org X-Gm-Message-State: AOJu0YwZKSuvRbtcOjFyRx61+Ui7k+o6Vn67yE0PGseAz3yNHCHbS1J0 MiuWxEwW69mWclkCsVAz/v7VJB6+N+qjt/k5vsck5GQ7NFLTBN1bk/D+qyY08gUtG0w= X-Gm-Gg: ASbGncvEpYa0xf5QQ5PbXhj4+CsOdjJBZiFa2eKEwR/HEUzVdZ9vlCKQF6ojZqCj+48 +BDiRnhp0fAqxBi8+c8d3sJQCpRIQwhGNFRV73cjsX0cU/fCOXA80j7qzhyI5Ag6LUAUl1Hw38y wnnjvae01tD/K89wdkamq8ZFkUFs3ifLJMHHQgJCz5wYRQAUg9SDIjCVkLjvRrBJaquqL5EEv6v QV/HU6oq4T9wsNsDdXhweBF5g69Wt9i2/tGuLEFPVt5+elUV6E88wYcnavs54t29Jw9+v5KY3wM QFlWYh8V6KQzoBulaQzDWhYjNDzs1bQ8VprLfUAp2fVz7wkcFzgnyAn5+mSZmINOgK2SmXVd/jp fr8ImMyvpeJ3KHdwVL5sEQBGS5/XoOFCubg== X-Google-Smtp-Source: AGHT+IFt92nHqkhxzj87qLRfizBmZ9YET/pL7elzT+vQNPvr7LxI858Hx4FdfyjRDKhqcEADcbyxpw== X-Received: by 2002:a05:6e02:168f:b0:3e2:84aa:f473 with SMTP id e9e14a558f8ab-3e3b979c998mr51075605ab.1.1753388970222; Thu, 24 Jul 2025 13:29:30 -0700 (PDT) Received: from [192.168.1.14] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3e3b723e927sm8214485ab.55.2025.07.24.13.29.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jul 2025 13:29:29 -0700 (PDT) Message-ID: Date: Thu, 24 Jul 2025 14:29:29 -0600 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests: firmware: Add details in error logging To: Harshal Wadhwa Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20250714212650.17935-1-embedkari167@gmail.com> <934dae5f-88af-41a3-9a0e-3aa5311b8f11@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/20/25 12:21, Harshal Wadhwa wrote: > On Mon, Jul 14, 2025 at 03:39:47PM -0600, Shuah Khan wrote: >> On 7/14/25 15:26, Harshal wrote: >>> Specify details in logs of failed cases >> >> How about changing the above to: >> >> Improve error messages adding details on failuires > Will change this in next patch > >>> fd = open(sys_path, O_WRONLY); >>> if (fd < 0) >>> - die("open failed: %s\n", >>> + die("open of sys_path failed: %s\n", >> >> Why not just use sys_path as a input parameter to die()? > Sure, that's great. Is there a way to test these changes ? The same way you tested your v2 patch? How did you test this patch? thanks, -- Shuah