From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E62C4363A for ; Mon, 26 Oct 2020 19:31:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E969F2085B for ; Mon, 26 Oct 2020 19:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603740718; bh=YRN24gDQxsNOo+heKWuV9wy/jnNWMkUsJpTKAtHfSsM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=LYj2OxahbjTvrzAPm3IA08SwmZdpIB/wQA08nuQRlnOIPHhJlox8ThG+l2n91SmBj dcNWthndJhPYbLrHzKcz8VVYp/tjUknCrc3z0lxj6ieCZcdo418F7Mw/yFjMByLO8j W9R76yLZ7p1Nt75eSG2a5geveZ5qtti3pLuzwmME= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1793120AbgJZTb5 (ORCPT ); Mon, 26 Oct 2020 15:31:57 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:42744 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1784780AbgJZTb5 (ORCPT ); Mon, 26 Oct 2020 15:31:57 -0400 Received: by mail-io1-f67.google.com with SMTP id k21so11416512ioa.9 for ; Mon, 26 Oct 2020 12:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mOk5XUEuchPEMU5r7mFZgJBEBGvQ35xr1MEWrB7Ojk0=; b=gypib57D2xJe9o/RDSKiXXI9ePiUvyB58fIXstW8rnCPwj0szv731X5HsVxnkuhr9y V37Yk+blnOJesZethVFog9u+FsxMKOZld1Va0u2xNxvbLL99ng5+DnsphHYt78WAPBd7 MqK0h9kT0rWMJ+6Bdg8/yM45VyfcKHyOiY7+s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mOk5XUEuchPEMU5r7mFZgJBEBGvQ35xr1MEWrB7Ojk0=; b=rj7kr8C40jq1d4VIe1YKLSLF/S5/5rAE3cAc0E96yDEWggI/pzHCcL/XgvXgSTBIOU nDgcswJlxk78FWaHtsLKJOzC1Yqp9qlxatbQVfLGuB7nHSYSPEGQbVN17E2p/3xlsZ4t lC0ExVDpI7bfY3VG4nXGraIdk0vh+IYy9ldF60revZsp4eoUqMthXKdPAmZnFLKe4Fzz G+AJOpUyJ1zzVUk+iJsWizzBBRSFDmUTqPtV9A/QTQU5KQSgOH+qkLDeeP0W6qPO8Kxg BzgqpV40ek5NVMDEm8v/K+4nLCddnxpPAWG8Dy/ZO+HqRNdlCY7vWKApAdzlwvD36QOo Jq2g== X-Gm-Message-State: AOAM530azQB1Z7EEXLLyTBjohe8ZNtAQpjyhLWvm25RduRBHBOAlwkXi /M0QppChCw0GmUegnBIQZAsJVQ== X-Google-Smtp-Source: ABdhPJyBDNdSHXxIVJ7vNq1XMkOY66Fk5QesPkw0wWus2ohanYGpi8QEDsuZu83kFo7iymAK4awFPw== X-Received: by 2002:a6b:f610:: with SMTP id n16mr11780704ioh.103.1603740716696; Mon, 26 Oct 2020 12:31:56 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id w11sm5933501iop.14.2020.10.26.12.31.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 12:31:56 -0700 (PDT) Subject: Re: [PATCH] kunit: Fix kunit.py --raw_output option To: Brendan Higgins , David Gow Cc: KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , Shuah Khan References: <20201022030455.1871987-1-davidgow@google.com> From: Shuah Khan Message-ID: Date: Mon, 26 Oct 2020 13:31:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 10/21/20 10:11 PM, Brendan Higgins wrote: > On Wed, Oct 21, 2020 at 8:05 PM David Gow wrote: >> >> Due to the raw_output() function on kunit_parser.py actually being a >> generator, it only runs if something reads the lines it returns. Since >> we no-longer do that (parsing doesn't actually happen if raw_output is >> enabled), it was not printing anything. >> >> Fixes: 45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate out config/build/exec/parse") You need just the SHA1 45ba7a893ad8 Fixed this up and applied to linux-kselftest kunit-fixes branch >> Signed-off-by: David Gow > > Thanks for fixing this! > > Reviewed-by: Brendan Higgins > Tested-by: Brendan Higgins > thanks, -- Shuah