Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Li Zhijian <lizhijian@fujitsu.com>,
	shuah@kernel.org, linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Donet Tom <donettom@linux.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH for-next v4] selftests/mm: Add a few missing gitignore files
Date: Mon, 25 Nov 2024 12:38:49 -0800	[thread overview]
Message-ID: <c737c8f8-5fd5-4acd-aba9-787009a8497c@nvidia.com> (raw)
In-Reply-To: <20241125064036.413536-1-lizhijian@fujitsu.com>

On 11/24/24 10:40 PM, Li Zhijian wrote:
> Compiled binary files should be added to .gitignore
> 'git status' complains:
>     Untracked files:
>     (use "git add <file>..." to include in what will be committed)
>           mm/hugetlb_dio
>           mm/pkey_sighandler_tests_32
>           mm/pkey_sighandler_tests_64
> 
> Cc: Donet Tom <donettom@linux.ibm.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Shuah Khan <shuah@kernel.org>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> ---
> Cc: linux-mm@kvack.org
> ---
> 
> Hey John,
> I added your Reviewed-by tag in this revision which have a minor
> updates. Feel free to let me know if you feel this is unsuitable.
> 
> Hello,
> Cover letter is here.
> 
> This patch set aims to make 'git status' clear after 'make' and 'make
> run_tests' for kselftests.
> ---
> V4:
> 
>    Use the exact filename to fix warning reported by lkp@intel.com
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202411251308.Vjm5MzVC-lkp@intel.com/
> V3:
>     nothing change, just resend it
>     (This .gitignore have not sorted, so I appended new files to the end)
> V2:
>    split as seperate patch from a small one [0]
>    [0] https://lore.kernel.org/linux-kselftest/20241015010817.453539-1-lizhijian@fujitsu.com/
> ---
>   tools/testing/selftests/mm/.gitignore | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index da030b43e43b..689bbd520296 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -51,3 +51,6 @@ hugetlb_madv_vs_map
>   mseal_test
>   seal_elf
>   droppable
> +hugetlb_dio
> +pkey_sighandler_tests_32
> +pkey_sighandler_tests_64

Makes sense. Yes, this still looks good.

thanks,
-- 
John Hubbard


      reply	other threads:[~2024-11-25 20:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-22  7:46 [PATCH for-next v3] selftests/mm: Add a few missing gitignore files Li Zhijian
2024-11-23  6:42 ` John Hubbard
2024-11-25  5:57 ` kernel test robot
2024-11-25  6:40 ` [PATCH for-next v4] " Li Zhijian
2024-11-25 20:38   ` John Hubbard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c737c8f8-5fd5-4acd-aba9-787009a8497c@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=donettom@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizhijian@fujitsu.com \
    --cc=lkp@intel.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox