From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CEA92E54D3 for ; Sat, 4 Apr 2026 17:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775325246; cv=none; b=drvviotZnF0Kenye8C/HS2KyjazkDdoTFvsik5sYqVUrg9+hZUrI7uUN0jRwaP2EYWZvt3mMokKEB+8ONO+XWODkPAVN+SEFXGjURIZQkGPQImgZoSDkPXJlzzcNc4vABJbCs/HN+2rk0XmsnJZNPNXBfQySh4evqicqvd/9lA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775325246; c=relaxed/simple; bh=Jet0kAWW8WbFobLI7q4QKFu+ZFv/bm7fTLwnpkiJZnA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kJSiE0Yy+WRYmAyGJFMX0IxSAyxL6/wTYckHEH2qYW5QrmgXguA00vbX6/oc8JRoCkFm8o8JZsemV7CWmPCEeYaJY8E83r2ato6JBy1J0GhpOSXrn0eqOVL0vAvQCy+PgID51ivCaK/gMBXlCpymIWoNFNButBVJLv3/E/4cg9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=mN8FEh5q; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="mN8FEh5q" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1775325232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D9/n0xOrVIg4JzXNz87bIfUmI/ls7SmA5Keb0MGw30A=; b=mN8FEh5qtk/m7/N1JG0dCSTSUfbBYtfsGQLC016NC56eKf8FDTo54FA5xQa6vXB7CU6IIE +/5t19o4gpNyK3Ns7deKkwEODR7xY81tgJM09f5N8YduC8lZjx73YRa/uKDjaQUGxB5pl0 ahysqUd6FYgcWlEVpEanB9b76mME9ZI= Date: Sat, 4 Apr 2026 10:53:47 -0700 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 2/6] selftests/liveupdate: add helper functions for memfd tests To: Pratyush Yadav , Pasha Tatashin , Mike Rapoport , Shuah Khan , Andrew Morton , Usama Arif Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20260404102452.4091740-1-pratyush@kernel.org> <20260404102452.4091740-3-pratyush@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: <20260404102452.4091740-3-pratyush@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 2026/4/4 3:24, Pratyush Yadav 写道: > From: "Pratyush Yadav (Google)" > > Add some helper functions that will be used by memfd tests. This moves > some of the complexity out of the test itself, which results in better > test readability and less code duplication. > > Reviewed-by: Mike Rapoport (Microsoft) > Signed-off-by: Pratyush Yadav > Signed-off-by: Pratyush Yadav (Google) > --- > .../selftests/liveupdate/luo_test_utils.c | 191 +++++++++++++++++- > .../selftests/liveupdate/luo_test_utils.h | 10 + > 2 files changed, 200 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/liveupdate/luo_test_utils.c b/tools/testing/selftests/liveupdate/luo_test_utils.c > index 3c8721c505df..ceb918ef9813 100644 > --- a/tools/testing/selftests/liveupdate/luo_test_utils.c > +++ b/tools/testing/selftests/liveupdate/luo_test_utils.c > @@ -1,8 +1,12 @@ > // SPDX-License-Identifier: GPL-2.0-only > > /* > - * Copyright (c) 2025, Google LLC. > + * Copyright (c) 2025-2026, Google LLC. > * Pasha Tatashin > + * Pratyush Yadav (Google) > + * > + * Copyright (C) 2025 Amazon.com Inc. or its affiliates. > + * Pratyush Yadav > */ > > #define _GNU_SOURCE > @@ -20,9 +24,194 @@ > #include > #include > #include > +#include > +#include > > #include "luo_test_utils.h" > > +int cwd_is_tmpfs(void) > +{ > + struct statfs buf; > + > + if (statfs(".", &buf) < 0) > + return -errno; > + > + return buf.f_type == TMPFS_MAGIC; > +} > + > +/* Read exactly specified size from fd. Any less results in error. */ > +int read_size(int fd, char *buffer, size_t size) > +{ > + size_t remain = size; > + ssize_t bytes_read; > + > + while (remain) { while (remain > 0) ? > + bytes_read = read(fd, buffer, remain); > + if (bytes_read == 0) > + return -ENODATA; > + if (bytes_read < 0) { > + if (errno == EINTR) > + continue; > + else > + return -errno; > + } > + > + remain -= bytes_read; > + buffer += bytes_read; > + } > + > + return 0; > +} > + > +/* Write exactly specified size from fd. Any less results in error. */ > +int write_size(int fd, const char *buffer, size_t size) > +{ > + size_t remain = size; > + ssize_t written; > + > + while (remain) { while (remain>0) is better? Zhu Yanjun > + written = write(fd, buffer, remain); > + if (written == 0) > + return -EIO; > + if (written < 0) { > + if (errno == EINTR) > + continue; > + else > + return -errno; > + } > + > + remain -= written; > + buffer += written; > + } > + > + return 0; > +} > + > +int generate_random_data(char *buffer, size_t size) > +{ > + int fd, ret; > + > + fd = open("/dev/urandom", O_RDONLY); > + if (fd < 0) > + return -errno; > + > + ret = read_size(fd, buffer, size); > + close(fd); > + return ret; > +} > + > +int save_test_data(const char *filename, const char *buffer, size_t size) > +{ > + int fd, ret; > + > + fd = open(filename, O_RDWR | O_CREAT | O_TRUNC, 0666); > + if (fd < 0) > + return -errno; > + > + ret = write_size(fd, buffer, size); > + fsync(fd); > + close(fd); > + return ret; > +} > + > +int load_test_data(const char *filename, char *buffer, size_t size) > +{ > + int fd, ret; > + > + fd = open(filename, O_RDONLY); > + if (fd < 0) > + return -errno; > + > + ret = read_size(fd, buffer, size); > + close(fd); > + return ret; > +} > + > +/* Create and initialize a memfd with random data. */ > +int create_random_memfd(const char *memfd_name, char *buffer, size_t size) > +{ > + int fd; > + int ret; > + > + fd = memfd_create(memfd_name, 0); > + if (fd < 0) > + return -errno; > + > + ret = generate_random_data(buffer, size); > + if (ret < 0) { > + close(fd); > + return ret; > + } > + > + ret = write_size(fd, buffer, size); > + if (ret < 0) { > + close(fd); > + return ret; > + } > + > + /* Reset file position to beginning */ > + if (lseek(fd, 0, SEEK_SET) < 0) { > + ret = -errno; > + close(fd); > + return ret; > + } > + > + return fd; > +} > + > +/* > + * Make sure fd contains expected data up to size. Returns 0 on success, 1 on > + * data mismatch, -errno on error. > + */ > +int verify_fd_content_read(int fd, const char *expected_data, size_t size) > +{ > + char *buffer; > + int ret; > + > + buffer = malloc(size); > + if (!buffer) > + return -ENOMEM; > + > + /* Reset file position to beginning */ > + if (lseek(fd, 0, SEEK_SET) < 0) { > + ret = -errno; > + goto out; > + } > + > + ret = read_size(fd, buffer, size); > + if (ret < 0) > + goto out; > + > + if (memcmp(buffer, expected_data, size) != 0) { > + ret = 1; > + goto out; > + } > + > + ret = 0; > + > +out: > + free(buffer); > + return ret; > +} > + > +/* > + * Verify fd content using mmap. Returns 0 on success, 1 on data mismatch, > + * -errno on error. > + */ > +int verify_fd_content_mmap(int fd, const char *expected_data, size_t size) > +{ > + char *mapped_mem; > + int ret; > + > + mapped_mem = mmap(NULL, size, PROT_READ, MAP_SHARED, fd, 0); > + if (mapped_mem == MAP_FAILED) > + return -errno; > + > + ret = memcmp(mapped_mem, expected_data, size) ? 1 : 0; > + munmap(mapped_mem, size); > + return ret; > +} > + > int luo_open_device(void) > { > return open(LUO_DEVICE, O_RDWR); > diff --git a/tools/testing/selftests/liveupdate/luo_test_utils.h b/tools/testing/selftests/liveupdate/luo_test_utils.h > index 90099bf49577..a69dce2649b0 100644 > --- a/tools/testing/selftests/liveupdate/luo_test_utils.h > +++ b/tools/testing/selftests/liveupdate/luo_test_utils.h > @@ -35,6 +35,16 @@ void restore_and_read_stage(int state_session_fd, int token, int *stage); > > void daemonize_and_wait(void); > > +int cwd_is_tmpfs(void); > +int read_size(int fd, char *buffer, size_t size); > +int write_size(int fd, const char *buffer, size_t size); > +int generate_random_data(char *buffer, size_t size); > +int save_test_data(const char *filename, const char *buffer, size_t size); > +int load_test_data(const char *filename, char *buffer, size_t size); > +int create_random_memfd(const char *memfd_name, char *buffer, size_t size); > +int verify_fd_content_read(int fd, const char *expected_data, size_t size); > +int verify_fd_content_mmap(int fd, const char *expected_data, size_t size); > + > typedef void (*luo_test_stage1_fn)(int luo_fd); > typedef void (*luo_test_stage2_fn)(int luo_fd, int state_session_fd); >