linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin KaFai Lau <martin.lau@linux.dev>
To: Taichi Nishimura <awkrail01@gmail.com>
Cc: andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
	davem@davemloft.net, deso@posteo.net, haoluo@google.com,
	hawk@kernel.org, joannelkoong@gmail.com,
	john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, llvm@lists.linux.dev,
	mykolal@fb.com, nathan@kernel.org, ndesaulniers@google.com,
	netdev@vger.kernel.org, sdf@google.com, shuah@kernel.org,
	song@kernel.org, trix@redhat.com, yhs@fb.com, ytcoode@gmail.com,
	rdunlap@infradead.org
Subject: Re: [PATCH v2] fixed typos on selftests/bpf
Date: Wed, 15 Feb 2023 10:21:44 -0800	[thread overview]
Message-ID: <c810373e-9fa5-9b2f-9425-af557c6dcbae@linux.dev> (raw)
In-Reply-To: <20230215032122.417515-1-awkrail01@gmail.com>

On 2/14/23 7:21 PM, Taichi Nishimura wrote:
> Hi Randy,
> 
> Thank you for your reviewing.
> I fixed costant and it's to constant and its, respectively.
> 
> Best regards,
> Taichi Nishimura
> 
> Signed-off-by: Taichi Nishimura <awkrail01@gmail.com>
> ---
>   tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/progs/test_cls_redirect.c b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> index a8ba39848bbf..66b304982245 100644
> --- a/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> +++ b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> @@ -610,8 +610,8 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
>    *
>    *    fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321)
>    *
> - * clang will substitute a costant for sizeof, which allows the verifier
> - * to track it's value. Based on this, it can figure out the constant
> + * clang will substitute a constant for sizeof, which allows the verifier
> + * to track its value. Based on this, it can figure out the constant

This does not apply. Ensure the diff is generated by git, and against the 
bpf-next tree. Please include everything in v1 also, resubmit and tag for 
bpf-next in the subject.


      parent reply	other threads:[~2023-02-15 18:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 15:28 [PATCH] fixed typos on selftests/bpf Taichi Nishimura
2023-02-14 16:44 ` Randy Dunlap
2023-02-15  3:21   ` [PATCH v2] " Taichi Nishimura
2023-02-15  3:25     ` Randy Dunlap
2023-02-15 18:21     ` Martin KaFai Lau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c810373e-9fa5-9b2f-9425-af557c6dcbae@linux.dev \
    --to=martin.lau@linux.dev \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=awkrail01@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=deso@posteo.net \
    --cc=haoluo@google.com \
    --cc=hawk@kernel.org \
    --cc=joannelkoong@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mykolal@fb.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sdf@google.com \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=trix@redhat.com \
    --cc=yhs@fb.com \
    --cc=ytcoode@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).