From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAF2C1487F4; Tue, 27 Aug 2024 08:22:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724746929; cv=none; b=QGSk6XV+/h+xLmskiEkQS/8i8EMmmUc8Oljx1UocpzaFeYgAQ0w5iU1dt+lKyjvknHFYwfNQkLkxLMOJa4LWlNSlG+uSXaU+ZT/B7n5dufZ6s3Ech/k3qUCiLdKHy1l1HLt4zkAfqvLqdbMI2M10rbfyzeUpky4cEBcU7FRCj7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724746929; c=relaxed/simple; bh=le44pt6W8v+kknNIOR3bDsF+5jHJup/kHuUmFbjIeV4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gon5A8myChNdGatj0WR7uIwj0ksyI+Am/ewu9WVtlB2mW2oxw8CGLJNCEiQ/7/tDfatAkQgwMpDs3j+3KwGO9aLDJYc1BgypTkBhO2NwwmPoVG+MzsLNw08PzyFpvEM2WFAOoM3L/zqDqxSm2O5Krhp+9lIQvM9WXYTsrkrmfFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZZbjEy8v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZZbjEy8v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D566CC58122; Tue, 27 Aug 2024 08:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724746928; bh=le44pt6W8v+kknNIOR3bDsF+5jHJup/kHuUmFbjIeV4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZZbjEy8vAcKORHbtsVHVq/Ek7nXokvMs5F9n4GRx4E3p5vHCRX2rPztYPefm+AAhI /TKF1uDiv2aRFX6rubfoa0UMd/vMAoS9qFAeJESuWMjvQSW7dD6ETab57vV0xaczvk 0KI6gVFy8uHFX4cgGyMIQShTNLWrUMM75e+3iHxjwcIilw3Dr/gx+5xpQcZ71pjhPE jxnUVq1iFwBHCkozSGR4u0oxjIBq7Hb282OlbN2eAONomzZbrCrUNJTeqXrbUApGv3 qz4DQYZpSSV2rzi44EupIGIWTGIuMhJefYuW0q6GIPnfpmfmRMRP4vbe2T8yyEdEWX o1QY6I7mdVSVg== Message-ID: Date: Tue, 27 Aug 2024 10:22:02 +0200 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH net 00/15] mptcp: more fixes for the in-kernel PM Content-Language: en-GB To: Jakub Kicinski Cc: mptcp@lists.linux.dev, Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Paolo Abeni , Shuah Khan , Florian Westphal , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, stable@vger.kernel.org, =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , syzbot+455d38ecd5f655fc45cf@syzkaller.appspotmail.com References: <20240826-net-mptcp-more-pm-fix-v1-0-8cd6c87d1d6d@kernel.org> <20240826192955.3dbb469d@kernel.org> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <20240826192955.3dbb469d@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Jakub, On 27/08/2024 04:29, Jakub Kicinski wrote: > On Mon, 26 Aug 2024 17:58:59 +0200 Matthieu Baerts (NGI0) wrote: >> Matthieu Baerts (NGI0) (15): >> mptcp: pm: reuse ID 0 after delete and re-add >> mptcp: pm: fix RM_ADDR ID for the initial subflow >> selftests: mptcp: join: check removing ID 0 endpoint >> mptcp: pm: send ACK on an active subflow >> mptcp: pm: skip connecting to already established sf >> mptcp: pm: reset MPC endp ID when re-added >> selftests: mptcp: join: check re-adding init endp with != id >> selftests: mptcp: join: no extra msg if no counter >> mptcp: pm: do not remove already closed subflows >> mptcp: pm: fix ID 0 endp usage after multiple re-creations >> selftests: mptcp: join: check re-re-adding ID 0 endp >> mptcp: avoid duplicated SUB_CLOSED events >> selftests: mptcp: join: validate event numbers >> mptcp: pm: ADD_ADDR 0 is not a new address >> selftests: mptcp: join: check re-re-adding ID 0 signal > > The debug runner is failing mptcp-join-sh fairly consistently with > these applied :( Thank you for this notification! It looks like the patch "selftests: mptcp: join: check re-re-adding ID 0 endp" is making the "delete and re-add" subtest longer: the connection finishes while the validation is still ongoing. I guess I didn't see this issue on my side, nor on MPTCP CI, because the Netdev CI is slower (SLUB_DEBUG_ON?). It is easy to fix, but I will wait for the other MPTCP series to be applied, before sending a v2. Cheers, Matt -- Sponsored by the NGI0 Core fund.