From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 159AA20A5D0 for ; Tue, 4 Feb 2025 12:29:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738672168; cv=none; b=APrC96JyYrN07nS9TnFC5hya0jZxwBjVGUVqaipfu5aTX7VNZWHFdONgfQvK27RWtv/AU4oihDn28USz8ocbU7TH3R4X4WPWjjiBBmrQH8ukFnw5z/LVq6TnGevxCUSs2+D/nVZfe8yjfSvFXPBc8V6MCenyNfWry1plNM+0fDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738672168; c=relaxed/simple; bh=u6K1gc6fqbQ9CyQmR1XZtEDc+/599QHfU81+5JM+XJg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hlKzGVq2TGZSxocziGQMIVls24S/yBKKR4zs+TJKMvrvwSDfOnaLuRURKAxBWj/bow9HCf0gsJiBzNeVeirDD2kvSO1KA/7vzgij5JxW2Q+paD4t8M6zQkTHC51stJUbLhTXlplu2HXPWt99kyvlqpclkqyXLGlqz6NU7Ap43xk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gpf4dkAg; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gpf4dkAg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738672164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SVt11t4VdzXmaGrVYonLKU4tNbyq45g4LumiKNuZLV8=; b=gpf4dkAgfZJjGroqrLhLo3yFumiFQAk31z5ESXLMhDdRsT+lQuGavqltxlpN/7zOUmC8nh aTwS84LAU+1deAaNSOI9AuQ2yVC1ACrk8zt+e2NXiwMKgha1x6qno/cGPZp+dWxl/+QdRm nlNcTk6Bf1bHEzcw+QtC4YaaxFYDY2o= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-170-qi1DhfM4MdSVY3VwEG3Tjw-1; Tue, 04 Feb 2025 07:29:22 -0500 X-MC-Unique: qi1DhfM4MdSVY3VwEG3Tjw-1 X-Mimecast-MFC-AGG-ID: qi1DhfM4MdSVY3VwEG3Tjw Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4361d4e8359so38993145e9.3 for ; Tue, 04 Feb 2025 04:29:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738672161; x=1739276961; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SVt11t4VdzXmaGrVYonLKU4tNbyq45g4LumiKNuZLV8=; b=t1NA0BtbnpI8Sg3PN1qNTaw8Nm66I0zw5vL2SUbJsbOb2kw33que1fI1AN53F7/jau lY6HKbETwb1v8RtVQkdfeHrZwIv7D71j/mVdaf8JetWmsMm0IJoLUSKeDQiAIHAnXkYJ yX1vd+ICydwK91FjDaxUs+HvfR4CB4hYhrZGGcELv9XdoijRDsb7aGqksKntFLppjwcU vBM54tKU9sCCKFXY7lm4yIq231KIVwARmKghhrhMSwG9giqfa0X6Bvq8rZ9xiJdMBt0l ENbwOwV6KCnHmj4C9/3GQH21Vm/xs50OZ3Xopp8IS0l3OFrA5fV3i0plCgGdxlj6rx4c rPTg== X-Forwarded-Encrypted: i=1; AJvYcCUrP1Tbbe67sKUrURQwCKLo6vrxd6OySRcZBqp/sXXQswteBK4ZfXYOscRI7bJAiBMQS0VaebbK0yLo835PVZY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyip9Xirt7RgZ/rJjbEmMxjz++VL4Xu/HrUpWf8M7AoPFi6MKk/ VJVshVmEqoZwAOz801Puio1GPb7A2JXfLDsyJSf3gzpOvnyNUQt32hrFf0yzZ3m8DmBzAm7Etyr 2kwFeo7oCRGHjfoD2cmWkx+jkUe1C/dOKIImgaW9EhvPsccWUfaI915xTGSdDZlFIHA== X-Gm-Gg: ASbGncvbVDrm6ubX05U4XQ9GVUzqw1WXJ3d/7qPxCkFWDgBcpEbPsFBEwMqNBWg+qcv 6QnDKVbW+21zwUf+ZgYhX5uS3d7fFl7D5Z8CzhzBnF1ZJv2SXQVTzaszw52b4AIHPqVGKgYqgCM 6f29z9yIvzS8YcrIbZeBg88eA7/CADka/al2yrWqsolgyf20GDOP2I1vK8P+jSBlQ6kCjv1/GeY aTBSf709N5yuNvZtJDT68AW5/+4IzjVLzvW9n8jmkz0yXLRexnSHKq45MHrhxotpwRXctCmhdRL k8eJ3Orq/RGHgZtniqRLbnLa50Z4/zv8fOM= X-Received: by 2002:a05:600c:5248:b0:435:32e:8270 with SMTP id 5b1f17b1804b1-438dc3cac3cmr242156365e9.14.1738672161580; Tue, 04 Feb 2025 04:29:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IF6sf3mUWx9f6oCktAawZ1NkGZse1Cb+QiEWr0dnqS8PjvhkiCOef50Jj0CTOWCanLTCjNSYQ== X-Received: by 2002:a05:600c:5248:b0:435:32e:8270 with SMTP id 5b1f17b1804b1-438dc3cac3cmr242156005e9.14.1738672161191; Tue, 04 Feb 2025 04:29:21 -0800 (PST) Received: from [192.168.88.253] (146-241-41-201.dyn.eolo.it. [146.241.41.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438dcc8a59dsm228847985e9.40.2025.02.04.04.29.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Feb 2025 04:29:20 -0800 (PST) Message-ID: Date: Tue, 4 Feb 2025 13:29:18 +0100 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 2/6] selftests: ncdevmem: Implement devmem TCP TX To: Mina Almasry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kselftest@vger.kernel.org Cc: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Simon Horman , Jonathan Corbet , Andrew Lunn , Neal Cardwell , David Ahern , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Stefan Hajnoczi , Stefano Garzarella , Shuah Khan , sdf@fomichev.me, asml.silence@gmail.com, dw@davidwei.uk, Jamal Hadi Salim , Victor Nogueira , Pedro Tammela , Samiullah Khawaja References: <20250203223916.1064540-1-almasrymina@google.com> <20250203223916.1064540-3-almasrymina@google.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250203223916.1064540-3-almasrymina@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/3/25 11:39 PM, Mina Almasry wrote: > Add support for devmem TX in ncdevmem. > > This is a combination of the ncdevmem from the devmem TCP series RFCv1 > which included the TX path, and work by Stan to include the netlink API > and refactored on top of his generic memory_provider support. > > Signed-off-by: Mina Almasry > Signed-off-by: Stanislav Fomichev Usually the self-tests are included towards the end of the series, to help reviewers building-up on previous patches knowledge. > .../selftests/drivers/net/hw/ncdevmem.c | 300 +++++++++++++++++- > 1 file changed, 289 insertions(+), 11 deletions(-) Why devmem.py is not touched? AFAICS the test currently run ncdevmem only in server (rx) mode, so the tx path is not actually exercised ?!? /P