From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83CC3C49ED7 for ; Mon, 16 Sep 2019 16:18:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5648B21881 for ; Mon, 16 Sep 2019 16:18:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568650724; bh=pywK1wFWvJV/TiAUcs6evxRAXvFRCHuSPueIlpKBJY0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=z3V66t/PQkMnApXCclb5LhD0Kdnj0VNljVibx6iB3y/AqcWxxzCcMJuxYHG04N86M uNKegjh1uAvSWv/Y1mtUJ8wlPygPVT3pnQftSo2Cgo95WthiwSeDrxoaQLhbAFIia3 /oRf4ccA1X4SlLN4ODV+Thw3pI5EkAvcBv8KgKt0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726055AbfIPQSo (ORCPT ); Mon, 16 Sep 2019 12:18:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:56242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725850AbfIPQSn (ORCPT ); Mon, 16 Sep 2019 12:18:43 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4ABC20678; Mon, 16 Sep 2019 16:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568650723; bh=pywK1wFWvJV/TiAUcs6evxRAXvFRCHuSPueIlpKBJY0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=1EZOs0aBVRlFkJotNJfHiLyD+xl0RnVTDqXAEmbInqulXtZC2zgdIavcUa81rakFa 95dmLWusMKqWp3Eoj4xF2JHZtcMEJdEsx5T1qDj3EaytbXf9EqtORZt3vf71aB/0/I M4kRhZx4ynD+XduyyPJG7P5atKInNon6J/XSuZd0= Subject: Re: [PATCH v2] selftests: fix prepending $(OUTPUT) to $(TEST_PROGS) To: Ilya Leoshkevich Cc: linux-kselftest@vger.kernel.org, Heiko Carstens , Vasily Gorbik , shuah References: <20190910121813.45742-1-iii@linux.ibm.com> From: shuah Message-ID: Date: Mon, 16 Sep 2019 10:18:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190910121813.45742-1-iii@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 9/10/19 6:18 AM, Ilya Leoshkevich wrote: > The current logic prepends $(OUTPUT) only to the first member of > $(TEST_PROGS). Use $(addprefix) to prepend it to each member. > Can you please send me the error messages you are seeing so I can see what is being fixed. > Also, $(OUTPUT) is assumed to end with a / almost everywhere else in > the kernel, make this the case for kselftest as well. Why are these two changes in one patch? Does this fix 1a940687e424? If so how? > > Fixes: 1a940687e424 ("selftests: lib.mk: copy test scripts and test files for make O=dir run") > Signed-off-by: Ilya Leoshkevich > --- thanks, -- shuah