From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C93214E2DB; Wed, 27 Mar 2024 20:13:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711570408; cv=none; b=VN9Jk2rwdZ2Emyju4APnUxIiKF4L7azPlotqqwK6aB2TzY11ivhRQuu1K2SR/Jd+hjuWf+8BH6jXWEx2vsRugzNU8VowvyXexw98vZ8p/Mh7dlMlIoTxzXyzkupbivTuZftFOsHQ+cZXSIjtc1CI2jiQuUgG9+NGB+rTK1yzEYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711570408; c=relaxed/simple; bh=kH3qgcziafB9PRru5e9dw4ePUTKVWnjog4AJOkah2g4=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=GPlMfgfXwz0R1hpM/C1KuKfcgwOwYMNO9SEVm9EfVvb4AW0Ip5wztnJg7fRdtuVoq9y+rUkg9jmm0EKAWmg8Pi8ocFVDRmqLeIn+Jdm36YOclrmuonwOOCkEQPXfzgnWVWP3gVyX1dOf8f7XJRr79RPiPqCrQqdPamo2M3ejgIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=XWV3o/On; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="XWV3o/On" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1711570398; bh=kH3qgcziafB9PRru5e9dw4ePUTKVWnjog4AJOkah2g4=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=XWV3o/On0ufZZmO+RH7OA6H6e8GKH/ZyKQo5NhDZerpcWmifTveYtnO7AThQZRBQV S6tdjM01n0q6SnwzERfKs1BsrNfx1+vziFeA7HkXACoNEHNFygqtNIK00nTaBMWDIX EQ4Oyt91zto1I/k4xLYiWHBYPoOs1BxN1dJa2d9iP9XKhGQ1MJvjFqMG2OPmDuf1+G tE/sjT+fWPNuqIQ6qRGUtZfqslgImvJOvjexHi5grB7xtq//Ao8pAZTb/6Yuyimusy kNn5he9tI1mdmLVtIz9tbQFxrVYaJ6+d2Km05H6Usn7x6WUoO66p4R1eHPfqdGDm/x x2qs2PZ0TqbXA== Received: from [100.113.15.66] (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 6D0E437804B2; Wed, 27 Mar 2024 20:13:15 +0000 (UTC) Message-ID: Date: Thu, 28 Mar 2024 01:13:45 +0500 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , Nicolin Chen , kernel@collabora.com, iommu@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Kevin Tian , Shuah Khan Subject: Re: [PATCH] selftests: iommu: add config needed for iommufd_fail_nth Content-Language: en-US To: Jason Gunthorpe , Joao Martins References: <20240325090048.1423908-1-usama.anjum@collabora.com> <31fcc276-acd6-4277-bd6c-4a871c7fb28a@collabora.com> <20240326150340.GE8419@ziepe.ca> <56cc8b9e-c1cf-4520-ba45-b1237e8b7b64@collabora.com> <20240327114958.GG8419@ziepe.ca> <51f493a9-08e7-44d8-ae4a-58b2994ea276@oracle.com> <20240327182050.GA1363414@ziepe.ca> From: Muhammad Usama Anjum In-Reply-To: <20240327182050.GA1363414@ziepe.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/27/24 11:20 PM, Jason Gunthorpe wrote: > On Wed, Mar 27, 2024 at 06:09:37PM +0000, Joao Martins wrote: >> On 27/03/2024 17:49, Muhammad Usama Anjum wrote: >>> On 3/27/24 7:59 PM, Joao Martins wrote: >>>> On 27/03/2024 11:49, Jason Gunthorpe wrote: >>>>> On Wed, Mar 27, 2024 at 03:14:25PM +0500, Muhammad Usama Anjum wrote: >>>>>> On 3/26/24 8:03 PM, Jason Gunthorpe wrote: >>>>>>> On Tue, Mar 26, 2024 at 06:09:34PM +0500, Muhammad Usama Anjum wrote: >>>>>>>> Even after applying this config patch and following snippet (which doesn't >>>>>>>> terminate the program if mmap doesn't allocate exactly as the hint), I'm >>>>>>>> finding failed tests. >>>>>>>> >>>>>>>> @@ -1746,7 +1748,7 @@ FIXTURE_SETUP(iommufd_dirty_tracking) >>>>>>>> assert((uintptr_t)self->buffer % HUGEPAGE_SIZE == 0); >>>>>>>> vrc = mmap(self->buffer, variant->buffer_size, PROT_READ | PROT_WRITE, >>>>>>>> mmap_flags, -1, 0); >>>>>>>> - assert(vrc == self->buffer); >>>>>>>> + assert(vrc == self->buffer);// ??? >>>>>>>> >>>>>>>> On x86: >>>>>>>> # Totals: pass:176 fail:4 xfail:0 xpass:0 skip:0 error:0 >>>>>>>> On ARM64: >>>>>>>> # Totals: pass:166 fail:14 xfail:0 xpass:0 skip:0 error:0 >>>>>>>> >>>>>>>> The log files are attached. >>>>>>> >>>>>>> You probably don't have enough transparent huge pages available to the process >>>>>>> >>>>>>> echo 1024 > /proc/sys/vm/nr_hugepages >>>>>> After making huge pages available, the iommufd test always passed on x86. >>>>>> But there are still failures on arm64. I'm looking into the failures. >>>>> >>>>> Oh that is really strange. Joao? Nicolin? >>>>> >>>> Definitely strange, I'll have a look. >>>> >>>> So it set the expected number of dirty bits as that assert doesn't fail, but it >>>> is failing when we check that even bits are set but not odd ones. Like it's >>>> hasn't set those bits. >>>> >>>> For mock tests there should be no difference between x86 and ARM assuming the >>>> typical 4K page-size. Maybe this is 64k base pages in ARM? That's the only thing >>>> that I can think of that affected mock domain. >>> The config is attached. The defaults are being used i.e., 4k page. >> >> Looks like CONFIG_IOMMUFD_DRIVER is not defined :( >> >> Thus no bits are being set. > > Oh! > > --- a/drivers/iommu/iommufd/Kconfig > +++ b/drivers/iommu/iommufd/Kconfig > @@ -37,6 +37,7 @@ config IOMMUFD_TEST > depends on DEBUG_KERNEL > depends on FAULT_INJECTION > depends on RUNTIME_TESTING_MENU > + select IOMMUFD_DRIVER > default n > help > This is dangerous, do not enable unless running > Tested this patch on my system and it fixes all issues for ARM64. Please add tag for this Kconfig patch: Tested by: Muhammad Usama Anjum Also please accept the patch in this current series. > > ??? > > Jason -- BR, Muhammad Usama Anjum