From: Shuah Khan <skhan@linuxfoundation.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>, linux-kselftest@vger.kernel.org
Cc: Florian Weimer <fweimer@redhat.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: vDSO: align getrandom states to cache line
Date: Tue, 1 Oct 2024 08:32:40 -0600 [thread overview]
Message-ID: <ccee6dd8-7bac-495a-8e76-481cebf88e3b@linuxfoundation.org> (raw)
In-Reply-To: <20240929025620.2056732-1-Jason@zx2c4.com>
On 9/28/24 20:55, Jason A. Donenfeld wrote:
> This prevents false sharing, which makes a large difference on machines
> with several NUMA nodes, such as on a dual socket Intel(R) Xeon(R) Gold
> 6338 CPU @ 2.00GHz, where the "bench-multi" test goes from 2.7s down to
> 1.9s. While this is just test code, it also forms the basis of how folks
> will wind up implementing this in libraries, so we should implement this
> simple cache alignment improvement here.
>
> Suggested-by: Florian Weimer <fweimer@redhat.com>
> Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
Thank you. Applied linux-kselftest fixes for next rc.
thanks,
-- Shuah
prev parent reply other threads:[~2024-10-01 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 2:55 [PATCH] selftests: vDSO: align getrandom states to cache line Jason A. Donenfeld
2024-10-01 14:32 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccee6dd8-7bac-495a-8e76-481cebf88e3b@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=Jason@zx2c4.com \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox