From: Shuah Khan <skhan@linuxfoundation.org>
To: Hubert Mazur <hmazur@google.com>, Shuah Khan <shuah@kernel.org>,
Jihed Chaibi <jihed.chaibi.dev@gmail.com>
Cc: Slawomir Rosek <srosek@google.com>,
Lukasz Majczak <lmajczak@google.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v1 1/1] selftests/cpu-hotplug: Make the script complaint with sh shell
Date: Tue, 31 Mar 2026 15:52:32 -0600 [thread overview]
Message-ID: <cd22b0b8-1e1c-4442-b4e4-5d7a6303ce4d@linuxfoundation.org> (raw)
In-Reply-To: <20260318080825.3063959-2-hmazur@google.com>
On 3/18/26 02:08, Hubert Mazur wrote:
> The script uses by default the bash shell that is inaccessible in
> the x86 embedded devices. This leads to the syntax errors. To mitigate
some x86 embedded devices - which ones?
> this, change the interpreter to /bin/sh and properly assign the
> FUNCNAME variable for each of the functions as 'sh' doesn't set this
> env. Change the conditional check for being a root from not
> existent UID and replace with command execution "id -u".
Please include errors in the change log
>
> Signed-off-by: Hubert Mazur <hmazur@google.com>
> ---
> tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
thanks,
-- Shuah
next prev parent reply other threads:[~2026-03-31 21:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 8:08 [PATCH v1 0/1] Make the script complaint with 'sh' shell Hubert Mazur
2026-03-18 8:08 ` [PATCH v1 1/1] selftests/cpu-hotplug: Make the script complaint with sh shell Hubert Mazur
2026-03-31 21:52 ` Shuah Khan [this message]
2026-04-01 11:56 ` Hubert Mazur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd22b0b8-1e1c-4442-b4e4-5d7a6303ce4d@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=hmazur@google.com \
--cc=jihed.chaibi.dev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lmajczak@google.com \
--cc=shuah@kernel.org \
--cc=srosek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox