From: Geliang Tang <geliang@kernel.org>
To: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: Geliang Tang <tanggeliang@kylinos.cn>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 0/6] skip ENOTSUPP for BPF selftests
Date: Fri, 05 Jul 2024 10:40:57 +0800 [thread overview]
Message-ID: <cd2a5ee33b5c4168ef74069527063daa8f05b733.camel@kernel.org> (raw)
In-Reply-To: <cover.1720075006.git.tanggeliang@kylinos.cn>
On Thu, 2024-07-04 at 14:48 +0800, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> BPF selftests seem to have not been fully tested on Loongarch
> platforms.
> There are so many "ENOTSUPP" (-524) errors when running BPF selftests
> on
> them since lacking BPF trampoline on Loongarch.
>
> For these "ENOTSUPP" tests, it's better to skip them, instead of
> reporting
> some "ENOTSUPP" errors. This patchset skips ENOTSUPP in ASSERT_OK/
> ASSERT_OK_PTR/ASSERT_GE helpers to fix them. This is useful for
> running BPF
> selftests for other architectures too.
Superseded. v2 is just sent out.
Thanks,
-Geliang
>
> Geliang Tang (6):
> selftests/bpf: Define ENOTSUPP in testing_helpers.h
> selftests/bpf: Skip ENOTSUPP in ASSERT_OK
> selftests/bpf: Use ASSERT_OK to skip ENOTSUPP
> selftests/bpf: Null checks for link in bpf_tcp_ca
> selftests/bpf: Skip ENOTSUPP in ASSERT_OK_PTR
> selftests/bpf: Skip ENOTSUPP in ASSERT_GE
>
> .../selftests/bpf/prog_tests/bpf_tcp_ca.c | 20 +++++++++-------
> .../testing/selftests/bpf/prog_tests/d_path.c | 2 +-
> .../selftests/bpf/prog_tests/lsm_cgroup.c | 10 +-------
> .../selftests/bpf/prog_tests/module_attach.c | 2 +-
> .../selftests/bpf/prog_tests/ringbuf.c | 2 +-
> .../selftests/bpf/prog_tests/sock_addr.c | 4 ----
> .../selftests/bpf/prog_tests/test_bprm_opts.c | 2 +-
> .../selftests/bpf/prog_tests/test_ima.c | 2 +-
> .../selftests/bpf/prog_tests/trace_ext.c | 2 +-
> tools/testing/selftests/bpf/test_maps.c | 4 ----
> tools/testing/selftests/bpf/test_progs.h | 24 ++++++++++++++---
> --
> tools/testing/selftests/bpf/test_verifier.c | 4 ----
> tools/testing/selftests/bpf/testing_helpers.h | 4 ++++
> 13 files changed, 41 insertions(+), 41 deletions(-)
>
prev parent reply other threads:[~2024-07-05 2:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 6:48 [PATCH 0/6] skip ENOTSUPP for BPF selftests Geliang Tang
2024-07-04 6:48 ` [PATCH 1/6] selftests/bpf: Define ENOTSUPP in testing_helpers.h Geliang Tang
2024-07-04 6:48 ` [PATCH 2/6] selftests/bpf: Skip ENOTSUPP in ASSERT_OK Geliang Tang
2024-07-04 6:48 ` [PATCH 3/6] selftests/bpf: Use ASSERT_OK to skip ENOTSUPP Geliang Tang
2024-07-04 6:48 ` [PATCH 4/6] selftests/bpf: Null checks for link in bpf_tcp_ca Geliang Tang
2024-07-04 6:48 ` [PATCH 5/6] selftests/bpf: Skip ENOTSUPP in ASSERT_OK_PTR Geliang Tang
2024-07-04 6:48 ` [PATCH 6/6] selftests/bpf: Skip ENOTSUPP in ASSERT_GE Geliang Tang
2024-07-08 18:56 ` Andrii Nakryiko
2024-07-05 2:40 ` Geliang Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd2a5ee33b5c4168ef74069527063daa8f05b733.camel@kernel.org \
--to=geliang@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tanggeliang@kylinos.cn \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox