From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: undisclosed-recipients:;
Subject: Re: [PATCH][next] selftests/bpf: Fix spelling mistake "succesful" -> "successful"
Date: Wed, 17 Aug 2022 20:00:44 +0100 [thread overview]
Message-ID: <ce90b1a4-777f-9cd7-48bc-7d85150d8dcc@gmail.com> (raw)
In-Reply-To: <818C5CC9-31CA-4DED-90E8-455B03AA9352@fb.com>
On 17/08/2022 19:46, Mykola Lysenko wrote:
> Hi Colin,
>
> Thanks for your patch!
>
> Can you change patch title to "[PATCH bpf-next] selftests/bpf: Fix spelling mistake "succesful” (kfunc_call.c)”?
Personally I think the kfunc_call.c part in the title is extraneous,
it's clear it's patching that file from the diff and it's not the style
I've used of the 3,900+ patches I've had accepted in the kernel.
Colin
>
> Regards,
> Mykola
>
>> On Aug 17, 2022, at 1:34 AM, Colin Ian King <colin.i.king@gmail.com> wrote:
>>
>> !-------------------------------------------------------------------|
>> This Message Is From an External Sender
>>
>> |-------------------------------------------------------------------!
>>
>> There is a spelling mistake in an ASSERT_OK literal string. Fix it.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> ---
>> tools/testing/selftests/bpf/prog_tests/kfunc_call.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/bpf/prog_tests/kfunc_call.c b/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
>> index 351fafa006fb..eede7c304f86 100644
>> --- a/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
>> +++ b/tools/testing/selftests/bpf/prog_tests/kfunc_call.c
>> @@ -109,7 +109,7 @@ static void test_destructive(void)
>> {
>> __u64 save_caps = 0;
>>
>> - ASSERT_OK(test_destructive_open_and_load(), "succesful_load");
>> + ASSERT_OK(test_destructive_open_and_load(), "successful_load");
>>
>> if (!ASSERT_OK(cap_disable_effective(1ULL << CAP_SYS_BOOT, &save_caps), "drop_caps"))
>> return;
>> --
>> 2.37.1
>>
>
prev parent reply other threads:[~2022-08-17 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 8:34 [PATCH][next] selftests/bpf: Fix spelling mistake "succesful" -> "successful" Colin Ian King
2022-08-17 18:46 ` Mykola Lysenko
2022-08-17 19:00 ` Colin King (gmail) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce90b1a4-777f-9cd7-48bc-7d85150d8dcc@gmail.com \
--to=colin.i.king@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox