From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4E8BC4363A for ; Tue, 27 Oct 2020 21:55:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 747AA20829 for ; Tue, 27 Oct 2020 21:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603835735; bh=2qwy85GE+/JaiI6RW0WwNHrTep9L507uI0d3hoZTB+o=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=g/1BFlIx8dE4gKPAMApUOznutUFbDtpYPgP57VP7nDsvBt66sJbS1AZi2gXm4D0Hu DHT3+J4ex5TAuw1IxDPnZs6b/CGbgPNcvEAhGNua5GwwSIrV0eWF/1a8QQhbMtgklx ItbXJOt5kbfcNdgGWsJsQwoUK9q1b8CE2imICKdo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S374657AbgJ0Vzf (ORCPT ); Tue, 27 Oct 2020 17:55:35 -0400 Received: from mail-il1-f196.google.com ([209.85.166.196]:37603 "EHLO mail-il1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S374656AbgJ0Vzf (ORCPT ); Tue, 27 Oct 2020 17:55:35 -0400 Received: by mail-il1-f196.google.com with SMTP id y17so2913485ilg.4 for ; Tue, 27 Oct 2020 14:55:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lgKSCb5c9tdTkF5QdAPCpCA9DpL5KH988jr8fE7us3c=; b=fXEsD4d3KHbwjy0Hy7AOYfmlTutjASNHaqDSuDAP/mkXXgOS7eZ0sgGYNtvvD0nLSn 1v2NL+sdlQ5mD7k5IkU6gS3f2ETZo3ZQgS+3MfCv5HkyYidCUGtZusRzrYBnXO19GDkD +cood94qqgOzQw57psef08614etVetRd4PM9I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lgKSCb5c9tdTkF5QdAPCpCA9DpL5KH988jr8fE7us3c=; b=Mh6k5c/fKR4LDdDv70pRNFnSgkgV4WmsUrbsDYWq+6A5/LK8QffvM+nLKfs+jsjSxc OZTdeI2+ssDAchX0OmL+QV3RHYYHAS7bHbaPZeQ7WFI+SmEraQC0AhE2k7s1esAu86QS bLjQ/chCSotYbfW7zE8/txd6K+/2koTfAwyBN66CH6bcBtmaX1fIWVRHaWNC1vsvGF06 D0IRpMjj+4HOUEq5TkKFp5CCjySPXq2D2EV5kI696W7Z68sbHVRF/7Yj+Of2p4m3VcXE K/FH/9b95JKUgmXQwmcj0Per2NYFkfHGqRA1rJKkKamhgXUoKir/OBNgzF7zMqk9WG9G V9xw== X-Gm-Message-State: AOAM533xbiS7MBSOVi8nT/MZeo3joRH0LPx1u5fOItcE80NFieiAP1tj MWoF98Vt6aPY3jrny8fFfPmwuw== X-Google-Smtp-Source: ABdhPJzmC1cbguyZPZtlPtoJsAGQaNltsHYTu67efw7/gCtEowygE8ptitCW3/02DXT/NydkLPM70A== X-Received: by 2002:a92:41c6:: with SMTP id o189mr3745351ila.261.1603835733784; Tue, 27 Oct 2020 14:55:33 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id p17sm1498718ilh.34.2020.10.27.14.55.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 14:55:32 -0700 (PDT) Subject: Re: [PATCH] selftests/ftrace: remove _do_fork() leftovers To: Steven Rostedt , Alexander Gordeev Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Brauner , Masami Hiramatsu , Shuah Khan , Shuah Khan References: <1603443123-17457-1-git-send-email-agordeev@linux.ibm.com> <20201023093523.65c495f8@gandalf.local.home> <20201023151243.GA1537@oc3871087118.ibm.com> <20201023114948.6900aa68@gandalf.local.home> <20201023115111.1c0e8768@gandalf.local.home> From: Shuah Khan Message-ID: Date: Tue, 27 Oct 2020 15:55:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201023115111.1c0e8768@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 10/23/20 9:51 AM, Steven Rostedt wrote: > On Fri, 23 Oct 2020 11:49:48 -0400 > Steven Rostedt wrote: > >> On Fri, 23 Oct 2020 17:12:44 +0200 >> Alexander Gordeev wrote: >> >>>> Perhaps we should have: >>>> >>>> # older kernels have do_fork, but newer kernels have kernel_clone >>>> echo kernel_clone >> set_ftrace_filter || echo *do_fork >> set_ftrace_filter >>> >>> Would you suggest to do the same with all occurences in >>> eea11285dab3 ("tracing: switch to kernel_clone()")? >>> Otherwise it does not really make sense to just fix couple >>> of tests out of dozens. >> >> Yes. I haven't pulled in the updated tests, so I haven't hit the errors yet >> (nor have I merged my work with the switch to the new name yet). So those >> will most definitely break my tests. >> >> But because it's a more generic issue, we should have a way to find what to >> use. Perhaps add to the test.d/functions, something like: >> >> FUNCTION_FORK=`(if grep '\bkernel_clone\b' /proc/kallsyms > /dev/null; then >> echo kernel_clone; else echo '_do_fork'; fi)` >> >> and use $FUNCTION_FORK everywhere that references it. >> >> > > Let me pull in the latest changes, and whip up a patch that works on both > the older kernels as well as the newer ones. > > -- Steve > Assume this is handled by selftests/ftrace: Use $FUNCTION_FORK to reference kernel fork function https://patchwork.kernel.org/project/linux-kselftest/patch/20201026162032.124c728d@gandalf.local.home/ Just making sure. thanks, -- Shuah