Re: [PATCH v2] selftests/futex: Fix storing address of local variable

["André Almeida" <andrealmeid@igalia.com>]

Hi Ankit,

Em 18/11/2025 14:08, Ankit Khushwaha escreveu:
> In "child_circular_list()" address of local variable ‘lock_struct a’
> is assigned to "" raising the following warning.
> 
> robust_list.c: In function ‘child_circular_list’:
> robust_list.c:522:24: warning: storing the address of local variable ‘a’
> in ‘head.list.next’ [-Wdangling-pointer=]
> 
>    522 |         head.list.next = &a.list;
>        |         ~~~~~~~~~~~~~~~^~~~~~~~~
> robust_list.c:513:28: note: ‘a’ declared here
>    513 |         struct lock_struct a, b, c;
>        |                            ^
> robust_list.c:512:40: note: ‘head’ declared here
>    512 |         static struct robust_list_head head;
>        |                                        ^~~~
> 
> removing the static keyword of "head" to fix this.
> 

This should be "Remove the static..." as noted in the kernel documentation:

"Describe your changes in imperative mood, e.g. “make xyzzy do frotz” 
instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to 
do frotz”, as if you are giving orders to the codebase to change its 
behaviour."

Please have a look on this page here: 
https://www.kernel.org/doc/html/latest/process/submitting-patches.html