From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=158.69.130.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795115238; b=HQFx0wfgB7nZHh+6bC4gAwEzlTDR2SuFuMg/7MPFbM5WdstNj7JeK6kY7GpHdKYUH+dO LjODtckkljCPBjlpUCzqMQ0dGgZbS0tIYQ+amup68eV27dpgvtTJ12BTlASFrcWz34aRp YwRuCvGmJ8zQ+KC1FLnFJ30dSH4yI/UaD2xP8L6oZSzCMlJV5SH9XSrrwXzyJ3tkSBkjy KnbwxKSKQRMFeQX9Cgx9S70bBgdH4n7MaErxnDBhIk/RvpgNk8Yk+gZQmnMwLknHDBg9y JbOW70LS+ahV/nOYClXcArDFzBD6e4HDiHOTjCfALjsdBmnOF4xdcHc2Dah9YzjpjIA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795115238; h=DMARC-Filter:DKIM-Signature:Received:From:To:Cc:Subject:Date: Message-Id:X-Mailer:MIME-Version:Content-Transfer-Encoding; bh=JvmaGGSdKnuuLlmu2GlrcS8+RsAinmKQuwyGniHvs0E=; b=RSW8h9wC6hRvtBFQDf6GqkxqEpm9SUQfQQcanSngfhG9KmFblrCZOdKa2iSAu58qKqpe 48hTK9QwJZ0EMmUezX8fZ+AEnu9efn9G1tEsHmoLX6PvEwPyDzB1FxJxZw4HQ7fJd96Wz rS6cUCjohmUm8RbDjq8wBJi8++aCtomJ6P6qFs8iiQ6W9KzShAKkov2jOD1BdBwFBWfRs RrXYHi2uAF8Qf67FmkoDMgUW1cXv28oY3TgYy9XLSRtJn5UjmcMI1C/+D1jSHC0ACgdaR S9kKzzaCfHlNPiJ5BjNv+XCCJIh2aBLBZQezBZOcJdhwzbY4ltlipzA0jEbzrldUGqA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=MAgNh6eQ; arc=none smtp.remote-ip=158.69.130.18 Received: from smtpout.efficios.com (smtpout.efficios.com [158.69.130.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08C94606A32C; Thu, 19 Nov 2026 19:07:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 08C94606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=MAgNh6eQ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=smtpout1; t=1795115237; bh=JvmaGGSdKnuuLlmu2GlrcS8+RsAinmKQuwyGniHvs0E=; h=From:To:Cc:Subject:Date:From; b=MAgNh6eQVI4SCunr5bajxEoaXWtGjv6NePB2qxJLJsoVlj36Sdb/tKfl68B+77hVT GnC5xsol/txt4HQOkNJtJ1Lb52WX7ZqlRbi7K9CPo4LYbNiZQPSOG3uk0rhcbhkO7y LZxD5f0PhnR0YQGC5fRIa7oJkzcATrsyh86BCAlWV4Vwues2n6v4jUP80dGbC799+3 0/yy5HPnaFT0C4R378pZRLJBYGp7o9j6BohJBg/aJbXmvfSbtJ3nlhQnrW+dsk/GKg a/BEi12bDtH1kTL13OsFxv52uEAKO6rMU+iQOIZEYbRggMi9VII4f/IpT+i+DgrtYK 1H0BB6ZCvhT/g== Received: from thinkos.internal.efficios.com (mtl.efficios.com [216.120.195.104]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4jVnyr6hygzS7f; Thu, 19 Nov 2026 14:07:16 -0500 (EST) From: Mathieu Desnoyers To: juri.lelli@redhat.com, peterz@infradead.org, mingo@redhat.com, vincent.guittot@linaro.org Cc: Mathieu Desnoyers , tglx@kernel.org, will@kernel.org, boqun@kernel.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com, luca.abeni@santannapisa.it, mathieu.poirier@linaro.org, longman@redhat.com, ridong.chen@linux.dev, tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com, shuah@kernel.org, bigeasy@linutronix.de, clrkwllms@kernel.org, parri.andrea@gmail.com, m.szyprowski@samsung.com, kayracizmeci@gmail.com, weihengqiuu@gmail.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rt-devel@lists.linux.dev Subject: [PATCH v5 00/17] sched/deadline: first bandwidth accounting fixes and selftests Date: Thu, 19 Nov 2026 14:06:57 -0500 Message-Id: X-Mailer: git-send-email 2.39.5 X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Ingo, Juri, This series fixes 14 bugs of SCHED_DEADLINE. Then it shows the deadline bandwidth of each runqueue in sched_debug, and adds two selftests. The fixes come first, so that stable can take patches 1 to 14. Two of the bugs take the kernel down: a division by zero (patch 4), and an owner's CPU that locks up (patch 8). One leaves cpuset_mutex locked (patch 6). One leaves a task that never runs again (patch 7). Most of the others leave total_bw of a root domain, or this_bw of a runqueue, wrong. The root domain then admits deadline tasks beyond its capacity, or refuses every one. These are the first 14 patches of "sched/deadline: bandwidth accounting fixes and selftests" v7 [1], as Juri proposed [2]. Their v7 numbers are 1-8, 10, 13, 14, 16, 20 and 37. The rest of v7 will follow as v8 of that series, on top of this one. Patch 10 was posted alone [3]. Juri asked to carry it here. It comes before patch 11, which adds a caller of the computation it fixes. v4 and v5 change it, as described below. Patch 12 is Juri's, patch 14 is Andrea Parri's. I carry them unchanged. Sebastian reviewed patch 14. Juri, three of your four fixes that Ingo dropped from sched/urgent are here: - 2/4 is patch 11. - 3/4 is patch 1. - 4/4 is patch 12. 1/4 stays in the second series. The fixes ========= 1 Refuse SCHED_FLAG_KEEP_PARAMS requests that would change the policy or the class. 2 Skip admission for parameters that SCHED_FLAG_KEEP_PARAMS keeps. 3 Let a task boosted by a deadline waiter change its policy. 4 Do not divide by zero active CPUs of a root domain. 5 Refuse a dl_server debugfs write while the runqueue is offline. 6 Take cpuset_mutex for a deadline policy change only with pi, so that sysrq-n does not leave it locked. 7 Replenish a throttled task switched out and back, so that it runs again. 8 Do not refill a boost from cleared parameters, so that the owner's CPU no longer locks up. 9 Reset the deadline and the runtime with the parameters. 10 Compute the 0-lag time on 128 bits, so that a long period does not release the bandwidth seconds late. Check first that the quotient fits in 64 bits. If it does not, release the bandwidth at once. 11 Release the bandwidth of a task that leaves the class asleep. 12 Reject SCHED_DEADLINE on exited tasks (Juri Lelli). 13 Keep this_bw right when a task changes during a remote wakeup. 14 Check the affinity of a deadline task under the runqueue lock, so that sched_setaffinity() and sched_setattr() cannot both succeed (Andrea Parri). Patch 15 shows the deadline bandwidth of each runqueue in sched_debug. Patch 16 adds deadline_switch_test. Patch 17 adds deadline_bw_test, with the 47 of its 115 cases that pass with these fixes. The other cases come with their fixes, in the second series. Testing ======= The 52 cases pass wherever they run, with lockdep and no kernel warning, in 25 QEMU guests: - 9 guests of 8 vCPUs, one with proxy execution off, and 1 of 4 vCPUs. - 5 guests with PREEMPT_RT, 4 of 8 vCPUs and 1 of 4. - 3 guests without CONFIG_CPUSETS, of 4, 4 and 5 vCPUs. - 4 guests of 5 vCPUs booted with isolcpus=domain,1,2 or isolcpus=domain,0,1, 2 of them with PREEMPT_RT. - 1 guest of 8 vCPUs booted with isolcpus=domain,6,7. - 2 guests with CONFIG_RT_GROUP_SCHED, of 8 and 4 vCPUs. move_cancelled runs only with CONFIG_RT_GROUP_SCHED. Without CONFIG_CPUSETS, the cases that need a cpuset skip. With 3 CPUs that are not isolated, params_waking skips: it needs 4. On v7.4-rc2, six cases of deadline_bw_test fail in each of 24 guests of 8 vCPUs, in three runs. Patch 17 lists them. params_switched_asleep, new in v4, failed in the 8 guests of the third run. overrun_caught fails in 5 guests. In one, hotplug_server crashed the kernel with the division by zero that patch 4 fixes. throttled_round_trip and asleep_round_trip of deadline_switch_test fail too. The third run also had the sysrq cases. sysrq_normalize failed in every guest. sysrq-n logged "BUG: sleeping function called from invalid context", from a mutex taken in __sched_setscheduler(). Patch 6 fixes this. Each of the 15 kernel patches builds alone. The whole series also builds without CONFIG_CPUSETS, with PREEMPT_RT and with CONFIG_RT_GROUP_SCHED. The selftests build with no warning. Juri ran v2 with cgroup v1 cpusets, and with the scx_simple sched_ext scheduler [4]. With sched_ext, the server cases of deadline_bw_test failed: they set the fair server, which sched_ext detaches. A change below makes them use the ext server. It was not tested with sched_ext. Not tested either: CPUs of unequal capacity. How this was developed ====================== An LLM coding assistant wrote these patches, their messages and the tests, under my direction and review. It did not write patches 12 and 14. I know the concepts behind SCHED_DEADLINE, but not its implementation well. So I ask those who know this code for a careful reading of the fixes. A reproducer that stops failing shows that the symptom goes away. It does not show that the fix is the one you would have written. The bugs came from: - flaky cgroup selftests of a feature I am developing; - the review of Juri's four fixes, and his review of v5 of the original series; - building deadline_bw_test, and reading the code; - the Sashiko AI reviews of v1 to v7 of the original series, and of v1 to v4 of this one. Each finding was checked against the code first. Changes since v4 ================ - 10, from the Sashiko AI review of v4. My reply gives the bounds [6]. After an overrun, the runtime is negative. Say root raises the period limit to about an hour. A CPU stall of a few seconds could then push the quotient of the 0-lag time past S64_MAX. On x86-64, a longer stall would trap. The bandwidth is now released at once in that case. The comment no longer says that the quotient always fits. Changes since v3 ================ - 10, from the Sashiko AI review of v3. On x86-64, mul_u64_u64_div_u64() traps with a divide error when the quotient does not fit in 64 bits. After a change of parameters, the runtime left can be far above dl_runtime. With the period limit raised, v3 oopsed in task_non_contending() in an x86-64 guest. Before the division, task_non_contending() now compares the runtime left with what the parameters give until the deadline. A comment explains the 0-lag time after a change of parameters. Juri preferred this to a change of the formula. This is the separate change promised in reply to the Sashiko review of v2 [5]. - 17: two new cases, params_switched_asleep and params_shrunk_long_period, test patch 10. The modes and variables that only the cases of the second series use are removed, from the Sashiko AI review of v3. Changes since v2 ================ - 10 is new: "sched/deadline: Fix an overflow of the 0-lag time with long periods", posted alone before [3]. - 11: the known limit of the v2 cover moves into its message, with the impact Juri gave. - 17, from the Sashiko AI review of v2 and Juri's testing: - deboost_new_params_reboost moves to the second series. On this series, it passes without the deboost it tests. - The flag of the lock shared by the death cases is in shared memory. Each case runs in its own child process. - server_states skips when P cannot run SCHED_FIFO tasks. This is the case with CONFIG_RT_GROUP_SCHED and the cpu controller on. - While a sched_ext scheduler runs all fair tasks, the server cases use the ext server, and hotplug_server skips. Changes since v1 ================ >From the Sashiko AI review of v1, in deadline_bw_test: - rebuild_record_taken moves to the second series. It tests a fix of that series, and fails without it when CPU 0 is isolated. - move_cancelled runs from the root cgroup. It turns the cpu controller off at the end only if it turned it on. - Its setter thread is joined after a timeout too, and its result is atomic. - The shared lock of the death cases is made consistent and destroyed before it is set up again. - A failed probe fails the case, in hotplug_server, move_refused and move_zero_bw. Based on tip sched/urgent, ec6f6731538e (v7.4-rc2). [1] https://lore.kernel.org/all/cover.1794922146.git.mathieu.desnoyers@efficios.com/ [2] https://lore.kernel.org/all/av3J3zMfkRplg-N4@jlelli-thinkpadt14gen4.remote.csb/ [3] https://lore.kernel.org/all/cover.1794926626.git.mathieu.desnoyers@efficios.com/ [4] https://lore.kernel.org/all/av7NchMg0wnyzjcd@jlelli-thinkpadt14gen4.remote.csb/ [5] https://lore.kernel.org/all/8282556f-a7bc-4950-b7a7-b5b78557412e@efficios.com/ [6] https://lore.kernel.org/all/4aa1c606-e569-4f46-8a05-f5c7be3b4365@efficios.com/ v1: https://lore.kernel.org/all/cover.1795031605.git.mathieu.desnoyers@efficios.com/ v2: https://lore.kernel.org/all/cover.1795037078.git.mathieu.desnoyers@efficios.com/ v3: https://lore.kernel.org/all/cover.1795092090.git.mathieu.desnoyers@efficios.com/ v4: https://lore.kernel.org/all/cover.1795105408.git.mathieu.desnoyers@efficios.com/ Andrea Parri (1): sched/deadline: Check SCHED_DEADLINE affinity under the rq lock Juri Lelli (1): sched/deadline: Reject SCHED_DEADLINE on exited tasks Mathieu Desnoyers (15): sched: Refuse SCHED_FLAG_KEEP_PARAMS that would change the policy or the class sched/deadline: Do not admit bandwidth for parameters that are kept sched: Let a task boosted by a deadline waiter change its policy sched/deadline: Do not divide by zero active CPUs of a root domain sched/deadline: Refuse dl_server debugfs writes while the rq is offline sched: Take cpuset_mutex for a deadline policy change only with pi sched/deadline: Do not lose a throttled task switched out and back sched/deadline: Do not replenish a boost from cleared parameters sched/deadline: Reset the deadline and the runtime with the parameters sched/deadline: Fix an overflow of the 0-lag time with long periods sched/deadline: Release the bandwidth of a task that leaves the class asleep sched/deadline: Fix this_bw when a task is changed during a remote wakeup sched/debug: Show the deadline bandwidth of each runqueue selftests/sched: Add a test of SCHED_DEADLINE policy round trips selftests/sched: Add a test of SCHED_DEADLINE bandwidth accounting include/linux/sched.h | 5 + kernel/sched/core.c | 11 + kernel/sched/deadline.c | 176 +- kernel/sched/debug.c | 13 +- kernel/sched/sched.h | 1 + kernel/sched/syscalls.c | 103 +- tools/testing/selftests/Makefile | 1 + .../selftests/sched/deadline/.gitignore | 2 + .../testing/selftests/sched/deadline/Makefile | 8 + tools/testing/selftests/sched/deadline/config | 5 + .../sched/deadline/deadline_bw_test.c | 4960 +++++++++++++++++ .../sched/deadline/deadline_switch_test.c | 1115 ++++ .../testing/selftests/sched/deadline/settings | 1 + 13 files changed, 6364 insertions(+), 37 deletions(-) create mode 100644 tools/testing/selftests/sched/deadline/.gitignore create mode 100644 tools/testing/selftests/sched/deadline/Makefile create mode 100644 tools/testing/selftests/sched/deadline/config create mode 100644 tools/testing/selftests/sched/deadline/deadline_bw_test.c create mode 100644 tools/testing/selftests/sched/deadline/deadline_switch_test.c create mode 100644 tools/testing/selftests/sched/deadline/settings base-commit: ec6f6731538e0d45872eb279fdeb477bed152d6f -- 2.47.3