public inbox for linux-kselftest@vger.kernel.org
 help / color / mirror / Atom feed
* Sashiko.dev for kselftest
@ 2026-04-01 19:51 Shuah
  2026-04-01 20:34 ` Roman Gushchin
  0 siblings, 1 reply; 3+ messages in thread
From: Shuah @ 2026-04-01 19:51 UTC (permalink / raw)
  To: Roman Gushchin; +Cc: shuah, linux-kselftest

Hi Roman,

Please add linux-kselftest list to sashiko.dev for reviews.

There might be double coverage for patches cc'ed to lkml
and other lists such as mm, net, bpf etc. Hope that won't
cause problems.

thanks,
-- Shuah



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Sashiko.dev for kselftest
  2026-04-01 19:51 Sashiko.dev for kselftest Shuah
@ 2026-04-01 20:34 ` Roman Gushchin
  2026-04-01 23:35   ` Shuah Khan
  0 siblings, 1 reply; 3+ messages in thread
From: Roman Gushchin @ 2026-04-01 20:34 UTC (permalink / raw)
  To: Shuah; +Cc: linux-kselftest, sashiko

Shuah <shuah@kernel.org> writes:

Hi Shuah,

Sure, will add later today.

> Hi Roman,
>
> Please add linux-kselftest list to sashiko.dev for reviews.
>
> There might be double coverage for patches cc'ed to lkml
> and other lists such as mm, net, bpf etc. Hope that won't
> cause problems.

It's not a problem at all.

What I believe might be a problem: kselftests are mostly userspace
code and at least some parts are written somewhat loosely (which
is totally fine for tests), so Sashiko will report a ton of issues,
many of them are not worth fixing.

So I guess it will be good to put down a kselftest-specific prompt with
some guidance what we believe is acceptable in tests code and what's not.

Thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Sashiko.dev for kselftest
  2026-04-01 20:34 ` Roman Gushchin
@ 2026-04-01 23:35   ` Shuah Khan
  0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2026-04-01 23:35 UTC (permalink / raw)
  To: Roman Gushchin, Shuah; +Cc: linux-kselftest, sashiko, Shuah Khan

On 4/1/26 14:34, Roman Gushchin wrote:
> Shuah <shuah@kernel.org> writes:
> 
> Hi Shuah,
> 
> Sure, will add later today.
> 
>> Hi Roman,
>>
>> Please add linux-kselftest list to sashiko.dev for reviews.
>>
>> There might be double coverage for patches cc'ed to lkml
>> and other lists such as mm, net, bpf etc. Hope that won't
>> cause problems.
> 
> It's not a problem at all.
> 
> What I believe might be a problem: kselftests are mostly userspace
> code and at least some parts are written somewhat loosely (which
> is totally fine for tests), so Sashiko will report a ton of issues,
> many of them are not worth fixing.

Good point. Maybe we can also find things that are worth fixing. It will
be an experiment.

> 
> So I guess it will be good to put down a kselftest-specific prompt with
> some guidance what we believe is acceptable in tests code and what's not.
> 

I can definitely do that depending on what we find.

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-01 23:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-01 19:51 Sashiko.dev for kselftest Shuah
2026-04-01 20:34 ` Roman Gushchin
2026-04-01 23:35   ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox