From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011005.outbound.protection.outlook.com [40.107.130.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2412327144B; Sat, 5 Sep 2026 05:31:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.5 ARC-Seal:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788586268; cv=fail; b=qKScQJFOsmJCqu7Km+iEyGY7fvBZncMS/eD5PByTAIR+rCYupam7LSm1rbCKKl7hcQhlcQpJH0Kg8XtYg0G4SkBRZd69lR278T9beM5A/dArtRsddS9GqOiGqf+XPHKISW5DvAhDYYTN3Zu75PPAlQqloM4zekftaBzr/j6CtNk= ARC-Message-Signature:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788586268; c=relaxed/simple; bh=a2knge4ZdNfgIQWIiom/xgCfSchoRQgzumUFSqi27sI=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=kiy2auGCZahpQg560q6J8/OkNStta2Lg875sg45vHMwZv4oei7XI4sPKFw28DvtiiAyd/1TKJPSGgh8qPaInoX37k56QaY+tDSOasP9ILnLD4Y9woiXWQmPa+bgTfiz6XsVBhwxWrpo1fp+MiH3W5UajX/z51Pf612G+FexXGo4= ARC-Authentication-Results:i=3; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=V3qRL55e; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=V3qRL55e; arc=fail smtp.client-ip=40.107.130.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="V3qRL55e"; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="V3qRL55e" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=HCv/fYRKCvZ39aYmhO2V8kDFx6mOybCGe95/cBCjA9uffLFJiHdnxh54R8Mv1RtV+67RpOm6AOF5+0B5yWGTO94tftG/qG/0UqU/12SG58n1z6PoLxNx8k3BdVO0wkmtcGXT6JS0+Rj1uFdi8K4oOVCsgk2URAAeyVl4je95YRGRbGn4rw3/CXRBarYaghVsltu8bsT6YWzJ7Wb6XSTpUax1gXnoDafqQ4Olsxbw7AxCxabDqJlb2Z+mGXqueoz+jkdHbHFDoooLp2pkj3jm5e0Yg/ihPLbhyyVkOckVdPvaJKFdLxT3y8GPdAyegz+Owr0z2b5gjggqrt0zauQWpQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qEzw9NpKj2v4Y0rr7vpIazbg7IYkwJn7QitUro15kZA=; b=h7vIJF6hssPwJVoZRcDi2jDUFuUQht3sBWK8pyy/KulUKbMGm5NI+VrUmh7x0F9a1IjINtbTMSOyqLmmiQu79+7o7sGt7p4R00J9ho/cdYpVTRHy333+R4VpRVbRiuPwoJGnzNKdK2qSsIJVNQB/oux4vnSmdxfkeB4QtreH9FBHRPxngGCCsg/H5J0hq7K15/WeqywCmwKuMt+5d3GofzsTGcl6BF6N6//7xuItUql7fi6Rxo4wBiZoS3Zu3Yp+834Ach9daH1yoB7ocGRJxPkjbWeVqBI+txaN1u+4KgT5Tewe3/HDTX56R/uyym/rR8r+6gqaqljRrfUsYLW2Ug== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qEzw9NpKj2v4Y0rr7vpIazbg7IYkwJn7QitUro15kZA=; b=V3qRL55e6WKI9rtw9Ch/lSTeiGuQTjR90Cl4BluD00RX2HKm6GqSq89ShdOQG4Zfnx6KBhRQxM9NPnvnqjrYCeIQ35nwGIqkt23CiTk6cioNnub6YW4odahDacZQmLxPqhOKW8ieeLgOle+FRVaEtnWszEV8oSvByfz9azSOGsk= Received: from PR3P189CA0035.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::10) by AS8PR08MB5912.eurprd08.prod.outlook.com (2603:10a6:20b:29f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Sat, 5 Sep 2026 05:30:59 +0000 Received: from AM7PEPF00000056.EURPRD83.prod.outlook.com (2603:10a6:102:53:cafe::2b) by PR3P189CA0035.outlook.office365.com (2603:10a6:102:53::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.13 via Frontend Transport; Sat, 5 Sep 2026 05:30:58 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AM7PEPF00000056.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.1 via Frontend Transport; Sat, 5 Sep 2026 05:30:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=acCP+4TGqxQAu2P/FND7F1eILVrFs4zolk5Ef3IIzOVxvvJYRLqdzolfcvS3IUvY7cOWPwWm7XwYlOTM8PZTsj/umT3X5ca9dPrjOZt+swJarPSltKH7g8IRnrHDPjOab/NFSIIg9c9XRKiNmkVsJEM5qw19N/mUOzwsjylM4hRq4ALgVvh3+SybA/3ZXEr+tcApiGImD7x9aUPcrFriXv6/c0t10xfdBQUFKGsAOFZJR5NpXj/OBCaoh7jeMMHhfKp7WO8LSh1t2O1J5LhHSPf31YVPTGP8uCK1tTnQHltSPv5n6SSesQHoFFMaMo/8QDNPS7BDsGMAtm58+GaX0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qEzw9NpKj2v4Y0rr7vpIazbg7IYkwJn7QitUro15kZA=; b=sJUNILhPaNyv8cJfXh/wzTlt7f0jki0aaHWCKnxFqHPFBXulEjddLE+FQIousmsqO+MEwe3ORPgMLi9oKa4cySGVyHLKIMIPZE+EyNoq11yFybAIP0ko6uOXfa33G+HgIDo5S9fUA+7eBc+hdJF6a3qQ3RbdreWyv9q0MyqoO/y/to3lbd6O0HOyAkPAkFTduvfYURHKqv8zAStmQmYLtvHa4pl0H8UujMKjjPV2ljaVWI0rXRXFJfOBUZxbaJ0yYo9i3YxOnhM2qln1DpQkPEiNr0HJRzOxqPquNy/pfr4qQXoE46Lf8BqCgfAvrk7u34jTIB0HznSRunMEZGmgVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qEzw9NpKj2v4Y0rr7vpIazbg7IYkwJn7QitUro15kZA=; b=V3qRL55e6WKI9rtw9Ch/lSTeiGuQTjR90Cl4BluD00RX2HKm6GqSq89ShdOQG4Zfnx6KBhRQxM9NPnvnqjrYCeIQ35nwGIqkt23CiTk6cioNnub6YW4odahDacZQmLxPqhOKW8ieeLgOle+FRVaEtnWszEV8oSvByfz9azSOGsk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB9203.eurprd08.prod.outlook.com (2603:10a6:10:417::12) by AM8PR08MB5633.eurprd08.prod.outlook.com (2603:10a6:20b:1d3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.9; Sat, 5 Sep 2026 05:30:24 +0000 Received: from DU0PR08MB9203.eurprd08.prod.outlook.com ([fe80::f1e:73f2:57df:4047]) by DU0PR08MB9203.eurprd08.prod.outlook.com ([fe80::f1e:73f2:57df:4047%6]) with mapi id 15.21.0406.002; Sat, 5 Sep 2026 05:30:24 +0000 Message-ID: Date: Sat, 5 Sep 2026 11:00:15 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 0/6] selftests/mm: separate GUP microbenchmarking from functional testing To: Andrew Morton , David Hildenbrand Cc: Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , Shuah Khan , Jonathan Corbet , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Mark Brown , Anshuman Khandual , Muhammad Usama Anjum , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260904123631.198697-1-sarthak.sharma@arm.com> Content-Language: en-US From: Sarthak Sharma In-Reply-To: <20260904123631.198697-1-sarthak.sharma@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MA0PR01CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:b8::20) To DU0PR08MB9203.eurprd08.prod.outlook.com (2603:10a6:10:417::12) Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB9203:EE_|AM8PR08MB5633:EE_|AM7PEPF00000056:EE_|AS8PR08MB5912:EE_ X-MS-Office365-Filtering-Correlation-Id: 208e5a89-a87d-4bb3-a6f6-08df0b0eddc8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|366016|1800799024|376014|23010399003|7416014|10070799003|22082099003|18002099003|56012099006|6133799003|10067099003|5023799004|11063799006; X-Microsoft-Antispam-Message-Info-Original: g043FfBbbXYT/5s8n4R2OfmkTUoAaqBNPUoD9VMRQLAdLIdPH3N5utCTNi92kS7JtpSdx4TUcNSZJlSKAOYH03hYSlABsvrg2mZcZkcYmQVLp/IuAH5pAI7xXPr7HsmjpwXJ9xARTV9DRiKAUNDWBMb+Ajwg0cY+jTLnRP20rhHBlzIEWzUmeyydjRC4be89qN0bcAJAJNBVOxbh3FHC/kOJ9CRxl5QOQQEGDBUXsMfS2ys2T1lYPwL2IQwFmpP2SevIyjFmWdevfzsLq7Ysu5yawujgTMuzGc/j4uf2tS656dqiaKwZDx0Z3nKir5J5LBMaFQqc1runRTjDp3vGEy2/H5VdDaQvs+XWVFcmUIkeJY9h69Zn0Zgb5OE75DytTvlE9G7o5HoGVxpCU09XFLJ3Fj+S+S8xJwH0/JSR8PmUEegwTD3izQejI1CQF8oUfM6b61ednBV7lB66+8/lgDe6qTXuK5wyEFifGToIeCfZqbmjwgfPe9Bvadg5YbcN3qfc+QaFvsmraYgeT+e1OMIbbiJWdwSAOUsTaz8UhOXR2TRnuy47Ymvf3IAwt2y53OQtc0aj9l1TIuUBhmkDYtP/nwpZMDqTKPf79EXOp+s= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB9203.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(7416014)(10070799003)(22082099003)(18002099003)(56012099006)(6133799003)(10067099003)(5023799004)(11063799006);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: y7qkliCrBJdRcHSSMRK4BdaXnbUcVP1bCz0B8StBls2zPq18J22nYM8WajKKk5uDcQ4t7Igo74lC/DAmAqOxL1McwetdiWNqMiGCjKdGHOKchy0sLXJdLV55YK9/gcfix2bW6C8wIFdKMoGLFHzF0HEL4149JLRPzpl4YlgwWo6IX9c71Kx/1D475+D1VThzvcFQzZu4i/K5uH7O7eleb0Nh10JzwXKyraOJtBmEjoheqo14XyWfAiWZXzJ+nl6BXR5Ke+tRQSmlZk5qxtdaUd7HYDPACChQaBMumw7nu7HgRbYkwCBf5jiwDbOASIHmNHmakDSrcrI5l0CoWJDpsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5633 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7PEPF00000056.EURPRD83.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6a3c3975-d9ab-4202-4e1b-08df0b0ec925 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|35042699022|14060799003|376014|7416014|23010399003|36860700016|13003099007|6133799003|10067099003|11063799006|56012099006|22082099003|18002099003|5023799004; X-Microsoft-Antispam-Message-Info: FteF1LjEDJXzHx6PUAE43muYvk4++03tnIynJjKAHlnapyV51098s9rX2bctdtRVzfzn1zUxGcT1iMhpMZpr+4HoSbk2sKo3HA2J7zm1DQE8ec8wFvRDSgx4y1MjmGg7cqqIzZRicvaV5SEybm+ZjluUhDSBE1nghySsAbdoqvS1uRq6wxin+HyswDnb+BHKJ44rpG+reqntE4uZVR5Svg+JD6hyxAiwM2Py6joxnp8VKcsoEz+3aVtW0+g1/iI0GyFf7mbOJFs6Unek2QtHDB168RMZepPlHH3g+mXqArN98b5ODQY9xNw2qkQ4462WV/HOMBEhC+zbPy6VnFFBIXBnSzm/08u2CMgBwOC8pBjEzEBPG1RJZzY2GyNFKqcniClzXITAaH6+kq6mOn9RCn0tgV9XziuIdoc+gRbTw5MMti47Aq4dM5uIgwxsvQHXXifWKNSoMqUX+hzNTUTS55meyx8oB++3khkGgnqWQTxEMpwVGZRK7oMJ2JVbjzDc/dmTVMt6PfnV/qvS3J398Q9HQUBiHH7uG1iDC73ZPUySMUvbiX7hAUKmD3DexUSzq4PAlzWRV7j53Rtepez5xh4k5cZGEF5+ZSekzW4sXhk= X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(35042699022)(14060799003)(376014)(7416014)(23010399003)(36860700016)(13003099007)(6133799003)(10067099003)(11063799006)(56012099006)(22082099003)(18002099003)(5023799004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bBG6djEu01P/ac0tb+IVZNQ4Pvam7sAArsqQkrig7ebFs4O8U3ODBvjkpBxHZL7O48oViHtyr7Y331fa9dnjRqDiZLEXVPcHgPJGuvznXb/GlXmGVKYGWXRDWk7OsKmie8/IWVByUQkWIRZ4pTBYgSoMzkI1QGE/qn2hkq3mcHGZsgeL2X3um1eUJYRflDQwuLxpNC1rCy5eJrVdT4My+LHwFGxo3zKQBFXURbAZPLDymEGOU7F/q+cDw01EGujl0SJIXDUAveah6b2Q/TUTPHX4FQsBK2VeeEVx37LqJhl4NxowyK6ZuxcUrl8HD7LG8UZMSKuziTOU4+KKeU/JUi2TtGv110JO9XIfzjA9F8EOXc4qIEUPvX54JKWtiLPPYEKBP139pI/gCz0RQ5VdBh2WGeCJ3uLFEDqqHYcA4XlKAPmegfy9RgZEvM0gdE7R X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2026 05:30:58.7330 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 208e5a89-a87d-4bb3-a6f6-08df0b0eddc8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AM7PEPF00000056.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5912 On 9/4/26 6:06 PM, Sarthak Sharma wrote: > gup_test.c currently serves two separate purposes: benchmarking > (GUP_FAST_BENCHMARK, PIN_FAST_BENCHMARK and PIN_LONGTERM_BENCHMARK) and > functional testing (GUP_BASIC_TEST, PIN_BASIC_TEST and > DUMP_USER_PAGES_TEST). Keeping both in one program makes the functional > tests harder to run and report individually, while run_vmtests.sh has to > invoke the program repeatedly with different options. > > Separate these roles into tools/mm/gup_bench for benchmarking and > tools/testing/selftests/mm/gup for functional testing. Move the shared > file and hugepage helpers to tools/lib/mm/ so both programs can use them > without duplicating the implementation. > I went through Sashiko's review on this patchset [1] and wanted to address the concerns it raises. Both the concerns here are false positives, as it assumes that FIXTURE_TEARDOWN() will run if FIXTURE_SETUP() fails. But in the kselftest harness, we initialize the variable no_teardown to true before calling FIXTURE_SETUP() and make it false only when FIXTURE_SETUP() completes successfully. So, if ASSERT_*() fails in FIXTURE_SETUP(), FIXTURE_TEARDOWN() won't run. Therefore neither stdin will be closed nor self->gup_fd will be closed twice. [1] https://sashiko.dev/#/patchset/20260904123631.198697-1-sarthak.sharma%40arm.com