Re: [PATCH net-next v1] selftest: rds: add tools/testing/selftests/net/rds/config

[Allison Henderson <allison.henderson@oracle.com>]

On Tue, 2026-03-17 at 15:41 +0100, Paolo Abeni wrote:
> On 3/17/26 12:58 AM, Allison Henderson wrote:
> > This patch adds an rds selftest config.  
> 
> Why? what improvement produces or what issues does that address?

We've been trying to get the rds selftest to work in the ksft CI runtime and it needs a per-target config file to build
a minimal kernel with the right options enabled  
[https://lore.kernel.org/netdev/20260315175517.3c8cca92@kernel.org/](https://lore.kernel.org/netdev/20260315175517.3c8cca92@kernel.org/)

I noticed a few other selftests appear to have their own configs as well.  I can add a quick summary of the new configs
if you like?

> 
> > diff --git a/tools/testing/selftests/net/rds/config b/tools/testing/selftests/net/rds/config
> > new file mode 100644
> > index 000000000000..103f9d941d10
> > --- /dev/null
> > +++ b/tools/testing/selftests/net/rds/config
> > @@ -0,0 +1,5 @@
> > +CONFIG_RDS=y
> > +CONFIG_RDS_TCP=y
> > +CONFIG_NET_NS=y
> > +CONFIG_VETH=y
> > +CONFIG_NET_SCH_NETEM=y
> > diff --git a/tools/testing/selftests/net/rds/config.sh b/tools/testing/selftests/net/rds/config.sh
> > index 791c8dbe1095..7cf56ee8882f 100755
> > --- a/tools/testing/selftests/net/rds/config.sh
> > +++ b/tools/testing/selftests/net/rds/config.sh
> > @@ -24,7 +24,7 @@ while getopts "g" opt; do
> >    esac
> >  done
> >  
> > -CONF_FILE="tools/testing/selftests/net/config"
> > +CONF_FILE="tools/testing/selftests/net/rds/config"
> >  
> >  # no modules
> >  scripts/config --file "$CONF_FILE" --disable CONFIG_MODULES
> 
> This looks wrong?!? The script is going to update the config file which
> is under git control. You probably want to copy the default config in a
> tmp file file, edit the latter and add it to .gitignore and EXTRA_CLEAN.
> 
> The issue looks pre-existent, but since you are touching this part...
> 
> /P
> 
> 
Sure, so config.sh isnt actually called by anything within the self tests or testing harness.  It more intended to be a
stand alone tool for when developers want to enable/disable gcov.  If you like we can adjust the target to a
rds/config.local and copy rds/config there.  

CONF_FILE="tools/testing/selftests/net/rds/config.local"  
cp tools/testing/selftests/net/rds/config "$CONF_FILE"

Alternately we could simply have the script default to config.local, and add a parameter that allows the caller to
specify the config path.  Let me know what you prefer.

I may split off the config.sh changes into a separate patch so that Jakub can start using the config though.

Thanks for the reviews!  
Allison