Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Yang Shi <yang@os.amperecomputing.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 1/2] kselftest/arm64: mte: Use the correct naming for tag check modes in check_hugetlb_options.c
Date: Fri, 21 Feb 2025 09:21:55 -0800	[thread overview]
Message-ID: <d34a5bee-14ab-4e63-9910-bd5fdd5bea2d@os.amperecomputing.com> (raw)
In-Reply-To: <20250221093331.2184245-2-catalin.marinas@arm.com>




On 2/21/25 1:33 AM, Catalin Marinas wrote:
> The architecture doesn't define precise/imprecise MTE tag check modes,
> only synchronous and asynchronous. Use the correct naming and also
> ensure they match the MTE_{ASYNC,SYNC}_ERR type.
>
> Fixes: 27879e8cb6b0 ("selftests: arm64: add hugetlb mte tests")
> Cc: Yang Shi <yang@os.amperecomputing.com>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
>   tools/testing/selftests/arm64/mte/check_hugetlb_options.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Yang Shi <yang@os.amperecomputing.com>

>
> diff --git a/tools/testing/selftests/arm64/mte/check_hugetlb_options.c b/tools/testing/selftests/arm64/mte/check_hugetlb_options.c
> index 303260a6dc65..11f812635b51 100644
> --- a/tools/testing/selftests/arm64/mte/check_hugetlb_options.c
> +++ b/tools/testing/selftests/arm64/mte/check_hugetlb_options.c
> @@ -270,13 +270,13 @@ int main(int argc, char *argv[])
>   	"Check clear PROT_MTE flags with private mapping and sync error mode and mmap/mprotect memory\n");
>   
>   	evaluate_test(check_child_hugetlb_memory_mapping(USE_MMAP, MTE_SYNC_ERR, MAP_PRIVATE | MAP_HUGETLB),
> -		"Check child hugetlb memory with private mapping, precise mode and mmap memory\n");
> +		"Check child hugetlb memory with private mapping, sync error mode and mmap memory\n");
>   	evaluate_test(check_child_hugetlb_memory_mapping(USE_MMAP, MTE_ASYNC_ERR, MAP_PRIVATE | MAP_HUGETLB),
> -		"Check child hugetlb memory with private mapping, precise mode and mmap memory\n");
> +		"Check child hugetlb memory with private mapping, async error mode and mmap memory\n");
>   	evaluate_test(check_child_hugetlb_memory_mapping(USE_MPROTECT, MTE_SYNC_ERR, MAP_PRIVATE | MAP_HUGETLB),
> -		"Check child hugetlb memory with private mapping, precise mode and mmap/mprotect memory\n");
> +		"Check child hugetlb memory with private mapping, sync error mode and mmap/mprotect memory\n");
>   	evaluate_test(check_child_hugetlb_memory_mapping(USE_MPROTECT, MTE_ASYNC_ERR, MAP_PRIVATE | MAP_HUGETLB),
> -		"Check child hugetlb memory with private mapping, precise mode and mmap/mprotect memory\n");
> +		"Check child hugetlb memory with private mapping, async error mode and mmap/mprotect memory\n");
>   
>   	mte_restore_setup();
>   	free_hugetlb();


  reply	other threads:[~2025-02-21 17:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21  9:33 [PATCH 0/2] kselftest/arm64: mte: Minor fixes to the MTE hugetlb test Catalin Marinas
2025-02-21  9:33 ` [PATCH 1/2] kselftest/arm64: mte: Use the correct naming for tag check modes in check_hugetlb_options.c Catalin Marinas
2025-02-21 17:21   ` Yang Shi [this message]
2025-02-21  9:33 ` [PATCH 2/2] kselftest/arm64: mte: Skip the hugetlb tests if MTE not supported on such mappings Catalin Marinas
2025-02-21 17:22   ` Yang Shi
2025-02-21 17:38   ` Dev Jain
2025-03-05 19:28 ` [PATCH 0/2] kselftest/arm64: mte: Minor fixes to the MTE hugetlb test Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d34a5bee-14ab-4e63-9910-bd5fdd5bea2d@os.amperecomputing.com \
    --to=yang@os.amperecomputing.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=naresh.kamboju@linaro.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox