From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B143ACDB47E for ; Fri, 20 Oct 2023 11:49:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377225AbjJTLta (ORCPT ); Fri, 20 Oct 2023 07:49:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377216AbjJTLt3 (ORCPT ); Fri, 20 Oct 2023 07:49:29 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09DCB1BF; Fri, 20 Oct 2023 04:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697802566; x=1729338566; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=bQz/LfAWgYDgtwkMay6xF+IAbu5wPfZ8ZJ3e4zonu2Y=; b=YdKunT5Wlz5PCZjkMOok8Qlfthn7Y+eg78c95dVF5cFAqV3BSF7AY4j8 vtfFJievCzirRqzzY/3dwNlncbu/AfYNqIcBGRlNCuPuWkljAE2AVvlYB ScdnNh8rbPhFtIuuT6iiJNc8p+dRCeCfHTj2c3dN6SZ+EgMfFWiXdQ5Fl qx5jx8Y5Mit/Pt2m0H4kMtdCnOyaKNLA2Hg4nuUc1ui9N+yK7cH1yoWWJ pCg59fgxmzRutJ7CYRF1Gh4TTc2JIs3vhPh0itXIZf0phV+w0V1+WaZwP HT7UIzpMpz46qV+Sq64l9aSwtKuuDUxXia4JGxJL2sSh+AU/t4nnpSFnI w==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="386294369" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="386294369" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 04:49:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="750894033" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="750894033" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.254.211.102]) ([10.254.211.102]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 04:49:19 -0700 Message-ID: Date: Fri, 20 Oct 2023 19:49:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: baolu.lu@linux.intel.com, cohuck@redhat.com, eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org, mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com, yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com, shameerali.kolothum.thodi@huawei.com, lulu@redhat.com, suravee.suthikulpanit@amd.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, zhenzhong.duan@intel.com, joao.m.martins@oracle.com, xin.zeng@intel.com, Jacob Pan Subject: Re: [PATCH v6 3/8] iommu/vt-d: Add helper for nested domain allocation To: Yi Liu , joro@8bytes.org, alex.williamson@redhat.com, jgg@nvidia.com, kevin.tian@intel.com, robin.murphy@arm.com References: <20231020093246.17015-1-yi.l.liu@intel.com> <20231020093246.17015-4-yi.l.liu@intel.com> Content-Language: en-US From: Baolu Lu In-Reply-To: <20231020093246.17015-4-yi.l.liu@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 2023/10/20 17:32, Yi Liu wrote: > From: Lu Baolu > > This adds helper for accepting user parameters and allocate a nested > domain. > > Reviewed-by: Kevin Tian > Signed-off-by: Jacob Pan > Signed-off-by: Lu Baolu > Signed-off-by: Yi Liu > --- > drivers/iommu/intel/Makefile | 2 +- > drivers/iommu/intel/iommu.h | 2 ++ > drivers/iommu/intel/nested.c | 55 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 58 insertions(+), 1 deletion(-) > create mode 100644 drivers/iommu/intel/nested.c > > diff --git a/drivers/iommu/intel/Makefile b/drivers/iommu/intel/Makefile > index 7af3b8a4f2a0..5dabf081a779 100644 > --- a/drivers/iommu/intel/Makefile > +++ b/drivers/iommu/intel/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > obj-$(CONFIG_DMAR_TABLE) += dmar.o > -obj-$(CONFIG_INTEL_IOMMU) += iommu.o pasid.o > +obj-$(CONFIG_INTEL_IOMMU) += iommu.o pasid.o nested.o > obj-$(CONFIG_DMAR_TABLE) += trace.o cap_audit.o > obj-$(CONFIG_DMAR_PERF) += perf.o > obj-$(CONFIG_INTEL_IOMMU_DEBUGFS) += debugfs.o > diff --git a/drivers/iommu/intel/iommu.h b/drivers/iommu/intel/iommu.h > index a91077a063ee..ff55184456dd 100644 > --- a/drivers/iommu/intel/iommu.h > +++ b/drivers/iommu/intel/iommu.h > @@ -866,6 +866,8 @@ void *alloc_pgtable_page(int node, gfp_t gfp); > void free_pgtable_page(void *vaddr); > void iommu_flush_write_buffer(struct intel_iommu *iommu); > struct intel_iommu *device_to_iommu(struct device *dev, u8 *bus, u8 *devfn); > +struct iommu_domain *intel_nested_domain_alloc(struct iommu_domain *s2_domain, > + const struct iommu_user_data *user_data); > > #ifdef CONFIG_INTEL_IOMMU_SVM > void intel_svm_check(struct intel_iommu *iommu); > diff --git a/drivers/iommu/intel/nested.c b/drivers/iommu/intel/nested.c > new file mode 100644 > index 000000000000..5a2920a98e47 > --- /dev/null > +++ b/drivers/iommu/intel/nested.c > @@ -0,0 +1,55 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * nested.c - nested mode translation support > + * > + * Copyright (C) 2023 Intel Corporation > + * > + * Author: Lu Baolu > + * Jacob Pan > + * Yi Liu > + */ > + > +#define pr_fmt(fmt) "DMAR: " fmt > + > +#include > + > +#include "iommu.h" > + > +static void intel_nested_domain_free(struct iommu_domain *domain) > +{ > + kfree(to_dmar_domain(domain)); > +} > + > +static const struct iommu_domain_ops intel_nested_domain_ops = { > + .free = intel_nested_domain_free, > +}; > + > +struct iommu_domain *intel_nested_domain_alloc(struct iommu_domain *s2_domain, > + const struct iommu_user_data *user_data) > +{ > + struct iommu_hwpt_vtd_s1 vtd; > + struct dmar_domain *domain; > + int ret; > + > + ret = iommu_copy_struct_from_user(&vtd, user_data, > + IOMMU_HWPT_DATA_VTD_S1, __reserved); > + if (ret) > + return ERR_PTR(ret); > + > + domain = kzalloc(sizeof(*domain), GFP_KERNEL_ACCOUNT); > + if (!domain) > + return NULL; return ERR_PTR(-ENOMEM); ? > + > + domain->use_first_level = true; > + domain->s2_domain = to_dmar_domain(s2_domain); > + domain->s1_pgtbl = vtd.pgtbl_addr; > + domain->s1_cfg = vtd; > + domain->domain.ops = &intel_nested_domain_ops; > + domain->domain.type = IOMMU_DOMAIN_NESTED; > + INIT_LIST_HEAD(&domain->devices); > + INIT_LIST_HEAD(&domain->dev_pasids); > + spin_lock_init(&domain->lock); > + xa_init(&domain->iommu_array); > + > + return &domain->domain; > +} Best regards, baolu