From: "Rantala, Tommi T. (Nokia - FI/Espoo)" <tommi.t.rantala@nokia.com>
To: "shuah@kernel.org" <shuah@kernel.org>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests: intel_pstate: ftime() is deprecated
Date: Wed, 28 Oct 2020 07:36:32 +0000 [thread overview]
Message-ID: <d4adb97b3325ac93295d5e42dc07e8381fb9efab.camel@nokia.com> (raw)
In-Reply-To: <d315994a-3398-be41-1b26-e78f8359aa5c@linuxfoundation.org>
On Tue, 2020-10-27 at 14:08 -0600, Shuah Khan wrote:
>
> > @@ -73,8 +80,8 @@ int main(int argc, char **argv) {
> > aperf = new_aperf-old_aperf;
> > mperf = new_mperf-old_mperf;
> >
> > - start = before.time*1000 + before.millitm;
> > - finish = after.time*1000 + after.millitm;
> > + start = before.tv_sec*1000 + before.tv_nsec/1000000L;
> > + finish = after.tv_sec*1000 + after.tv_nsec/1000000L;
>
> Why not use timespec dNSEC_PER_MSEC define from include/vdso/time64.h?
Hi,
If the define was available in the UAPI headers, then certainly would make
sense to use it. But I would not mess with the kernel internal headers here.
-Tommi
next prev parent reply other threads:[~2020-10-29 1:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 13:22 [PATCH] selftests: intel_pstate: ftime() is deprecated Tommi Rantala
2020-10-27 20:08 ` Shuah Khan
2020-10-28 7:36 ` Rantala, Tommi T. (Nokia - FI/Espoo) [this message]
2020-10-28 15:06 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4adb97b3325ac93295d5e42dc07e8381fb9efab.camel@nokia.com \
--to=tommi.t.rantala@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox