From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CCAD186A; Thu, 18 Jul 2024 02:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721268444; cv=none; b=MUzv838Wcb5Brb8trUW52GH67HIUJmFDRkOyGLPaSO81ekuyF2WmN5eapzyVWqp+JEYktsb3HEbHDGM4qxPGp14vlWLgUvmbUq9Ti2L0qZEXf4XoJ4YZ33FwRKcHs3bBHRVXxwKT9eogQdAzyUDqVgmmE4djEcKvsOCpeq1P3Ps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721268444; c=relaxed/simple; bh=iDshzoZBpRnf7yCKH9wLBLFebN6C/f+B8ZPFo2nQCA0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oA+nyabdmBRoMr3SjV+R92Rv8186hpHDGbMqrQ/EyeqcMcfU537UEHm2YGc8DCqg/FuO6tu1cnDCxhdJtDykzIEB7N4Wix91WNp7voXWN3Wa6bkIrkPQMR6mSy4gLzY/gqjD0WLe6rrimO58weMULbG6eXVNi4MIZO/xMct+Upk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=AxDq1xNJ; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="AxDq1xNJ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=MN9opQMCZMviT3QhqcL4hZlD2HbsMe34z7Elor7TtjE=; b=AxDq1xNJF92YMPtsE0UXbEol1z 9dpZD8t1GGjjzVyW1G89DDN3szdL5Ie/4L2atlFZFcXr6VVlEQjjjyg8ILkwOReAoR/X8Ij9DSrcH Lt0mY2MlfaeVU3G6CUzJdVtuuecq7E1ZNeeDAdiY3tDh+Vy950i/4Z75NzFWyyBJw3/4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sUGXe-002kZB-Jj; Thu, 18 Jul 2024 04:06:46 +0200 Date: Thu, 18 Jul 2024 04:06:46 +0200 From: Andrew Lunn To: Michal Rostecki Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Brendan Higgins , David Gow , Rae Moar , FUJITA Tomonori , Trevor Gross , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Martin Rodriguez Reboredo , Manmohan Shukla , Valentin Obst , Yutaro Ohno , Danilo Krummrich , Charalampos Mitrodimas , Ben Gooding , Tejun Heo , Nell Shamrell-Harrington , Roland Xu , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, netdev@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v5] rust: str: Use `core::CStr`, remove the custom `CStr` implementation Message-ID: References: <20240717160339.146371-2-vadorovsky@gmail.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240717160339.146371-2-vadorovsky@gmail.com> > v3 -> v4: > - Provide the `CStrExt` trait with `display()` method, which returns a > `CStrDisplay` wrapper with `Display` implementation. This addresses > the lack of `Display` implementation for `core::ffi::CStr`. > - Provide `from_bytes_with_nul_unchecked_mut()` method in `CStrExt`, > which might be useful and is going to prevent manual, unsafe casts. > - Fix a typo (s/preffered/prefered/). > > v4 -> v5: > - Keep the `test_cstr_display*` unit tests. Please take a read of: https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html In particular, the bit about 24 hours, and the merge window. Thanks Andrew --- pw-bot: cr