From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55B30C6FA82 for ; Tue, 13 Sep 2022 02:44:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229636AbiIMCoa (ORCPT ); Mon, 12 Sep 2022 22:44:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230136AbiIMCoK (ORCPT ); Mon, 12 Sep 2022 22:44:10 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A958C5300C; Mon, 12 Sep 2022 19:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663037049; x=1694573049; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Vqfi05Z4Z8Qp9L70ig4iz7+6GxG0pFYgY4ZoQ6Q11gU=; b=Kc1V5lSixuFAf1ri10Syf7qJOTUbqMjc6Oi8Sb6N3FhdR93FzNxwDxPu zSdmHOe2yOKZgU5PcSKJVwzVjYYe6ijz0gRZhlTjk0qShyAUqdcnng6pr lGDK5nIC5Li2CZZBIcCe/Nqm4Fd3C6HQYI+bXjbiwNegr8rq0YiOQO08r m4fotT3qfIbG4rMW4HzwJj0T6qqmfwEd6OqcTPYUWgDOQ7InBAgW+YVg/ mtJqPyad8aX4dH82gRJd+zxDwLb3AJ/Oa5tL+9jbT8zM5tIfGu1tRSU5z gyidq2vlTW5FKm8YCXFxmsPGxhRuv/wKHmvw0/zXD1uFT/IZA/QrDJhwA A==; X-IronPort-AV: E=McAfee;i="6500,9779,10468"; a="384316195" X-IronPort-AV: E=Sophos;i="5.93,311,1654585200"; d="scan'208";a="384316195" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 19:44:09 -0700 X-IronPort-AV: E=Sophos;i="5.93,311,1654585200"; d="scan'208";a="646733909" Received: from liweian-mobl.amr.corp.intel.com (HELO [10.209.26.112]) ([10.209.26.112]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 19:44:08 -0700 Message-ID: Date: Mon, 12 Sep 2022 19:44:08 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH v13 1/3] x86/tdx: Add TDX Guest attestation interface driver Content-Language: en-US To: "Huang, Kai" , "tglx@linutronix.de" , "mingo@redhat.com" , "shuah@kernel.org" , "x86@kernel.org" , "bp@alien8.de" , "dave.hansen@linux.intel.com" Cc: "linux-kernel@vger.kernel.org" , "ak@linux.intel.com" , "gregkh@linuxfoundation.org" , "wander@redhat.com" , "tim.gardner@canonical.com" , "hpa@zytor.com" , "isaku.yamahata@gmail.com" , "kirill.shutemov@linux.intel.com" , "Luck, Tony" , "khalid.elmously@canonical.com" , "marcelo.cerri@canonical.com" , "Cox, Philip" , "linux-doc@vger.kernel.org" , "linux-kselftest@vger.kernel.org" References: <20220909192708.1113126-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220909192708.1113126-2-sathyanarayanan.kuppuswamy@linux.intel.com> From: Sathyanarayanan Kuppuswamy In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 9/12/22 6:25 PM, Huang, Kai wrote: >> diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c >> index 928dcf7a20d9..8b5c59110321 100644 >> --- a/arch/x86/coco/tdx/tdx.c >> +++ b/arch/x86/coco/tdx/tdx.c >> @@ -5,16 +5,21 @@ >>  #define pr_fmt(fmt)     "tdx: " fmt >>   >>  #include >> +#include >> +#include >> +#include > Sorry perhaps I am missing something, but what is the reason to include > ? It is included for kmalloc/kfree, file related structs and copy_{from|to}_user(). > > is for virt_to_phys()? Yes > > And should we explicitly include for copy_{from|to}_user(), mm.h covers it. So I don't think we should explicitly include it. > and include the header ( ?) for memchr_inv()? One of the previous headers includes linux/string.h (I am not sure which one). So why include it explicitly? -- Sathyanarayanan Kuppuswamy Linux Kernel Developer