From: Paolo Bonzini <pbonzini@redhat.com>
To: shuah <shuah@kernel.org>, Xiaoyao Li <xiaoyao.li@intel.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH 0/2] Fix errors when try to build kvm selftests on
Date: Mon, 23 Mar 2020 20:42:27 +0100 [thread overview]
Message-ID: <d89b9433-7825-c204-a7b7-cce07d4ba7e7@redhat.com> (raw)
In-Reply-To: <ed26428d-00bc-e90c-f2ee-ee7c0f874715@kernel.org>
On 23/03/20 16:44, shuah wrote:
> On 3/18/20 7:13 AM, Paolo Bonzini wrote:
>> On 15/03/20 10:34, Xiaoyao Li wrote:
>>> I attempted to build KVM selftests on a specified dir, unfortunately
>>> neither "make O=~/mydir TARGETS=kvm" in tools/testing/selftests, nor
>>> "make OUTPUT=~/mydir" in tools/testing/selftests/kvm work.
>>>
>>> This series aims to make both work.
>>>
>>> Xiaoyao Li (2):
>>> kvm: selftests: Fix no directory error when OUTPUT specified
>
> This definitely isn't thr right fix for this issue.
>
>>> selftests: export INSTALL_HDR_PATH if using "O" to specify output dir
>
> Might be okay, but hard to find problems with the limited testing
> done just on the kvm test.
>
>>>
>>> tools/testing/selftests/Makefile | 6 +++++-
>>> tools/testing/selftests/kvm/Makefile | 3 ++-
>>> 2 files changed, 7 insertions(+), 2 deletions(-)
>>>
>>
>> Queued, thanks.
>>
>> Paolo
>>
>>
> Can you please drop these for your queue. I would like to make sure
> they work with other patches queued in kselftest next and would like
> these go through kselftest tree.
>
> It will be easier to find regressions when tested with other patches
> to framework as opposed to limited testing on just the kvm test.
Sure, thanks.
Paolo
prev parent reply other threads:[~2020-03-23 19:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 9:34 [PATCH 0/2] Fix errors when try to build kvm selftests on Xiaoyao Li
2020-03-15 9:34 ` [PATCH 1/2] kvm: selftests: Fix no directory error when OUTPUT specified Xiaoyao Li
2020-03-23 15:40 ` shuah
2020-03-24 1:51 ` Xiaoyao Li
2020-03-15 9:34 ` [PATCH 2/2] selftests: export INSTALL_HDR_PATH if using "O" to specify output dir Xiaoyao Li
2020-03-18 13:13 ` [PATCH 0/2] Fix errors when try to build kvm selftests on Paolo Bonzini
2020-03-23 15:33 ` shuah
2020-03-23 15:44 ` shuah
2020-03-23 19:42 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d89b9433-7825-c204-a7b7-cce07d4ba7e7@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox