From: Joe Lawrence <joe.lawrence@redhat.com>
To: Michael Vetter <mvetter@suse.com>,
linux-kselftest@vger.kernel.org, live-patching@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/3] selftests: livepatch: rename KLP_SYSFS_DIR to SYSFS_KLP_DIR
Date: Mon, 21 Oct 2024 14:55:43 -0400 [thread overview]
Message-ID: <da00cde9-ca61-266d-2185-7664c1bade68@redhat.com> (raw)
In-Reply-To: <20241017200132.21946-2-mvetter@suse.com>
On 10/17/24 16:01, Michael Vetter wrote:
> @@ -246,12 +246,12 @@ function unload_lp() {
> function disable_lp() {
> local mod="$1"
>
> - log "% echo 0 > /sys/kernel/livepatch/$mod/enabled"
> - echo 0 > /sys/kernel/livepatch/"$mod"/enabled
> + log "% echo 0 > $SYSFS_KLP_DIR/$mod/enabled"
> + echo 0 > "$SYSFS_KLP_DIR"/mod"/enabled
Nit: syntax error here, should be (quotation fix and $mod is a variable):
echo 0 > "$SYSFS_KLP_DIR/$mod/enabled"
With that, the test works for me.
--
Joe
next prev parent reply other threads:[~2024-10-21 18:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 20:01 [PATCH v5 0/3] selftests: livepatch: test livepatching a kprobed function Michael Vetter
2024-10-17 20:01 ` [PATCH v5 1/3] selftests: livepatch: rename KLP_SYSFS_DIR to SYSFS_KLP_DIR Michael Vetter
2024-10-21 18:55 ` Joe Lawrence [this message]
2024-10-22 11:56 ` Miroslav Benes
2024-10-17 20:01 ` [PATCH v5 2/3] selftests: livepatch: save and restore kprobe state Michael Vetter
2024-10-22 12:06 ` Miroslav Benes
2024-10-17 20:01 ` [PATCH v5 3/3] selftests: livepatch: test livepatching a kprobed function Michael Vetter
2024-10-22 12:08 ` Miroslav Benes
2024-10-21 18:57 ` [PATCH v5 0/3] " Joe Lawrence
2024-10-21 20:16 ` Marcos Paulo de Souza
2024-10-22 9:00 ` Petr Mladek
2024-10-22 15:26 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da00cde9-ca61-266d-2185-7664c1bade68@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mvetter@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox