From: Shuah Khan <skhan@linuxfoundation.org>
To: Al Viro <viro@zeniv.linux.org.uk>, linux-kselftest@vger.kernel.org
Cc: Shuah Khan <skhan@linuxfoundation.org>, shuah <shuah@kernel.org>
Subject: Re: [PATCH] test coverage for dup_fd() failure handling in unshare_fd()
Date: Thu, 22 Aug 2024 00:49:13 -0600 [thread overview]
Message-ID: <da3e91a8-da04-4c81-af84-405c5b46d345@linuxfoundation.org> (raw)
In-Reply-To: <20240822043932.GT504335@ZenIV>
On 8/21/24 22:39, Al Viro wrote:
> At some point there'd been a dumb braino during the dup_fd()
> calling conventions change; caught by smatch and immediately fixed.
> The trouble is, there had been no test coverage for the dup_fd() failure
> handling - neither in kselftests nor in LTP. Fortunately, it can be
> triggered on stock kernel - ENOMEM would require fault injection, but
> EMFILE can be had with sysctl alone (fs.nr_open).
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
Applied to linux-kselftest next for Linux 6.12-rc1 after fixing up
the short log to reflect the right test.
Thank you.
thanks,
-- Shuah
prev parent reply other threads:[~2024-08-22 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 4:39 [PATCH] test coverage for dup_fd() failure handling in unshare_fd() Al Viro
2024-08-22 6:49 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da3e91a8-da04-4c81-af84-405c5b46d345@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox