From: Baolu Lu <baolu.lu@linux.intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: baolu.lu@linux.intel.com, iommu@lists.linux.dev,
linux-kselftest@vger.kernel.org,
Kevin Tian <kevin.tian@intel.com>,
kvm@vger.kernel.org, Lixiao Yang <lixiao.yang@intel.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Nicolin Chen <nicolinc@nvidia.com>, Yi Liu <yi.l.liu@intel.com>
Subject: Re: [PATCH v7 02/19] iommufd: Add iommufd_group
Date: Wed, 17 May 2023 12:18:03 +0800 [thread overview]
Message-ID: <da44d7b8-aa7e-acfa-beb4-c2e524ed8562@linux.intel.com> (raw)
In-Reply-To: <ZGN8/K2qg4zsaeYQ@nvidia.com>
On 5/16/23 8:54 PM, Jason Gunthorpe wrote:
> On Tue, May 16, 2023 at 10:43:23AM +0800, Baolu Lu wrote:
>> On 5/15/23 10:00 PM, Jason Gunthorpe wrote:
>>> void iommufd_device_destroy(struct iommufd_object *obj)
>>> {
>>> struct iommufd_device *idev =
>>> container_of(obj, struct iommufd_device, obj);
>>> iommu_device_release_dma_owner(idev->dev);
>>> - iommu_group_put(idev->group);
>>> + iommufd_put_group(idev->igroup);
>>> if (!iommufd_selftest_is_mock_dev(idev->dev))
>>> iommufd_ctx_put(idev->ictx);
>>> }
>>> @@ -46,7 +154,7 @@ struct iommufd_device *iommufd_device_bind(struct iommufd_ctx *ictx,
>>> struct device *dev, u32 *id)
>>> {
>>> struct iommufd_device *idev;
>>> - struct iommu_group *group;
>>> + struct iommufd_group *igroup;
>>> int rc;
>>> /*
>>> @@ -56,9 +164,9 @@ struct iommufd_device *iommufd_device_bind(struct iommufd_ctx *ictx,
>>> if (!device_iommu_capable(dev, IOMMU_CAP_CACHE_COHERENCY))
>>> return ERR_PTR(-EINVAL);
>>> - group = iommu_group_get(dev);
>>> - if (!group)
>>> - return ERR_PTR(-ENODEV);
>>> + igroup = iommufd_get_group(ictx, dev);
>>> + if (IS_ERR(igroup))
>>> + return ERR_CAST(igroup);
>>> /*
>>> * For historical compat with VFIO the insecure interrupt path is
>> Hi Jason,
>>
>> Perhaps I am asking a silly question. The iommufd_group is get in
>> iommufd_device_bind(), but put in iommufd_device_destroy(). Why not put
>> it in iommufd_device_unbind()?
> It basically is like that, iommufd_device_destroy() is a helper that
> is only called by iommufd_device_unbind() through the usual
> destruction mechanism.
Oh, yes. Thank you for the explanation.
Best regards,
baolu
next prev parent reply other threads:[~2023-05-17 4:18 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 14:00 [PATCH v7 00/19] Add iommufd physical device operations for replace and alloc hwpt Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 01/19] iommufd: Move isolated msi enforcement to iommufd_device_bind() Jason Gunthorpe
2023-05-16 4:07 ` Baolu Lu
2023-05-15 14:00 ` [PATCH v7 02/19] iommufd: Add iommufd_group Jason Gunthorpe
2023-05-16 2:43 ` Baolu Lu
2023-05-16 12:54 ` Jason Gunthorpe
2023-05-17 4:18 ` Baolu Lu [this message]
2023-05-15 14:00 ` [PATCH v7 03/19] iommufd: Replace the hwpt->devices list with iommufd_group Jason Gunthorpe
2023-05-16 3:00 ` Baolu Lu
2023-05-16 12:27 ` Jason Gunthorpe
2023-05-17 4:15 ` Baolu Lu
2023-05-17 6:33 ` Tian, Kevin
2023-05-17 12:43 ` Jason Gunthorpe
2023-05-18 7:05 ` Baolu Lu
2023-05-18 12:02 ` Jason Gunthorpe
2023-05-19 2:03 ` Baolu Lu
2023-05-19 7:51 ` Tian, Kevin
2023-05-19 11:42 ` Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 04/19] iommu: Export iommu_get_resv_regions() Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 05/19] iommufd: Keep track of each device's reserved regions instead of groups Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 06/19] iommufd: Use the iommufd_group to avoid duplicate MSI setup Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 07/19] iommufd: Make sw_msi_start a group global Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 08/19] iommufd: Move putting a hwpt to a helper function Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 09/19] iommufd: Add enforced_cache_coherency to iommufd_hw_pagetable_alloc() Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 10/19] iommufd: Allow a hwpt to be aborted after allocation Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 11/19] iommufd: Fix locking around hwpt allocation Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 12/19] iommufd: Reorganize iommufd_device_attach into iommufd_device_change_pt Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 13/19] iommu: Introduce a new iommu_group_replace_domain() API Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 14/19] iommufd: Add iommufd_device_replace() Jason Gunthorpe
2023-07-07 8:00 ` Liu, Yi L
2023-07-10 16:46 ` Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 15/19] iommufd: Make destroy_rwsem use a lock class per object type Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 16/19] iommufd/selftest: Test iommufd_device_replace() Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 17/19] iommufd: Add IOMMU_HWPT_ALLOC Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 18/19] iommufd/selftest: Return the real idev id from selftest mock_domain Jason Gunthorpe
2023-05-15 14:00 ` [PATCH v7 19/19] iommufd/selftest: Add a selftest for IOMMU_HWPT_ALLOC Jason Gunthorpe
2023-05-17 23:57 ` [PATCH v7 00/19] Add iommufd physical device operations for replace and alloc hwpt Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da44d7b8-aa7e-acfa-beb4-c2e524ed8562@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lixiao.yang@intel.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox