From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Chen Yu <yu.c.chen@intel.com>
Cc: Tony Luck <tony.luck@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
x86@kernel.org, Dave Martin <Dave.Martin@arm.com>,
James Morse <james.morse@arm.com>,
Babu Moger <babu.moger@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-kselftest@vger.kernel.org,
Hongyu Ning <hongyu.ning@linux.intel.com>
Subject: Re: [PATCH] selftests/resctrl: Allow CAT testing when no exclusive cache exists
Date: Mon, 25 May 2026 13:01:59 +0300 (EEST) [thread overview]
Message-ID: <db89b830-997f-8f74-012c-9aece7fa5c34@linux.intel.com> (raw)
In-Reply-To: <20260523101715.3964456-1-yu.c.chen@intel.com>
On Sat, 23 May 2026, Chen Yu wrote:
> The shareable_bits indicates which cache portions might be shared with
> other agents (e.g., GPU, other I/O devices). On some platforms, all L3
> cache ways are marked as potentially shared.
>
> The L3_CAT test should fall back to using the full CBM mask when no
> exclusive portion exists, since the test logic (writing different
> schemata and measuring cache misses) still works. The shareable mask
> is a hint about potential interference, not a hard exclusion.
>
> Reported-by: Hongyu Ning <hongyu.ning@linux.intel.com>
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> ---
> tools/testing/selftests/resctrl/cat_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
> index f00b622c1460..b6994ba4504b 100644
> --- a/tools/testing/selftests/resctrl/cat_test.c
> +++ b/tools/testing/selftests/resctrl/cat_test.c
> @@ -248,7 +248,7 @@ static int cat_run_test(const struct resctrl_test *test, const struct user_param
> /* Get the largest contiguous exclusive portion of the cache */
> ret = get_mask_no_shareable(test->resource, &long_mask);
> if (ret)
> - return ret;
> + long_mask = full_cache_mask;
Wouldn't it warrant to log something when the fallback occurs? It
certainly looks something that makes the results less reliable (so it
would be nice to know about it when looking at the test results).
>
> /* Get L3/L2 cache size */
> ret = get_cache_size(uparams->cpu, test->resource, &cache_total_size);
>
--
i.
next prev parent reply other threads:[~2026-05-25 10:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 10:17 [PATCH] selftests/resctrl: Allow CAT testing when no exclusive cache exists Chen Yu
2026-05-25 10:01 ` Ilpo Järvinen [this message]
2026-05-25 11:59 ` Chen, Yu C
2026-05-26 15:25 ` Reinette Chatre
2026-05-27 1:57 ` Chen, Yu C
2026-05-27 2:24 ` Reinette Chatre
2026-05-27 4:52 ` Chen, Yu C
2026-05-27 9:49 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db89b830-997f-8f74-012c-9aece7fa5c34@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=hongyu.ning@linux.intel.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox