From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A16EDEB64DA for ; Fri, 30 Jun 2023 15:23:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232583AbjF3PXx (ORCPT ); Fri, 30 Jun 2023 11:23:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232543AbjF3PXv (ORCPT ); Fri, 30 Jun 2023 11:23:51 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 837173C26; Fri, 30 Jun 2023 08:23:46 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 89AFF5C0676; Fri, 30 Jun 2023 11:23:45 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 30 Jun 2023 11:23:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1688138625; x=1688225025; bh=IL g/wPOhXEcgQ5Av4DXDVBtyA0OobUQWTU0tPHfsP7s=; b=KpqedbCuGpeTfWO8aR H9i7PlsCFvlHcBZsJOGhJOKX5VRjNurfW2SCuGQvalOFaq/i2J/yQfjPjiT5hORZ AlNKYrhrkkCIICEZMrLP1VcsnMI8semBtNYfLrRv21RAxdB9LKKsneg3RZbOKMch 1k1p/yjAjZgp9sf5JuqoFky0iPJIq+Hf4k/Y04YYvMQrj9PGh7W9q4UhRNQb3afu 1sTsNNdW2uFEvYCOcVz2zpBIzmT34j6P6WOllzAUs9g5X/ebzH1cyFuOrfin3EUL 9ow7AfQwiyYsncCyjCVBq4vvQBqfsrewwVph7q8WZ/iMNocFxpr7NbyvDgVKelCd kVyg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1688138625; x=1688225025; bh=ILg/wPOhXEcgQ 5Av4DXDVBtyA0OobUQWTU0tPHfsP7s=; b=PR8/rBOJ661jJEQkqegRQk26V7Q8P P7loAA/laIYtFFcpwxW73pyDvi4wQGzAZno/sfpt46KbJXp6+NwqYqqqmpStdfd+ WgEDhj7DLIn10DpIV6Wkizkt+8crbXjeKv36AN8Swu4Q5NRWVxF77DvjyFGszVGq ag2bxWggdKj/bFsGge/yqGN3GiPV3ZaSE9fTN8uYfnzexvQZXSc/uZX2sqlZE+3I 06oY++rdWmT/4gzAKaZfdUt0TDa1I0lt+uqd1XsqtshHd5FsLGgLb8tz52OkdJ0D rLHuwnyJ6V62q0kb1WRl5q26b70Elusw0Fv2S/pumL50I4UWfsFpZR+dg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtdeigdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E8010B60092; Fri, 30 Jun 2023 11:23:44 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-499-gf27bbf33e2-fm-20230619.001-gf27bbf33 Mime-Version: 1.0 Message-Id: In-Reply-To: References: Date: Fri, 30 Jun 2023 17:23:24 +0200 From: "Arnd Bergmann" To: "Zhangjin Wu" , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , "Willy Tarreau" Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Subject: Re: [PATCH v3 03/14] selftests/nolibc: add _LARGEFILE64_SOURCE for musl Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, Jun 30, 2023, at 16:44, Zhangjin Wu wrote: > _GNU_SOURCE Implies _LARGEFILE64_SOURCE in glibc, but in musl, the > default configuration doesn't enable _LARGEFILE64_SOURCE. > > From include/dirent.h of musl, getdents64 is provided as getdents when > _LARGEFILE64_SOURCE is defined. > > #if defined(_LARGEFILE64_SOURCE) > ... > #define getdents64 getdents > #endif > > Let's define _LARGEFILE64_SOURCE to fix up this compile error: I think a better solution would be to use the normal getdents() instead of glibc getdents64(), but then define _FILE_OFFSET_BITS=64 to tell glibc to use the modern version of all filesystem syscalls. Arnd