From: Michal Luczaj <mhal@rbox.co>
To: Jakub Sitnicki <jakub@cloudflare.com>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 0/6] selftests/bpf: Various sockmap-related fixes
Date: Thu, 10 Oct 2024 00:31:13 +0200 [thread overview]
Message-ID: <dc968352-4ce6-46a0-af69-058e29aa0df4@rbox.co> (raw)
In-Reply-To: <87y12xy5fe.fsf@cloudflare.com>
On 10/9/24 11:46, Jakub Sitnicki wrote:
> That's curious. We don't override the proto::sendmsg callback for
> protocols which don't support sk_msg redirects, like UDP:
>
> https://elixir.bootlin.com/linux/v6.12-rc2/source/net/ipv4/udp_bpf.c#L114
>
> The packet should get delivered to the peer socket as w/o sockmap.
> I will have to double check that.
Ugh, no, you're right. I was checking the wrong queue all that time...
Sorry for the confusion.
> Thanks. And yes - if possible, better to push fixes separately. Because
> they go through the bpf tree, and they will still land in the upcoming
> -rc releases (and get backported).
>
> While improvements go through bpf-next. Of course that sometimes makes
> life more difficult if the improvements depend on some fixes...
I'm afraid that's the case for the redir selftest to run cleanly.
Anyway, so those are the fixes mentioned, targeting bpf:
https://lore.kernel.org/bpf/20241009-vsock-fixes-for-redir-v1-0-e455416f6d78@rbox.co/
> Not sure if anything from bpf-next gets backported if it has a Fixes
> tag. We can ask the stable kernel maintainers, if needed.
next prev parent reply other threads:[~2024-10-09 22:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 10:01 [PATCH bpf-next v2 0/6] selftests/bpf: Various sockmap-related fixes Michal Luczaj
2024-07-31 10:01 ` [PATCH bpf-next v2 1/6] selftests/bpf: Support more socket types in create_pair() Michal Luczaj
2024-07-31 10:01 ` [PATCH bpf-next v2 2/6] selftests/bpf: Socket pair creation, cleanups Michal Luczaj
2024-07-31 10:01 ` [PATCH bpf-next v2 3/6] selftests/bpf: Simplify inet_socketpair() and vsock_socketpair_connectible() Michal Luczaj
2024-07-31 10:01 ` [PATCH bpf-next v2 4/6] selftests/bpf: Honour the sotype of af_unix redir tests Michal Luczaj
2024-07-31 10:01 ` [PATCH bpf-next v2 5/6] selftests/bpf: Exercise SOCK_STREAM unix_inet_redir_to_connected() Michal Luczaj
2024-07-31 10:01 ` [PATCH bpf-next v2 6/6] selftests/bpf: Introduce __attribute__((cleanup)) in create_pair() Michal Luczaj
2024-08-05 15:22 ` [PATCH bpf-next v2 0/6] selftests/bpf: Various sockmap-related fixes Jakub Sitnicki
2024-08-05 19:54 ` Michal Luczaj
2024-08-06 12:01 ` Jakub Sitnicki
2024-08-06 17:18 ` Michal Luczaj
2024-08-06 17:45 ` Jakub Sitnicki
2024-08-14 16:14 ` Michal Luczaj
2024-08-14 16:17 ` [PATCH 1/3] selftests/bpf: Support AF_UNIX SOCK_DGRAM socket pair creation Michal Luczaj
2024-08-14 16:18 ` [PATCH 2/3] selftests/bpf: Allow setting BPF_F_INGRESS in prog_msg_verdict() Michal Luczaj
2024-08-14 16:20 ` [PATCH 3/3] selftests/bpf: Add selftest for sockmap/hashmap redirection Michal Luczaj
2024-08-16 19:03 ` [PATCH bpf-next v2 0/6] selftests/bpf: Various sockmap-related fixes Jakub Sitnicki
2024-08-19 22:45 ` Martin KaFai Lau
2024-08-19 20:05 ` Jakub Sitnicki
2024-09-24 10:25 ` Michal Luczaj
2024-09-26 22:54 ` Michal Luczaj
2024-09-27 9:15 ` Jakub Sitnicki
2024-10-02 8:27 ` Michal Luczaj
2024-10-09 9:46 ` Jakub Sitnicki
2024-10-09 22:31 ` Michal Luczaj [this message]
2025-04-11 11:44 ` Michal Luczaj
2024-08-20 0:20 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc968352-4ce6-46a0-af69-058e29aa0df4@rbox.co \
--to=mhal@rbox.co \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox