From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDD8E2417D9 for ; Mon, 14 Jul 2025 13:30:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752499834; cv=none; b=OFbXSzc7uX7nF7j0spQG1GGxzYz4MNdJmet/r3roTyq89cmY3MzogYh0tdRNcMSdVMnENWmDT1UazoWq4LEsAOBH1Wo9Ih5YdoFlId+tGAp5yEnwrAGZ4sVm4A716nXlAXRJF+7fyaLVIHztN0Jp64DP3JQ43uvty121qv7NlvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752499834; c=relaxed/simple; bh=jE2PjP+eUyYjMNAeVnNr5q6iOIuN3tAeEx+RGEXiP+M=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=tW5Oy+oG/oAA7jQTCkPJL/C4FGIgeGDPRfWPgsQGTDl8DQidhaQERmMbneQ4Y5JhTHoxJEeIhSLs1ea8aEsWgbKQbWQ2tTNLh6ea7FtquPSyROKo83LozXY39hB2B5NBEVtHEM+s6WkJQzBaNWldDlYY16yIby9BBImPFnS0Ios= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HxvTKTdI; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HxvTKTdI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752499831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+zrHqcWkaADA2V8M40rY+/BG8BMVb7igefIEkGbRiek=; b=HxvTKTdI1itRGZQJ2uwjeuXXe7W60mB52wyg37fJQtO2zwHB3meczxI0U0cL7qCxH8nekB j8KlMq/zSVJLB/5OKiNmLitDfHBwJ+dC0s7N9etWzfPhO+UpIVRr634qSupvZ71yXugewc 06TeSay7s/ZhnJiiZ3r13Sy8TeH2UoI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-eb3WX6XQOCCqnXvXYaGofw-1; Mon, 14 Jul 2025 09:30:30 -0400 X-MC-Unique: eb3WX6XQOCCqnXvXYaGofw-1 X-Mimecast-MFC-AGG-ID: eb3WX6XQOCCqnXvXYaGofw_1752499826 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a6d90929d6so1958112f8f.2 for ; Mon, 14 Jul 2025 06:30:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752499826; x=1753104626; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+zrHqcWkaADA2V8M40rY+/BG8BMVb7igefIEkGbRiek=; b=kZqas7spwOwwhMyLafBbJQJ1w8myIflqoUkxND7xAcApMubH3QAqpY9nCuI100m7t9 tTvHZbHnbhZNpwxD3hf5XuHJ0JhcUcmAJYe6WfOPzEeEtwHY2xMk+9WlohiupXm9sDMu GhukpNOlDauxrlZgq080w97s3maxZV5Ogv/wBJcAIpks/p4m8hyc5JJlrEFy6+f/iH+o 2GdyL646C3+GFgrfcxfMj9VplxroAi/cP8T1hqiPo1IXNLZ80WZC3KvSdo5EFdYhQFpl ihTWMvQqNk4qfjJwgLajWp3LWd57bf7j6ZRvWApEvBnVz8ajrvKaGWOV7p2K8CvndOw2 gQhA== X-Forwarded-Encrypted: i=1; AJvYcCV/ekz2CxTemlR/Fs+IDj//EkR8Th5IizGWGfgl21Kc1U24x22/Rtsrlo+9h5XNdhFQJKe7pqPVMG75tEmMKdo=@vger.kernel.org X-Gm-Message-State: AOJu0YyniGhCmmmMJHN572e4JrsEfrcN9Ju71+qde37s75/I4v9ykp3e a169Ui5GFqrEvfSRCUDP5fqSPaNRkjnG2VNdKggpZNuIYxmbCtANvBs/mncoTkaAuIdpKDYxdd5 Ei+/JTVu07gZq6qPgmHn7GCHe98Y8Io91OXFbo5ecI+LnIYWrxyuC5RXAz8LJa11VDMwR6g== X-Gm-Gg: ASbGncuwIQrCe+KV/78Myh1EqhBj1alWAcWi/v6ELYkAFOwNpBs49zAcoITwz+U4STY N3lmPVIsedKxPrp/HQ8v+0k3SEc8TeqWGCIW4M7mxG2zJ27Okaz7sS3I+IxzGHRYoU9M1JKCLz5 sGMcoDh/61wO/5XniN3NesU3dF3xPYOY1XxjSA/5UxlleFNNZ82Q+uNifstGsCXVYJ32Ehh93Gr P/1XobMT0ph3dJW4ndMd+rMIrDIa4lXDsLp4hgMTbhgV2fBxcAiQPJPDpC3x0nA3N+U+qBF1sqi RzMYWqYuyE+vfeLfV0kUjK7dy3qAIjXv1j1m6IyA+U8= X-Received: by 2002:a05:6000:1a86:b0:3a4:eda1:6c39 with SMTP id ffacd0b85a97d-3b5f2dc216dmr9064734f8f.13.1752499826100; Mon, 14 Jul 2025 06:30:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHFaTEcDjTABy5Z9QcNaN67akhbYxVRmsOC1nK6NjQhL0rqHS1s4JU+e5aThLy1SFXDe8sLSA== X-Received: by 2002:a05:6000:1a86:b0:3a4:eda1:6c39 with SMTP id ffacd0b85a97d-3b5f2dc216dmr9064691f8f.13.1752499825633; Mon, 14 Jul 2025 06:30:25 -0700 (PDT) Received: from [192.168.0.115] ([212.105.155.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4560ddf5e0esm67383545e9.18.2025.07.14.06.30.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jul 2025 06:30:25 -0700 (PDT) Message-ID: Date: Mon, 14 Jul 2025 15:30:22 +0200 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 net-next 08/15] tcp: accecn: add AccECN rx byte counters To: chia-yu.chang@nokia-bell-labs.com, edumazet@google.com, linux-doc@vger.kernel.org, corbet@lwn.net, horms@kernel.org, dsahern@kernel.org, kuniyu@amazon.com, bpf@vger.kernel.org, netdev@vger.kernel.org, dave.taht@gmail.com, jhs@mojatatu.com, kuba@kernel.org, stephen@networkplumber.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net, liuhangbin@gmail.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, ij@kernel.org, ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com, g.white@cablelabs.com, ingemar.s.johansson@ericsson.com, mirja.kuehlewind@ericsson.com, cheshire@apple.com, rs.ietf@gmx.at, Jason_Livingood@comcast.com, vidhi_goel@apple.com References: <20250704085345.46530-1-chia-yu.chang@nokia-bell-labs.com> <20250704085345.46530-9-chia-yu.chang@nokia-bell-labs.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250704085345.46530-9-chia-yu.chang@nokia-bell-labs.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit n 7/4/25 10:53 AM, chia-yu.chang@nokia-bell-labs.com wrote: > diff --git a/include/net/tcp.h b/include/net/tcp.h > index 61b103633da4..0d8e1a676dad 100644 > --- a/include/net/tcp.h > +++ b/include/net/tcp.h > @@ -971,6 +971,9 @@ static inline u32 tcp_rsk_tsval(const struct tcp_request_sock *treq) > * See draft-ietf-tcpm-accurate-ecn for the latest values. > */ > #define TCP_ACCECN_CEP_INIT_OFFSET 5 > +#define TCP_ACCECN_E1B_INIT_OFFSET 1 > +#define TCP_ACCECN_E0B_INIT_OFFSET 1 > +#define TCP_ACCECN_CEB_INIT_OFFSET 0 It looks like the definitions above are not used in this patch. I suggest moving the definition in 'tcp: accecn: AccECN option' Otherwise the code LGTM, but I still have some doubts WRT the significant increase of the hotpath data. /P