From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3799DC61DA4 for ; Tue, 14 Feb 2023 23:37:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229527AbjBNXhM (ORCPT ); Tue, 14 Feb 2023 18:37:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232224AbjBNXhK (ORCPT ); Tue, 14 Feb 2023 18:37:10 -0500 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEE2B2BF11 for ; Tue, 14 Feb 2023 15:37:07 -0800 (PST) Received: by mail-io1-xd2f.google.com with SMTP id a10so6501132iod.0 for ; Tue, 14 Feb 2023 15:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mZdjpB1hiR4KdFF9IW1WmBupIcjtLh3KZAHATvyECZc=; b=hTAoWB2LQ9OA67yieHFQdvaCwbt9cNBIAg/X3DTK4gP9hE5H2rbBfPjwZe62bTp6mK 9i7tGy9YcyRUg0zuQpqI2dhnX2KAkntai21DmZNEqYhjB1hJ6RdKc7mI+PxW/QtleGoi 8ko5/pP2kAcKhYb19v3+WjeezjUxjYqKxRBLw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mZdjpB1hiR4KdFF9IW1WmBupIcjtLh3KZAHATvyECZc=; b=13hnuCSp0lXPJhd9EKBkKAjZ0bHGRXl14jigtEhPFTd0lDzeXqmXFBxXTL3ld8FT1d cOfnrgdej7OfWUIP54bG2ngdJoAVk33vL/7ofDVpoRI42jbt8Z0y+lOTYJD06hVp6jhz n4aKloF3eAjew5Pga2JHWGFL7TPxhOkbFjIovONtRQSlTvdDOfFcJ3gcRTCOEksPpOtE jlAP+6s0Mo5IyPN0udZWfSnXktWpFyBGOH03GVB61fuBx/R9xSLSUIt89kqOwgYYObsJ HtzxNaM+C7IH4lHRd3fh5vPETklhRluDFX8WU58tpJMShv6Az8EEnWrd6OX+Ithr3fPP YMMA== X-Gm-Message-State: AO0yUKVtXyE1+u7i/akOTVXX9DOJjRvwuJ6mzvDUGnjopxdx88QAWy4Y TZNh+V42TGHQMO65muJnMOPVNQ== X-Google-Smtp-Source: AK7set/4/pIQOLdtIr2u+j9NEMRLql2ZuJXi2Ce/0glFkqfSzRfp2NVpFKuVnFsC3x9IfmqqHBjplA== X-Received: by 2002:a05:6602:1415:b0:70a:9fce:853c with SMTP id t21-20020a056602141500b0070a9fce853cmr424774iov.2.1676417827031; Tue, 14 Feb 2023 15:37:07 -0800 (PST) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id u14-20020a02aa8e000000b003a9595b7e3asm5322393jai.46.2023.02.14.15.37.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Feb 2023 15:37:06 -0800 (PST) Message-ID: Date: Tue, 14 Feb 2023 16:37:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] selftests/mount_setattr: fix redefine struct mount_attr build error Content-Language: en-US To: Seth Forshee Cc: shuah@kernel.org, brauner@kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20230213183149.231779-1-skhan@linuxfoundation.org> From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 2/14/23 13:45, Seth Forshee wrote: > On Tue, Feb 14, 2023 at 10:10:00AM -0700, Shuah Khan wrote: >>> >> >> The header search looks up system headers followed by installed headers in >> the repo (both in-tree and out-of-tree builds). kselftest builds do depend >> on headers_install. Did you building after running headers_install? > > I wasn't aware they depend on headers_install. Why doesn't > Documentation/dev-tools/kselftest.rst mention this in the section that > describes how to run tests? > It ahs always been a dependency. If you were to compile from the main (root) Makefile as below - headers_install get done before test compile: make kselftest-all TARGETS=mount_setattr > It seems what I really need to fix the build is to include > linux/mount.h, which works for me with or without headers_install, > because I have the struct in /usr/include/linux/mount.h. And I suppose > the makefile should use KHDR_INCLUDES. So maybe the changes below should > also be included. > Yes. Makefile change to use KHDR_INCLUDES is already done. Please take a look at linux-kselftest next - this was done as part of a tree-wide change. If including linux/mount.h is thr correct solution, please send me the patch on top of linux-kselftest next and I will pull it in. > However I know Christian has said that there are challenges with > including the mount headers. He wrote this test, so I'd like to hear his > thoughts about adding the include. He's on vacation this week though. > Sounds good. thanks, -- Shuah