From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F6AEC4320A for ; Wed, 25 Aug 2021 20:04:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C8B3610C9 for ; Wed, 25 Aug 2021 20:04:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242554AbhHYUFD (ORCPT ); Wed, 25 Aug 2021 16:05:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231421AbhHYUFD (ORCPT ); Wed, 25 Aug 2021 16:05:03 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2391AC061757 for ; Wed, 25 Aug 2021 13:04:17 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id l7-20020a0568302b0700b0051c0181deebso441187otv.12 for ; Wed, 25 Aug 2021 13:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RA3M/vOsIOYIXJH3RoPts4CCXAW9QCJKSqu44COBkGE=; b=Guns7hjNARkbdBWWVfuXj8IHvqOauZbeRkUMHXr9kdt5Dl0jza/oJbe/srdRZziPGQ nYO4sVnbMFzp5TaJ9o/Te5FMnxnw5yhkPWh+ZBUFjjWL7qIOdSBsu+SqYnPlLDyq4Sgx 9YMTQqeyDsQ/7d4S5HlTB6b4dyQ/rA7NrLNHs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RA3M/vOsIOYIXJH3RoPts4CCXAW9QCJKSqu44COBkGE=; b=CHccmC7tgOsuIssV3rzx03EGbD0jezLQRL8/9ItT9vnI4BW0AFtgnSc0gTlR5fX/r7 sNOgiUsX3RzzvALPSREyHkUshcGJxr1cEHX4LZjmdk5ehRBGERf9sjym30xTXyDRZt29 anLrzq+BYhRYOceoeXmQz0pwd1rLLXUVS9Z3JWToVJ8s/z1xEMeYdLWvMTf72Fo+ZKL6 KFfjmghgP7y1IfQSANbsRvCzSqvlaHUyD6zivsW57z5rNWcIJ6vLCoTeXXvaAc2KbJ9Y Q9wEmDCHDxAjnjf4B8UdAwpuWE+lo/uS5NppiP5in5SeR778rDaWEFfhi/HKtPaYEkJj l4LA== X-Gm-Message-State: AOAM532oG6GASS+VF3OWmG5xstkkxjBeJ2xTer3R+IMovE6wVxkwHnJ5 JHD5NvWmR4QzAqVGRIQr1ZMmiw== X-Google-Smtp-Source: ABdhPJx4sKPp6OJaXzeb91suWooqUYST0b36LI0gHjt3MFO7BAtYEk/OSEzGS4gNQOfFvqJaByWX1w== X-Received: by 2002:a9d:4042:: with SMTP id o2mr174980oti.332.1629921854542; Wed, 25 Aug 2021 13:04:14 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id 97sm159738otv.26.2021.08.25.13.04.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Aug 2021 13:04:14 -0700 (PDT) Subject: Re: [PATCH linux-next] tools:signal: fix boolreturn.cocci warnings To: CGEL , Catalin Marinas Cc: Will Deacon , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jing Yangyang , Zeal Robot , Shuah Khan References: <20210824065131.60346-1-deng.changcheng@zte.com.cn> <16561a4f-6043-cc5b-7a50-5be1ff10bfa5@linuxfoundation.org> From: Shuah Khan Message-ID: Date: Wed, 25 Aug 2021 14:04:13 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <16561a4f-6043-cc5b-7a50-5be1ff10bfa5@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 8/24/21 8:39 AM, Shuah Khan wrote: > On 8/24/21 12:51 AM, CGEL wrote: >> From: Jing Yangyang >> >> ./tools/testing/selftests/arm64/signal/test_signals_utils.h:112:9-10 >> WARNING: return of 0/1 in function 'get_current_context' with >> return type bool >> >> Return statements in functions returning bool should use true/false >> instead of 1/0. >> >> Generated by: scripts/coccinelle/misc/boolreturn.cocci >> >> Reported-by: Zeal Robot >> Signed-off-by: Jing Yangyang >> --- >>   tools/testing/selftests/arm64/signal/test_signals_utils.h | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/arm64/signal/test_signals_utils.h b/tools/testing/selftests/arm64/signal/test_signals_utils.h >> index 6772b5c..66122e6 100644 >> --- a/tools/testing/selftests/arm64/signal/test_signals_utils.h >> +++ b/tools/testing/selftests/arm64/signal/test_signals_utils.h >> @@ -109,7 +109,7 @@ static __always_inline bool get_current_context(struct tdescr *td, >>       if (seen_already) { >>           fprintf(stdout, >>               "Unexpected successful sigreturn detected: live_uc is stale !\n"); >> -        return 0; >> +        return false; The change is fine. However, the function doc references to return 1/0 needs updates as well. * 1. grab a valid sigcontext into td->live_uc for result analysis: in * such case it returns 1. * * 2. detect if, somehow, a previously grabbed live_uc context has been * used actively with a sigreturn: in such a case the execution would have * magically resumed in the middle of this function itself (seen_already==1): * in such a case return 0, since in fact we have not just simply grabbed * the context. thanks, -- Shuah