From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3286EC433F5 for ; Mon, 10 Oct 2022 17:02:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbiJJRCr (ORCPT ); Mon, 10 Oct 2022 13:02:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229956AbiJJRCg (ORCPT ); Mon, 10 Oct 2022 13:02:36 -0400 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C86566857 for ; Mon, 10 Oct 2022 10:02:31 -0700 (PDT) Received: by mail-io1-xd2f.google.com with SMTP id h203so1254785iof.1 for ; Mon, 10 Oct 2022 10:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Sku5J7PyxwEr729i9MgpltbFTlOLk2agD7q4nskSz/8=; b=GfZe1er7asCP0ALA4xE6quMC5DxOFhh/7LbUYi1cC7lbaczkr2bHNyRdEFHjv207Vn Wiqxjkj1oviICRGEGXz7Mcg6Awz7FctKFrN1vYbsEPlnEa06eG1DIgm3v2oSHEgptcur spkpD/4M/kpmoHV9rtcTZJr2HLtXnkPJPYdPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Sku5J7PyxwEr729i9MgpltbFTlOLk2agD7q4nskSz/8=; b=fN2fT5WMDJSRD31tJK/TwfSTx5HWuAortCudcQwHDgP5pH4sIqsQmvYoGnOVIF8LW+ vxoMrvNP/Nbx2AXE74i3fGJ1KQvl2KejpNsMOXd3EW2oED+wIZ9k0rAfym58hB48bhfi ho50KDVFSp97BqVraQ41s9YIBAV3Gt3f93Gs3iGVl5IsVZ7Kg2KELnmIaRVr1Qsw5C3C BHu7sP7mWmMok8H0SH4kC2Tx3luuJ6slubYyGfiBrZcg3pzS91n5l2scxY6RiNddY76M 95fEhvAyRyDEy2UzN6Is2gHmxepunJf0jpw0/sgGLEidz6cmzqkp/Jv96FEIo23m+uMl w3eg== X-Gm-Message-State: ACrzQf2P8dGLRj4A7knGY+qdIvCJ+NoJyHwQijyAs23e1f89Fkbzjy2K NG2Kxl6NuMMb2nfU8UzGvYxAEQ== X-Google-Smtp-Source: AMsMyM5MdoRFlHdN/oWlHzW5c6TiU0d91kNy2sJnAp7PMUFFDAN10eFKJ+CZjzZGIA+MbGA7ivOSYw== X-Received: by 2002:a05:6638:2491:b0:35a:53dd:f98e with SMTP id x17-20020a056638249100b0035a53ddf98emr10571658jat.261.1665421350124; Mon, 10 Oct 2022 10:02:30 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id v2-20020a02b082000000b0036378e4747esm4096449jah.114.2022.10.10.10.02.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 10:02:29 -0700 (PDT) Message-ID: Date: Mon, 10 Oct 2022 11:02:29 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH -next v5 2/4] selftests/memory-hotplug: Restore memory before exit Content-Language: en-US To: David Hildenbrand , zhaogongyi , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kselftest@vger.kernel.org" Cc: "akinobu.mita@gmail.com" , "corbet@lwn.net" , "osalvador@suse.de" , "shuah@kernel.org" , Shuah Khan References: From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 10/10/22 00:54, David Hildenbrand wrote: > On 08.10.22 03:40, zhaogongyi wrote: >> >> Yes, online_memory_expect_success() already prints a warning, remove the warning in online_all_offline_memory() seems ok, >> >> My previous consideration was that one more log information would make it easier to locate the wrong location. > > Let's keep it simple unless there is real reason to warn twice. > zhaogongyi, Please note that I already applied the patches to linux-kselftest next for my second pull request before the merge window. Please send the change David requested in a separate patch on top of next as a fix. thanks, -- Shuah