From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fra-out-008.esa.eu-central-1.outbound.mail-perimeter.amazon.com (fra-out-008.esa.eu-central-1.outbound.mail-perimeter.amazon.com [35.158.23.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B34221D3CC; Wed, 14 Jan 2026 13:57:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=35.158.23.94 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768399037; cv=none; b=WmWdF9SvF7MW1mMaEnKXZ64X4Qatfsb4xqeUxfgZJTm8ZBqjVjCZ5dz7rqodXsNPWn2wTaMfmf4EEAfzuOxMpNcquKVrE7q7bAO3GVXGD7YAO6f4vQW7esAA9yKYWhTLSBwOB28GiHDYDzpyU7FeRRrXTfsc8gQNa+Mzne+mZFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768399037; c=relaxed/simple; bh=1JkDlurwWk55AzLOFJDArMZykzGsjV26pSqNxyrQBe4=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=jvIt/5dEUmcUr3XFhUmPLl8Ho9Ul+tStjevl9EaL9dcUbPkjJ/bGPC2aHRpFqVKrNf+csmTkgPtSDavKd/kUMP/VMllzuy/oLl15dQafzTR1dKCWQqiA+LK9M5RzKbED40joSi89+Gn31XECpT63+r+rXIjyR5DQt3Jd+u/UB9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.uk; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=Ei4qX3mg; arc=none smtp.client-ip=35.158.23.94 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="Ei4qX3mg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1768399035; x=1799935035; h=message-id:date:mime-version:reply-to:subject:to:cc: references:from:in-reply-to:content-transfer-encoding; bh=X0wS+NExQh+M8KgHpz2Gdy3x5KfpNxu9ZGrCLn5oS58=; b=Ei4qX3mgd81vByPvrJVF8LH+edpdxnl0uRQN3FXC0J+hSJbw+GADzSyy hNbftZ4qhXGm2QC1dX7RtUFhGKWsc3tcsLUm60RYoEFnhnqm0H7tJ4diI o59VkTvIMMvoEWNzZ7rOUmUccCFxkBRFogjw8HDWz/okw1jnPcFRmjDOx q5ORCa8ZiBB71e2ByYqIGNRQa2DQkMvqCcKVCxa69kByNVwIZTbOYrxBY 85NmJOn+r1NzWVMPNFwoPOth47X7HsLYgYBLKFWMhyQ8ZYJD6mW91PDzC yGx562qM+wtpBzEHKNLTpw7TbaWIWbhWFxsb+G81BwvLqHWzvFrUUcs3z g==; X-CSE-ConnectionGUID: iO8DhPxBRPuaaivOKTdJYg== X-CSE-MsgGUID: Xpamj4VgTXmh9bqFPpAB6A== X-IronPort-AV: E=Sophos;i="6.21,225,1763424000"; d="scan'208";a="7900619" Received: from ip-10-6-3-216.eu-central-1.compute.internal (HELO smtpout.naws.eu-central-1.prod.farcaster.email.amazon.dev) ([10.6.3.216]) by internal-fra-out-008.esa.eu-central-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2026 13:57:13 +0000 Received: from EX19MTAEUC001.ant.amazon.com [54.240.197.225:26534] by smtpin.naws.eu-central-1.prod.farcaster.email.amazon.dev [10.0.30.60:2525] with esmtp (Farcaster) id fbe8cebb-b0d5-489e-8423-36b49c4d2af0; Wed, 14 Jan 2026 13:57:13 +0000 (UTC) X-Farcaster-Flow-ID: fbe8cebb-b0d5-489e-8423-36b49c4d2af0 Received: from EX19D005EUB003.ant.amazon.com (10.252.51.31) by EX19MTAEUC001.ant.amazon.com (10.252.51.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Wed, 14 Jan 2026 13:57:12 +0000 Received: from [192.168.15.25] (10.106.82.12) by EX19D005EUB003.ant.amazon.com (10.252.51.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Wed, 14 Jan 2026 13:57:08 +0000 Message-ID: Date: Wed, 14 Jan 2026 13:57:08 +0000 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Subject: Re: [PATCH v8 01/13] x86: export set_direct_map_valid_noflush to KVM module To: Dave Hansen , "Kalyazin, Nikita" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" CC: "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oupton@kernel.org" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "seanjc@google.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "david@kernel.org" , "lorenzo.stoakes@oracle.com" , "Liam.Howlett@oracle.com" , "vbabka@suse.cz" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "song@kernel.org" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jolsa@kernel.org" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "shuah@kernel.org" , "riel@surriel.com" , "baohua@kernel.org" , "ryan.roberts@arm.com" , "jgross@suse.com" , "yu-cheng.yu@intel.com" , "kas@kernel.org" , "coxu@redhat.com" , "kevin.brodsky@arm.com" , "ackerleytng@google.com" , "maobibo@loongson.cn" , "prsampat@amd.com" , "mlevitsk@redhat.com" , "isaku.yamahata@intel.com" , "jmattson@google.com" , "jthoughton@google.com" , "linux-arm-kernel@lists.infradead.org" , "vannapurve@google.com" , "jackmanb@google.com" , "aneesh.kumar@kernel.org" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Itazuri, Takahiro" , "Manwaring, Derek" , "Cali, Marco" References: <20251205165743.9341-1-kalyazin@amazon.com> <20251205165743.9341-2-kalyazin@amazon.com> <9409531b-589b-4a54-b122-06a3cf0846f3@intel.com> Content-Language: en-US From: Nikita Kalyazin Autocrypt: addr=kalyazin@amazon.com; keydata= xjMEY+ZIvRYJKwYBBAHaRw8BAQdA9FwYskD/5BFmiiTgktstviS9svHeszG2JfIkUqjxf+/N JU5pa2l0YSBLYWx5YXppbiA8a2FseWF6aW5AYW1hem9uLmNvbT7CjwQTFggANxYhBGhhGDEy BjLQwD9FsK+SyiCpmmTzBQJnrNfABQkFps9DAhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQr5LK IKmaZPOpfgD/exazh4C2Z8fNEz54YLJ6tuFEgQrVQPX6nQ/PfQi2+dwBAMGTpZcj9Z9NvSe1 CmmKYnYjhzGxzjBs8itSUvWIcMsFzjgEY+ZIvRIKKwYBBAGXVQEFAQEHQCqd7/nb2tb36vZt ubg1iBLCSDctMlKHsQTp7wCnEc4RAwEIB8J+BBgWCAAmFiEEaGEYMTIGMtDAP0Wwr5LKIKma ZPMFAmes18AFCQWmz0MCGwwACgkQr5LKIKmaZPNTlQEA+q+rGFn7273rOAg+rxPty0M8lJbT i2kGo8RmPPLu650A/1kWgz1AnenQUYzTAFnZrKSsXAw5WoHaDLBz9kiO5pAK In-Reply-To: <9409531b-589b-4a54-b122-06a3cf0846f3@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EX19D006EUC001.ant.amazon.com (10.252.51.203) To EX19D005EUB003.ant.amazon.com (10.252.51.31) On 05/12/2025 17:26, Dave Hansen wrote: > On 12/5/25 08:57, Kalyazin, Nikita wrote: > ... >> +EXPORT_SYMBOL_FOR_MODULES(set_direct_map_valid_noflush, "kvm"); > > I think this export is a bad idea. The interface is abhorrent enough, > but exporting it just invites abuse and bugs. > > I think what this really needs is a pair of helpers that are just: > > folio_zap_direct_map() > and > folio_restore_direct_map() > > that take a folio. *Those* can get exported to modules and those should > internally flush the TLB and not expect callers to do it. Thanks, implemented in the v9.